You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/10/09 03:32:13 UTC

Review Request 26475: Views: create dtd to help validate view.xml files

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26475/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-7705
    https://issues.apache.org/jira/browse/AMBARI-7705


Repository: ambari


Description
-------

Useful for development to validate a view.xml.

Create dtd and validate existing view.xml files.

See public wiki for view xml description...

https://cwiki.apache.org/confluence/display/AMBARI/View+Definition


Diffs
-----

  ambari-admin/src/main/resources/view.xml 9bb4d8e 
  ambari-views/src/main/resources/view.xsd PRE-CREATION 
  ambari-views/src/test/java/org/apache/ambari/view/ViewXmlTest.java PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/view.xml f23dae5 
  contrib/views/slider/src/main/resources/view.xml 8f8b78b 

Diff: https://reviews.apache.org/r/26475/diff/


Testing
-------

Validate all existing view.xml files in Ambari project.

Add new unit test to validate ambari-view examples view.xml files.

Run all unit tests for ambari-views, contrib/views and ambari-server.  All tests pass ...

New test … 
Running org.apache.ambari.view.ViewXmlTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.326 sec


ambari-views …

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23.683s
[INFO] Finished at: Wed Oct 08 19:19:53 EDT 2014
[INFO] Final Memory: 18M/81M
[INFO] ------------------------------------------------------------------------


contrib/views … 

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Contrib Views .............................. SUCCESS [0.972s]
[INFO] Files ............................................. SUCCESS [3:15.919s]
[INFO] Jobs .............................................. SUCCESS [3:39.283s]
[INFO] Pig ............................................... SUCCESS [2:55.291s]
[INFO] Slider ............................................ SUCCESS [2:21.604s]
[INFO] Capacity Scheduler ................................ SUCCESS [2:19.488s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:33.971s
[INFO] Finished at: Wed Oct 08 19:38:46 EDT 2014
[INFO] Final Memory: 39M/90M
[INFO] ------------------------------------------------------------------------


ambari-server … 

Results :

Tests run: 2136, Failures: 0, Errors: 0, Skipped: 15

…

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 41:48.970s
[INFO] Finished at: Wed Oct 08 21:21:15 EDT 2014
[INFO] Final Memory: 46M/393M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Re: Review Request 26475: Views: create dtd to help validate view.xml files

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26475/#review55970
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Oct. 8, 2014, 9:32 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26475/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 9:32 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-7705
>     https://issues.apache.org/jira/browse/AMBARI-7705
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Useful for development to validate a view.xml.
> 
> Create dtd and validate existing view.xml files.
> 
> See public wiki for view xml description...
> 
> https://cwiki.apache.org/confluence/display/AMBARI/View+Definition
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/view.xml 9bb4d8e 
>   ambari-views/src/main/resources/view.xsd PRE-CREATION 
>   ambari-views/src/test/java/org/apache/ambari/view/ViewXmlTest.java PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/view.xml f23dae5 
>   contrib/views/slider/src/main/resources/view.xml 8f8b78b 
> 
> Diff: https://reviews.apache.org/r/26475/diff/
> 
> 
> Testing
> -------
> 
> Validate all existing view.xml files in Ambari project.
> 
> Add new unit test to validate ambari-view examples view.xml files.
> 
> Run all unit tests for ambari-views, contrib/views and ambari-server.  All tests pass ...
> 
> New test … 
> Running org.apache.ambari.view.ViewXmlTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.326 sec
> 
> 
> ambari-views …
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23.683s
> [INFO] Finished at: Wed Oct 08 19:19:53 EDT 2014
> [INFO] Final Memory: 18M/81M
> [INFO] ------------------------------------------------------------------------
> 
> 
> contrib/views … 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Contrib Views .............................. SUCCESS [0.972s]
> [INFO] Files ............................................. SUCCESS [3:15.919s]
> [INFO] Jobs .............................................. SUCCESS [3:39.283s]
> [INFO] Pig ............................................... SUCCESS [2:55.291s]
> [INFO] Slider ............................................ SUCCESS [2:21.604s]
> [INFO] Capacity Scheduler ................................ SUCCESS [2:19.488s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:33.971s
> [INFO] Finished at: Wed Oct 08 19:38:46 EDT 2014
> [INFO] Final Memory: 39M/90M
> [INFO] ------------------------------------------------------------------------
> 
> 
> ambari-server … 
> 
> Results :
> 
> Tests run: 2136, Failures: 0, Errors: 0, Skipped: 15
> 
> …
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 41:48.970s
> [INFO] Finished at: Wed Oct 08 21:21:15 EDT 2014
> [INFO] Final Memory: 46M/393M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Re: Review Request 26475: Views: create dtd to help validate view.xml files

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26475/#review56049
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Oct. 9, 2014, 1:32 a.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26475/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 1:32 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-7705
>     https://issues.apache.org/jira/browse/AMBARI-7705
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Useful for development to validate a view.xml.
> 
> Create dtd and validate existing view.xml files.
> 
> See public wiki for view xml description...
> 
> https://cwiki.apache.org/confluence/display/AMBARI/View+Definition
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/view.xml 9bb4d8e 
>   ambari-views/src/main/resources/view.xsd PRE-CREATION 
>   ambari-views/src/test/java/org/apache/ambari/view/ViewXmlTest.java PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/view.xml f23dae5 
>   contrib/views/slider/src/main/resources/view.xml 8f8b78b 
> 
> Diff: https://reviews.apache.org/r/26475/diff/
> 
> 
> Testing
> -------
> 
> Validate all existing view.xml files in Ambari project.
> 
> Add new unit test to validate ambari-view examples view.xml files.
> 
> Run all unit tests for ambari-views, contrib/views and ambari-server.  All tests pass ...
> 
> New test … 
> Running org.apache.ambari.view.ViewXmlTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.326 sec
> 
> 
> ambari-views …
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23.683s
> [INFO] Finished at: Wed Oct 08 19:19:53 EDT 2014
> [INFO] Final Memory: 18M/81M
> [INFO] ------------------------------------------------------------------------
> 
> 
> contrib/views … 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Contrib Views .............................. SUCCESS [0.972s]
> [INFO] Files ............................................. SUCCESS [3:15.919s]
> [INFO] Jobs .............................................. SUCCESS [3:39.283s]
> [INFO] Pig ............................................... SUCCESS [2:55.291s]
> [INFO] Slider ............................................ SUCCESS [2:21.604s]
> [INFO] Capacity Scheduler ................................ SUCCESS [2:19.488s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:33.971s
> [INFO] Finished at: Wed Oct 08 19:38:46 EDT 2014
> [INFO] Final Memory: 39M/90M
> [INFO] ------------------------------------------------------------------------
> 
> 
> ambari-server … 
> 
> Results :
> 
> Tests run: 2136, Failures: 0, Errors: 0, Skipped: 15
> 
> …
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 41:48.970s
> [INFO] Finished at: Wed Oct 08 21:21:15 EDT 2014
> [INFO] Final Memory: 46M/393M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Re: Review Request 26475: Views: create dtd to help validate view.xml files

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26475/#review56048
-----------------------------------------------------------



ambari-views/src/test/java/org/apache/ambari/view/ViewXmlTest.java
<https://reviews.apache.org/r/26475/#comment96401>

    Nice


- Alejandro Fernandez


On Oct. 9, 2014, 1:32 a.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26475/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 1:32 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-7705
>     https://issues.apache.org/jira/browse/AMBARI-7705
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Useful for development to validate a view.xml.
> 
> Create dtd and validate existing view.xml files.
> 
> See public wiki for view xml description...
> 
> https://cwiki.apache.org/confluence/display/AMBARI/View+Definition
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/view.xml 9bb4d8e 
>   ambari-views/src/main/resources/view.xsd PRE-CREATION 
>   ambari-views/src/test/java/org/apache/ambari/view/ViewXmlTest.java PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/view.xml f23dae5 
>   contrib/views/slider/src/main/resources/view.xml 8f8b78b 
> 
> Diff: https://reviews.apache.org/r/26475/diff/
> 
> 
> Testing
> -------
> 
> Validate all existing view.xml files in Ambari project.
> 
> Add new unit test to validate ambari-view examples view.xml files.
> 
> Run all unit tests for ambari-views, contrib/views and ambari-server.  All tests pass ...
> 
> New test … 
> Running org.apache.ambari.view.ViewXmlTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.326 sec
> 
> 
> ambari-views …
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23.683s
> [INFO] Finished at: Wed Oct 08 19:19:53 EDT 2014
> [INFO] Final Memory: 18M/81M
> [INFO] ------------------------------------------------------------------------
> 
> 
> contrib/views … 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Contrib Views .............................. SUCCESS [0.972s]
> [INFO] Files ............................................. SUCCESS [3:15.919s]
> [INFO] Jobs .............................................. SUCCESS [3:39.283s]
> [INFO] Pig ............................................... SUCCESS [2:55.291s]
> [INFO] Slider ............................................ SUCCESS [2:21.604s]
> [INFO] Capacity Scheduler ................................ SUCCESS [2:19.488s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:33.971s
> [INFO] Finished at: Wed Oct 08 19:38:46 EDT 2014
> [INFO] Final Memory: 39M/90M
> [INFO] ------------------------------------------------------------------------
> 
> 
> ambari-server … 
> 
> Results :
> 
> Tests run: 2136, Failures: 0, Errors: 0, Skipped: 15
> 
> …
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 41:48.970s
> [INFO] Finished at: Wed Oct 08 21:21:15 EDT 2014
> [INFO] Final Memory: 46M/393M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>