[GitHub] [iceberg] kbendick commented on a change in pull request #4395: Spark: Add custom metric for number of files read by a SparkScan

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #4395:
URL: https://github.com/apache/iceberg/pull/4395#discussion_r836957505



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java
##########
@@ -93,6 +93,11 @@
     }
   }
 
+  @Override
+  public String description() {
+    return "IcebergScan " + super.description();
+  }

Review comment:
       I am +1 on `BatchScan` -> `IcebergBatchScan` for UI purposes.
   
   I think that updating the `toString` method should be fine as well if need be, provided it passes tests etc. `IcebergBatchScan` is closer to the name of the class anyway than plain `IcebergScan`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org