You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/10/03 18:39:10 UTC

Re: Review Request 25945: Pass Promise to DispatchEvent to correctly discard on rejection.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/
-----------------------------------------------------------

(Updated Oct. 3, 2014, 9:39 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

rebased to dependency


Bugs: MESOS-1456 and MESOS-1751
    https://issues.apache.org/jira/browse/MESOS-1456
    https://issues.apache.org/jira/browse/MESOS-1751


Repository: mesos-git


Description
-------

Create a PromiseDispatchEvent to allow discarding of promises if the DispatchEvent can't be enqueued.

Also converted some shared_ptr to Owned to correctly track ownership.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4 
  3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976 
  3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 
  3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227 
  3rdparty/libprocess/include/process/event.hpp bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 
  3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
  src/tests/master_tests.cpp 705e5f2c0f9d693946e722cef63f38f3bff0d46b 

Diff: https://reviews.apache.org/r/25945/diff/


Testing
-------

Added test that fails without the patch.

Ran all tests (make check) with g++-4.4 and clang-3.5.


Thanks,

Dominic Hamon


Re: Review Request 25945: Pass Promise to DispatchEvent to correctly discard on rejection.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/#review55357
-----------------------------------------------------------


Bad patch!

Reviews applied: [26289, 25945]

Failed command: git apply --index 25945.patch

Error:
 error: patch failed: 3rdparty/libprocess/include/process/c++11/dispatch.hpp:5
error: 3rdparty/libprocess/include/process/c++11/dispatch.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/defer.hpp:9
error: 3rdparty/libprocess/include/process/defer.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/delay.hpp:5
error: 3rdparty/libprocess/include/process/delay.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/dispatch.hpp:6
error: 3rdparty/libprocess/include/process/dispatch.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/event.hpp:4
error: 3rdparty/libprocess/include/process/event.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/src/process.cpp:57
error: 3rdparty/libprocess/src/process.cpp: patch does not apply

- Mesos ReviewBot


On Oct. 3, 2014, 4:39 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25945/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 4:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1456 and MESOS-1751
>     https://issues.apache.org/jira/browse/MESOS-1456
>     https://issues.apache.org/jira/browse/MESOS-1751
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Create a PromiseDispatchEvent to allow discarding of promises if the DispatchEvent can't be enqueued.
> 
> Also converted some shared_ptr to Owned to correctly track ownership.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4 
>   3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976 
>   3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 
>   3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227 
>   3rdparty/libprocess/include/process/event.hpp bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 
>   3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
>   src/tests/master_tests.cpp 705e5f2c0f9d693946e722cef63f38f3bff0d46b 
> 
> Diff: https://reviews.apache.org/r/25945/diff/
> 
> 
> Testing
> -------
> 
> Added test that fails without the patch.
> 
> Ran all tests (make check) with g++-4.4 and clang-3.5.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 25945: Pass Promise to DispatchEvent to correctly fail on rejection.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/#review55611
-----------------------------------------------------------


Bad patch!

Reviews applied: [26289, 25945]

Failed command: git apply --index 25945.patch

Error:
 error: patch failed: 3rdparty/libprocess/include/process/c++11/dispatch.hpp:5
error: 3rdparty/libprocess/include/process/c++11/dispatch.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/defer.hpp:9
error: 3rdparty/libprocess/include/process/defer.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/delay.hpp:5
error: 3rdparty/libprocess/include/process/delay.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/dispatch.hpp:6
error: 3rdparty/libprocess/include/process/dispatch.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/event.hpp:4
error: 3rdparty/libprocess/include/process/event.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/src/process.cpp:57
error: 3rdparty/libprocess/src/process.cpp: patch does not apply

- Mesos ReviewBot


On Oct. 6, 2014, 10:11 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25945/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 10:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1456 and MESOS-1751
>     https://issues.apache.org/jira/browse/MESOS-1456
>     https://issues.apache.org/jira/browse/MESOS-1751
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Create a PromiseDispatchEvent to allow failing of promises if the DispatchEvent can't be enqueued.
> 
> Also converted some shared_ptr to Owned to correctly track ownership.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4 
>   3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976 
>   3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 
>   3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227 
>   3rdparty/libprocess/include/process/event.hpp bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 
>   3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
>   3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b 
>   src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd 
> 
> Diff: https://reviews.apache.org/r/25945/diff/
> 
> 
> Testing
> -------
> 
> Added test that fails without the patch.
> 
> Ran all tests (make check) with g++-4.4 and clang-3.5.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 25945: Pass Promise to DispatchEvent to correctly fail on rejection.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/#review56564
-----------------------------------------------------------


Bad patch!

Reviews applied: [26289]

Failed command: git apply --index 26289.patch

Error:
 error: patch failed: 3rdparty/libprocess/include/process/event.hpp:1
error: 3rdparty/libprocess/include/process/event.hpp: patch does not apply

- Mesos ReviewBot


On Oct. 14, 2014, 8:09 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25945/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 8:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1456, MESOS-1751 and MESOS-1866
>     https://issues.apache.org/jira/browse/MESOS-1456
>     https://issues.apache.org/jira/browse/MESOS-1751
>     https://issues.apache.org/jira/browse/MESOS-1866
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Create a PromiseDispatchEvent to allow failing of promises if the DispatchEvent can't be enqueued.
> 
> Also converted some shared_ptr to Owned to correctly track ownership.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4 
>   3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976 
>   3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 
>   3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227 
>   3rdparty/libprocess/include/process/event.hpp bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 
>   3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 07b298f151094e818287f741b3e0efd28374e82b 
>   3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
>   3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b 
>   src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd 
> 
> Diff: https://reviews.apache.org/r/25945/diff/
> 
> 
> Testing
> -------
> 
> Added test that fails without the patch.
> 
> Ran all tests (make check) with g++-4.4 and clang-3.5.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 25945: Pass Promise to DispatchEvent to correctly fail on rejection.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/
-----------------------------------------------------------

(Updated Oct. 14, 2014, 1:09 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

rebased


Bugs: MESOS-1456, MESOS-1751 and MESOS-1866
    https://issues.apache.org/jira/browse/MESOS-1456
    https://issues.apache.org/jira/browse/MESOS-1751
    https://issues.apache.org/jira/browse/MESOS-1866


Repository: mesos-git


Description
-------

Create a PromiseDispatchEvent to allow failing of promises if the DispatchEvent can't be enqueued.

Also converted some shared_ptr to Owned to correctly track ownership.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4 
  3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976 
  3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 
  3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227 
  3rdparty/libprocess/include/process/event.hpp bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 
  3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 07b298f151094e818287f741b3e0efd28374e82b 
  3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
  3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b 
  src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd 

Diff: https://reviews.apache.org/r/25945/diff/


Testing
-------

Added test that fails without the patch.

Ran all tests (make check) with g++-4.4 and clang-3.5.


Thanks,

Dominic Hamon


Re: Review Request 25945: Pass Promise to DispatchEvent to correctly fail on rejection.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/
-----------------------------------------------------------

(Updated Oct. 7, 2014, 10:51 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

rebased properly.


Bugs: MESOS-1456, MESOS-1751 and MESOS-1866
    https://issues.apache.org/jira/browse/MESOS-1456
    https://issues.apache.org/jira/browse/MESOS-1751
    https://issues.apache.org/jira/browse/MESOS-1866


Repository: mesos-git


Description
-------

Create a PromiseDispatchEvent to allow failing of promises if the DispatchEvent can't be enqueued.

Also converted some shared_ptr to Owned to correctly track ownership.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4 
  3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976 
  3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 
  3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227 
  3rdparty/libprocess/include/process/event.hpp bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 
  3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
  3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b 
  src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd 

Diff: https://reviews.apache.org/r/25945/diff/


Testing
-------

Added test that fails without the patch.

Ran all tests (make check) with g++-4.4 and clang-3.5.


Thanks,

Dominic Hamon


Re: Review Request 25945: Pass Promise to DispatchEvent to correctly fail on rejection.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/
-----------------------------------------------------------

(Updated Oct. 7, 2014, 1:27 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

added MESOS-1866 to the bugs -- @vinodkone


Bugs: MESOS-1456, MESOS-1751 and MESOS-1866
    https://issues.apache.org/jira/browse/MESOS-1456
    https://issues.apache.org/jira/browse/MESOS-1751
    https://issues.apache.org/jira/browse/MESOS-1866


Repository: mesos-git


Description
-------

Create a PromiseDispatchEvent to allow failing of promises if the DispatchEvent can't be enqueued.

Also converted some shared_ptr to Owned to correctly track ownership.


Diffs
-----

  3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4 
  3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976 
  3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 
  3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227 
  3rdparty/libprocess/include/process/event.hpp bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 
  3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
  3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b 
  src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd 

Diff: https://reviews.apache.org/r/25945/diff/


Testing
-------

Added test that fails without the patch.

Ran all tests (make check) with g++-4.4 and clang-3.5.


Thanks,

Dominic Hamon


Re: Review Request 25945: Pass Promise to DispatchEvent to correctly fail on rejection.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/
-----------------------------------------------------------

(Updated Oct. 6, 2014, 3:11 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

changed discard to fail. rebased.


Summary (updated)
-----------------

Pass Promise to DispatchEvent to correctly fail on rejection.


Bugs: MESOS-1456 and MESOS-1751
    https://issues.apache.org/jira/browse/MESOS-1456
    https://issues.apache.org/jira/browse/MESOS-1751


Repository: mesos-git


Description (updated)
-------

Create a PromiseDispatchEvent to allow failing of promises if the DispatchEvent can't be enqueued.

Also converted some shared_ptr to Owned to correctly track ownership.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4 
  3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976 
  3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 
  3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227 
  3rdparty/libprocess/include/process/event.hpp bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 
  3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
  3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b 
  src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd 

Diff: https://reviews.apache.org/r/25945/diff/


Testing
-------

Added test that fails without the patch.

Ran all tests (make check) with g++-4.4 and clang-3.5.


Thanks,

Dominic Hamon


Re: Review Request 25945: Pass Promise to DispatchEvent to correctly discard on rejection.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/#review55373
-----------------------------------------------------------


Bad patch!

Reviews applied: [26289, 25945]

Failed command: git apply --index 25945.patch

Error:
 error: patch failed: 3rdparty/libprocess/include/process/c++11/dispatch.hpp:5
error: 3rdparty/libprocess/include/process/c++11/dispatch.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/defer.hpp:9
error: 3rdparty/libprocess/include/process/defer.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/delay.hpp:5
error: 3rdparty/libprocess/include/process/delay.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/dispatch.hpp:6
error: 3rdparty/libprocess/include/process/dispatch.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/event.hpp:4
error: 3rdparty/libprocess/include/process/event.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/src/process.cpp:57
error: 3rdparty/libprocess/src/process.cpp: patch does not apply

- Mesos ReviewBot


On Oct. 3, 2014, 5:59 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25945/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 5:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1456 and MESOS-1751
>     https://issues.apache.org/jira/browse/MESOS-1456
>     https://issues.apache.org/jira/browse/MESOS-1751
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Create a PromiseDispatchEvent to allow discarding of promises if the DispatchEvent can't be enqueued.
> 
> Also converted some shared_ptr to Owned to correctly track ownership.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4 
>   3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976 
>   3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 
>   3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227 
>   3rdparty/libprocess/include/process/event.hpp bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 
>   3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
>   3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b 
>   src/tests/master_tests.cpp 705e5f2c0f9d693946e722cef63f38f3bff0d46b 
> 
> Diff: https://reviews.apache.org/r/25945/diff/
> 
> 
> Testing
> -------
> 
> Added test that fails without the patch.
> 
> Ran all tests (make check) with g++-4.4 and clang-3.5.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 25945: Pass Promise to DispatchEvent to correctly discard on rejection.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/
-----------------------------------------------------------

(Updated Oct. 3, 2014, 10:59 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Bugs: MESOS-1456 and MESOS-1751
    https://issues.apache.org/jira/browse/MESOS-1456
    https://issues.apache.org/jira/browse/MESOS-1751


Repository: mesos-git


Description
-------

Create a PromiseDispatchEvent to allow discarding of promises if the DispatchEvent can't be enqueued.

Also converted some shared_ptr to Owned to correctly track ownership.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4 
  3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976 
  3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 
  3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227 
  3rdparty/libprocess/include/process/event.hpp bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 
  3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
  3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b 
  src/tests/master_tests.cpp 705e5f2c0f9d693946e722cef63f38f3bff0d46b 

Diff: https://reviews.apache.org/r/25945/diff/


Testing
-------

Added test that fails without the patch.

Ran all tests (make check) with g++-4.4 and clang-3.5.


Thanks,

Dominic Hamon