[GitHub] [druid] jihoonson commented on a change in pull request #10448: Added CronScheduler support as a proof to clock drift while emitting metrics

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #10448:
URL: https://github.com/apache/druid/pull/10448#discussion_r552386109



##########
File path: server/src/main/java/org/apache/druid/server/metrics/MetricsModule.java
##########
@@ -108,10 +108,10 @@ public MonitorScheduler getMonitorScheduler(
 
     return new MonitorScheduler(
         config.get(),
-        CronScheduler.newBuilder(Duration.ofSeconds(1L)).setThreadName("MonitorScheduler-%s").build(),
+        CronScheduler.newBuilder(Duration.ofSeconds(1L)).setThreadName("MonitorSchedulerThread").build(),
         emitter,
         monitors,
-        Executors.newCachedThreadPool()
+        Execs.multiThreaded(64, "MonitorThread-%d")

Review comment:
       This looks like an overkill. What was the rationale for using this many threads?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org