You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/21 14:16:31 UTC

[GitHub] [flink] JingGe commented on pull request #17501: [Draft][FLINK-21406][RecordFormat] build AvroParquetRecordFormat for the new FileSource

JingGe commented on pull request #17501:
URL: https://github.com/apache/flink/pull/17501#issuecomment-948663153


   > Thanks for the nice discussion! I think I now better understand the contribution.
   > 
   > Can you rename the class `AvroParquetRecordFormat` to `ParquetAvro...`? The codebase already has a `ParquetAvroWriters` class and it would be nice to keep it consistent.
   
   I named it after the naming convention from apache parquet lib e.g. `AvroParquetReader`. It sound nature for "reading avro from parquet". I would suggest we change ParquetAvroWriters to AvroParquetWriters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org