You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/16 14:18:33 UTC
[GitHub] [beam] kennknowles opened a new pull request, #21910: Revert "convert windmill min timestamp to beam min timestamp"
kennknowles opened a new pull request, #21910:
URL: https://github.com/apache/beam/pull/21910
This reverts commit 955177b8c38868e3dffad9ab4d7ee31dda06cc92.
This commit, from #21740, appears to be the culprit for failures starting at https://ci-beam.apache.org/view/PostCommit/job/beam_PreCommit_Java_Cron/5560/
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #21910: Revert "convert windmill min timestamp to beam min timestamp"
Posted by GitBox <gi...@apache.org>.
kennknowles merged PR #21910:
URL: https://github.com/apache/beam/pull/21910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #21910: Revert "convert windmill min timestamp to beam min timestamp"
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #21910:
URL: https://github.com/apache/beam/pull/21910#issuecomment-1157739344
Noting that java precommit is green, so presuming this restores signal. Still not sure if there was maybe a race condition in the prior merge, like the test was added or change independent of the culprit PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #21910: Revert "convert windmill min timestamp to beam min timestamp"
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #21910:
URL: https://github.com/apache/beam/pull/21910#issuecomment-1157724641
CC @naireen @scwhittle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #21910: Revert "convert windmill min timestamp to beam min timestamp"
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #21910:
URL: https://github.com/apache/beam/pull/21910#issuecomment-1157796304
This may need to be reverted in the release branch too. : @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org