[jira] [Commented] (THRIFT-3904) Typo in node tutorial

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436928#comment-15436928 ] 

ASF GitHub Bot commented on THRIFT-3904:
----------------------------------------

GitHub user msonnabaum opened a pull request:

    https://github.com/apache/thrift/pull/1067

    THRIFT-3904 Fix typo in node tutorial.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/msonnabaum/thrift node-example-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1067.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1067
    
----
commit 6b24ebd23dc88efcb0f2fc52eb4ee67cd1f643da
Author: Mark Sonnabaum <ma...@sonnabaum.com>
Date:   2016-08-25T14:08:47Z

    THRIFT-3904 Fix typo in node tutorial.

----


> Typo in node tutorial
> ---------------------
>
>                 Key: THRIFT-3904
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3904
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library, Tutorial
>            Reporter: Mark Sonnabaum
>
> In the node tutorial (tutorial/nodejs/NodeClient.js), lines like `transport = thrift.TBufferedTransport()` cause transport to be undefined, which later get replaced with the default, so this example does work.
> I found the issue when using `thrift.TFramedTransport()`, which was erroring on the server side. It took me a while to figure out that the transport was falling back to buffered, because I was actually assigning the transport to undefined.
> Changing the lines to assign thrift.TFramedTransport instead of thrift.TFramedTransport() fixed it for me.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)