You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/08/04 00:22:12 UTC
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11123
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
IMPALA-7396: unblock testing with --thread_creation_fault_injection
These are minimal fixes to allow testing new patches with the fault
injection.
ClientRequestState: fixing this seems somewhat involved, so disabled the
fault injection for now to unblock further testing.
HdfsScanNode: thread_state_.DecrementNumActive() was called on the error
path before the count had actually been incremented.
Testing:
Ran some of the end-to-end tests for 20-30 minutes and confirmed that
no Impalads crashed.
start-impala-cluster.py \
--impalad_args=--thread_creation_fault_injection=true
impala-py.test tests/query_test/*.py -n2 --verbose
Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
---
M be/src/exec/hdfs-scan-node.cc
M be/src/service/client-request-state.cc
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/11123/1
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
Patch Set 5:
> There were at least two layers:
> 1. The Coordinator was not in a terminal state, so it DCHECKed in
> the destructor.
> 2. I tried a few things to avoid that, including disabling the
> DCHECK and cancelling the query, but I still ended up hitting
> various lifecycle issues, e.g. backend_exec_complete_barrier_ was
> NULL.
Is there a JIRA for fixing those (don't see it linked to IMPALA-7396)?
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Aug 2018 23:43:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 13:48:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 16:57:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
Patch Set 1:
There were at least two layers:
1. The Coordinator was not in a terminal state, so it DCHECKed in the destructor.
2. I tried a few things to avoid that, including disabling the DCHECK and cancelling the query, but I still ended up hitting various lifecycle issues, e.g. backend_exec_complete_barrier_ was NULL.
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 16:57:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 20:17:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
Patch Set 5:
I think I intended to file a follow-up JIRA but overlooked it. Created https://issues.apache.org/jira/browse/IMPALA-7435
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Aug 2018 23:54:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11123
to look at the new patch set (#3).
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
IMPALA-7396: unblock testing with --thread_creation_fault_injection
These are minimal fixes to allow testing new patches with the fault
injection.
ClientRequestState: fixing this seems somewhat involved, so disabled the
fault injection for now to unblock further testing.
HdfsScanNode: thread_state_.DecrementNumActive() was called on the error
path before the count had actually been incremented.
Testing:
Ran some of the end-to-end tests for 20-30 minutes and confirmed that
no Impalads crashed.
start-impala-cluster.py \
--impalad_args=--thread_creation_fault_injection=true
impala-py.test tests/query_test/*.py -n2 --verbose
Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
---
M be/src/exec/hdfs-scan-node.cc
M be/src/service/client-request-state.cc
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/11123/3
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
Patch Set 3: -Code-Review
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/203/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 19:50:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
Patch Set 4: Verified+1 Code-Review+2
Carry +2/+1 (I accidentally pushed out a rebase while the precommit was running)
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 20:19:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
Patch Set 1: Code-Review+2
This looks good. Just curious, what goes wrong with client-request-state.cc?
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 16:45:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/186/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Aug 2018 01:00:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
IMPALA-7396: unblock testing with --thread_creation_fault_injection
These are minimal fixes to allow testing new patches with the fault
injection.
ClientRequestState: fixing this seems somewhat involved, so disabled the
fault injection for now to unblock further testing.
HdfsScanNode: thread_state_.DecrementNumActive() was called on the error
path before the count had actually been incremented.
Testing:
Ran some of the end-to-end tests for 20-30 minutes and confirmed that
no Impalads crashed.
start-impala-cluster.py \
--impalad_args=--thread_creation_fault_injection=true
impala-py.test tests/query_test/*.py -n2 --verbose
Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Reviewed-on: http://gerrit.cloudera.org:8080/11123
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M be/src/exec/hdfs-scan-node.cc
M be/src/service/client-request-state.cc
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7396: unblock testing with --thread creation fault injection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2926/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 16:57:34 +0000
Gerrit-HasComments: No