You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/05/31 11:56:17 UTC

[GitHub] [systemml] stanp7 opened a new pull request #929: Sigmoid doc 

stanp7 opened a new pull request #929:
URL: https://github.com/apache/systemml/pull/929


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemml] asfgit closed pull request #929: [DOC] Documentation for builtin sigmoid function

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #929:
URL: https://github.com/apache/systemml/pull/929


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemml] j143 commented on pull request #929: Sigmoid doc

Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #929:
URL: https://github.com/apache/systemml/pull/929#issuecomment-636472253


   Hi @stanp7 !
   
   Welcome to the project. Can we change the title to `[DOC] Documentation for builtin sigmoid function`
   
   - Janardhan 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemml] j143 commented on a change in pull request #929: Sigmoid doc

Posted by GitBox <gi...@apache.org>.
j143 commented on a change in pull request #929:
URL: https://github.com/apache/systemml/pull/929#discussion_r432949861



##########
File path: docs/builtins-reference.md
##########
@@ -30,6 +30,7 @@ limitations under the License.
     * [`steplm`-Function](#steplm-function)

Review comment:
       Can we add `sigmoid` to table of contents?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemml] j143 commented on pull request #929: [DOC] Documentation for builtin sigmoid function

Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #929:
URL: https://github.com/apache/systemml/pull/929#issuecomment-636494844


   Perfect! I will review and merge this by tomorrow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemml] j143 commented on pull request #929: [DOC] Documentation for builtin sigmoid function

Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #929:
URL: https://github.com/apache/systemml/pull/929#issuecomment-636588667


   Thanks @stanp7 - LGTM.
   🎉  🚀 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemml] j143 edited a comment on pull request #929: Sigmoid doc

Posted by GitBox <gi...@apache.org>.
j143 edited a comment on pull request #929:
URL: https://github.com/apache/systemml/pull/929#issuecomment-636472253


   Hi @stanp7 !
   
   Welcome to the project. Can we change 
   1. the title to `[DOC] Documentation for builtin sigmoid function`
   2. Shall we add a description to the PR, can be as much as possible.
   
   - Janardhan 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org