You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/03/15 09:29:59 UTC
[GitHub] [fineract] thesmallstar opened a new pull request #735: Fixes:
Broken build
thesmallstar opened a new pull request #735: Fixes: Broken build
URL: https://github.com/apache/fineract/pull/735
## Description
The first problem was fixed by sir @vorburger in #732 (and has that commit in this PR), build still failed and was due to duplicate migration version(name).
The build is passing locally, let's see what Travis has to say.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] thesmallstar commented on issue #735: Fixes: Broken build
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on issue #735: Fixes: Broken build
URL: https://github.com/apache/fineract/pull/735#issuecomment-599189401
@awasum This build passed, I don't this sir @vorburger will have any issues with this PR.
Maybe you can merge it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger merged pull request #735: Fixes: Broken build
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #735: Fixes: Broken build
URL: https://github.com/apache/fineract/pull/735
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] thesmallstar edited a comment on issue #735: Fixes:
Broken build
Posted by GitBox <gi...@apache.org>.
thesmallstar edited a comment on issue #735: Fixes: Broken build
URL: https://github.com/apache/fineract/pull/735#issuecomment-599189401
@awasum This build passed, I don't think sir @vorburger will have any issues with this PR.
Maybe you can merge it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services