You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by le...@apache.org on 2019/03/26 00:11:09 UTC

[incubator-druid] branch master updated: Fix some IntelliJ inspections (#7273)

This is an automated email from the ASF dual-hosted git repository.

leventov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git


The following commit(s) were added to refs/heads/master by this push:
     new bca40dc  Fix some IntelliJ inspections (#7273)
bca40dc is described below

commit bca40dcdaf3177b95d01187f413e1c0c6865964b
Author: Roman Leventov <le...@gmail.com>
AuthorDate: Mon Mar 25 21:11:01 2019 -0300

    Fix some IntelliJ inspections (#7273)
    
    Prepare TeamCity for IntelliJ 2018.3.1 upgrade. Mostly removed redundant exceptions declarations in `throws` clauses.
---
 .idea/inspectionProfiles/Druid.xml                      |  3 +++
 .../input/impl/prefetch/PrefetchSqlFirehoseFactory.java |  1 -
 .../java/org/apache/druid/tasklogs/NoopTaskLogs.java    |  3 +--
 .../druid/segment/loading/NoopDataSegmentArchiver.java  |  4 ++--
 .../druid/segment/loading/NoopDataSegmentKiller.java    |  6 ++----
 .../org/apache/druid/storage/azure/AzureTaskLogs.java   |  2 +-
 .../DerivativeDataSourceMetadataTest.java               |  4 ++--
 .../MaterializedViewSupervisorSpecTest.java             |  4 ++--
 .../druid/data/input/orc/OrcHadoopInputRowParser.java   | 17 ++++++++---------
 .../java/org/apache/druid/client/cache/RedisCache.java  |  3 +--
 .../FixedBucketsHistogramAggregatorFactory.java         |  3 +--
 .../druid/indexer/HadoopDruidIndexerMapperTest.java     |  5 ++---
 .../task/AppenderatorDriverRealtimeIndexTask.java       |  2 +-
 .../druid/indexing/common/task/HadoopIndexTask.java     |  2 +-
 .../overlord/supervisor/SupervisorResourceTest.java     |  2 +-
 .../org/apache/druid/segment/data/GenericIndexed.java   |  2 +-
 .../first/StringFirstBufferAggregatorTest.java          |  4 ++--
 .../last/StringLastBufferAggregatorTest.java            |  4 ++--
 .../org/apache/druid/client/cache/CaffeineCache.java    |  3 +--
 .../java/org/apache/druid/client/cache/MapCache.java    |  3 +--
 .../org/apache/druid/client/cache/MemcachedCache.java   |  2 +-
 .../curator/PotentiallyGzippedCompressionProvider.java  |  4 ++--
 .../server/security/AllowOptionsResourceFilter.java     |  2 +-
 .../apache/druid/segment/indexing/DataSchemaTest.java   |  2 +-
 .../appenderator/StreamAppenderatorDriverTest.java      |  2 +-
 .../firehose/EventReceiverFirehoseIdleTest.java         |  2 +-
 .../java/org/apache/druid/sql/http/ResultFormat.java    |  2 +-
 27 files changed, 43 insertions(+), 50 deletions(-)

diff --git a/.idea/inspectionProfiles/Druid.xml b/.idea/inspectionProfiles/Druid.xml
index 77078ae..0b1817e 100644
--- a/.idea/inspectionProfiles/Druid.xml
+++ b/.idea/inspectionProfiles/Druid.xml
@@ -79,6 +79,9 @@
     <inspection_tool class="IteratorHasNextCallsIteratorNext" enabled="true" level="ERROR" enabled_by_default="true" />
     <inspection_tool class="IteratorNextDoesNotThrowNoSuchElementException" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="Java8MapForEach" enabled="true" level="ERROR" enabled_by_default="true" />
+    <inspection_tool class="JavadocReference" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="REPORT_INACCESSIBLE" value="false" />
+    </inspection_tool>
     <inspection_tool class="JsonDuplicatePropertyKeys" enabled="true" level="ERROR" enabled_by_default="true" />
     <inspection_tool class="JsonStandardCompliance" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="LengthOneStringInIndexOf" enabled="true" level="ERROR" enabled_by_default="true" />
diff --git a/core/src/main/java/org/apache/druid/data/input/impl/prefetch/PrefetchSqlFirehoseFactory.java b/core/src/main/java/org/apache/druid/data/input/impl/prefetch/PrefetchSqlFirehoseFactory.java
index 4ae948f..d81b3bd 100644
--- a/core/src/main/java/org/apache/druid/data/input/impl/prefetch/PrefetchSqlFirehoseFactory.java
+++ b/core/src/main/java/org/apache/druid/data/input/impl/prefetch/PrefetchSqlFirehoseFactory.java
@@ -147,7 +147,6 @@ public abstract class PrefetchSqlFirehoseFactory<T>
 
   @Override
   public Firehose connect(InputRowParser<Map<String, Object>> firehoseParser, @Nullable File temporaryDirectory)
-      throws IOException
   {
     if (objects == null) {
       objects = ImmutableList.copyOf(Preconditions.checkNotNull(initObjects(), "objects"));
diff --git a/core/src/main/java/org/apache/druid/tasklogs/NoopTaskLogs.java b/core/src/main/java/org/apache/druid/tasklogs/NoopTaskLogs.java
index b26e712..a0dc877 100644
--- a/core/src/main/java/org/apache/druid/tasklogs/NoopTaskLogs.java
+++ b/core/src/main/java/org/apache/druid/tasklogs/NoopTaskLogs.java
@@ -24,7 +24,6 @@ import com.google.common.io.ByteSource;
 import org.apache.druid.java.util.common.logger.Logger;
 
 import java.io.File;
-import java.io.IOException;
 
 public class NoopTaskLogs implements TaskLogs
 {
@@ -43,7 +42,7 @@ public class NoopTaskLogs implements TaskLogs
   }
 
   @Override
-  public void pushTaskReports(String taskid, File reportFile) throws IOException
+  public void pushTaskReports(String taskid, File reportFile)
   {
     log.info("Not pushing reports for task: %s", taskid);
   }
diff --git a/core/src/test/java/org/apache/druid/segment/loading/NoopDataSegmentArchiver.java b/core/src/test/java/org/apache/druid/segment/loading/NoopDataSegmentArchiver.java
index 8524a87..4d89ec5 100644
--- a/core/src/test/java/org/apache/druid/segment/loading/NoopDataSegmentArchiver.java
+++ b/core/src/test/java/org/apache/druid/segment/loading/NoopDataSegmentArchiver.java
@@ -30,14 +30,14 @@ public class NoopDataSegmentArchiver implements DataSegmentArchiver
 {
   @Nullable
   @Override
-  public DataSegment archive(DataSegment segment) throws SegmentLoadingException
+  public DataSegment archive(DataSegment segment)
   {
     return segment;
   }
 
   @Nullable
   @Override
-  public DataSegment restore(DataSegment segment) throws SegmentLoadingException
+  public DataSegment restore(DataSegment segment)
   {
     return segment;
   }
diff --git a/core/src/test/java/org/apache/druid/segment/loading/NoopDataSegmentKiller.java b/core/src/test/java/org/apache/druid/segment/loading/NoopDataSegmentKiller.java
index 3aa24fd..6a30e7d 100644
--- a/core/src/test/java/org/apache/druid/segment/loading/NoopDataSegmentKiller.java
+++ b/core/src/test/java/org/apache/druid/segment/loading/NoopDataSegmentKiller.java
@@ -21,20 +21,18 @@ package org.apache.druid.segment.loading;
 
 import org.apache.druid.timeline.DataSegment;
 
-import java.io.IOException;
-
 /**
  * Mostly used for test purpose.
  */
 public class NoopDataSegmentKiller implements DataSegmentKiller
 {
   @Override
-  public void kill(DataSegment segments) throws SegmentLoadingException
+  public void kill(DataSegment segments)
   {
   }
 
   @Override
-  public void killAll() throws IOException
+  public void killAll()
   {
   }
 }
diff --git a/extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureTaskLogs.java b/extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureTaskLogs.java
index 1b5ab36..d75d200 100644
--- a/extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureTaskLogs.java
+++ b/extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureTaskLogs.java
@@ -57,7 +57,7 @@ public class AzureTaskLogs implements TaskLogs
   }
 
   @Override
-  public void pushTaskReports(String taskid, File reportFile) throws IOException
+  public void pushTaskReports(String taskid, File reportFile)
   {
     final String taskKey = getTaskReportsKey(taskid);
     log.info("Pushing task reports %s to: %s", reportFile, taskKey);
diff --git a/extensions-contrib/materialized-view-maintenance/src/test/java/org/apache/druid/indexing/materializedview/DerivativeDataSourceMetadataTest.java b/extensions-contrib/materialized-view-maintenance/src/test/java/org/apache/druid/indexing/materializedview/DerivativeDataSourceMetadataTest.java
index 0fe67bc..64a88f9 100644
--- a/extensions-contrib/materialized-view-maintenance/src/test/java/org/apache/druid/indexing/materializedview/DerivativeDataSourceMetadataTest.java
+++ b/extensions-contrib/materialized-view-maintenance/src/test/java/org/apache/druid/indexing/materializedview/DerivativeDataSourceMetadataTest.java
@@ -34,7 +34,7 @@ public class DerivativeDataSourceMetadataTest
   public ExpectedException expectedException = ExpectedException.none();
 
   @Test
-  public void testEmptyBaseDataSource() throws Exception
+  public void testEmptyBaseDataSource()
   {
     expectedException.expect(CoreMatchers.instanceOf(IllegalArgumentException.class));
     expectedException.expectMessage(
@@ -47,7 +47,7 @@ public class DerivativeDataSourceMetadataTest
   }
 
   @Test
-  public void testNullBaseDataSource() throws Exception
+  public void testNullBaseDataSource()
   {
     expectedException.expect(CoreMatchers.instanceOf(IllegalArgumentException.class));
     expectedException.expectMessage(
diff --git a/extensions-contrib/materialized-view-maintenance/src/test/java/org/apache/druid/indexing/materializedview/MaterializedViewSupervisorSpecTest.java b/extensions-contrib/materialized-view-maintenance/src/test/java/org/apache/druid/indexing/materializedview/MaterializedViewSupervisorSpecTest.java
index 97d5dba..3e6e1a6 100644
--- a/extensions-contrib/materialized-view-maintenance/src/test/java/org/apache/druid/indexing/materializedview/MaterializedViewSupervisorSpecTest.java
+++ b/extensions-contrib/materialized-view-maintenance/src/test/java/org/apache/druid/indexing/materializedview/MaterializedViewSupervisorSpecTest.java
@@ -199,7 +199,7 @@ public class MaterializedViewSupervisorSpecTest
   }
 
   @Test
-  public void testEmptyBaseDataSource() throws Exception
+  public void testEmptyBaseDataSource()
   {
     expectedException.expect(CoreMatchers.instanceOf(IllegalArgumentException.class));
     expectedException.expectMessage(
@@ -244,7 +244,7 @@ public class MaterializedViewSupervisorSpecTest
   }
 
   @Test
-  public void testNullBaseDataSource() throws Exception
+  public void testNullBaseDataSource()
   {
     expectedException.expect(CoreMatchers.instanceOf(IllegalArgumentException.class));
     expectedException.expectMessage(
diff --git a/extensions-contrib/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java b/extensions-contrib/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java
index 6d3340c..7619080 100644
--- a/extensions-contrib/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java
+++ b/extensions-contrib/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java
@@ -246,15 +246,14 @@ public class OrcHadoopInputRowParser implements InputRowParser<OrcStruct>
     builder.append(parseSpec.getTimestampSpec().getTimestampColumn()).append(":string");
     // the typeString seems positionally dependent, so repeated timestamp column causes incorrect mapping
     if (parseSpec.getDimensionsSpec().getDimensionNames().size() > 0) {
-      builder.append(",");
-      builder.append(String.join(
-          ":string,",
-          parseSpec.getDimensionsSpec()
-                   .getDimensionNames()
-                   .stream()
-                   .filter(s -> !s.equals(parseSpec.getTimestampSpec().getTimestampColumn()))
-                   .collect(Collectors.toList())));
-      builder.append(":string");
+      builder.append(
+          parseSpec
+              .getDimensionsSpec()
+              .getDimensionNames()
+              .stream()
+              .filter(s -> !s.equals(parseSpec.getTimestampSpec().getTimestampColumn()))
+              .collect(Collectors.joining(":string,", ",", ":string"))
+      );
     }
     builder.append(">");
 
diff --git a/extensions-contrib/redis-cache/src/main/java/org/apache/druid/client/cache/RedisCache.java b/extensions-contrib/redis-cache/src/main/java/org/apache/druid/client/cache/RedisCache.java
index 817a217..d85f1e0 100644
--- a/extensions-contrib/redis-cache/src/main/java/org/apache/druid/client/cache/RedisCache.java
+++ b/extensions-contrib/redis-cache/src/main/java/org/apache/druid/client/cache/RedisCache.java
@@ -30,7 +30,6 @@ import redis.clients.jedis.JedisPool;
 import redis.clients.jedis.JedisPoolConfig;
 import redis.clients.jedis.exceptions.JedisException;
 
-import java.io.IOException;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -151,7 +150,7 @@ public class RedisCache implements Cache
 
   @Override
   @LifecycleStop
-  public void close() throws IOException
+  public void close()
   {
     pool.close();
   }
diff --git a/extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramAggregatorFactory.java b/extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramAggregatorFactory.java
index 7ddcc9f..b829c2a 100644
--- a/extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramAggregatorFactory.java
+++ b/extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramAggregatorFactory.java
@@ -26,7 +26,6 @@ import org.apache.druid.java.util.common.StringUtils;
 import org.apache.druid.query.aggregation.AggregateCombiner;
 import org.apache.druid.query.aggregation.Aggregator;
 import org.apache.druid.query.aggregation.AggregatorFactory;
-import org.apache.druid.query.aggregation.AggregatorFactoryNotMergeableException;
 import org.apache.druid.query.aggregation.AggregatorUtil;
 import org.apache.druid.query.aggregation.BufferAggregator;
 import org.apache.druid.query.aggregation.ObjectAggregateCombiner;
@@ -172,7 +171,7 @@ public class FixedBucketsHistogramAggregatorFactory extends AggregatorFactory
   }
 
   @Override
-  public AggregatorFactory getMergingFactory(AggregatorFactory other) throws AggregatorFactoryNotMergeableException
+  public AggregatorFactory getMergingFactory(AggregatorFactory other)
   {
     return new FixedBucketsHistogramAggregatorFactory(
         name,
diff --git a/indexing-hadoop/src/test/java/org/apache/druid/indexer/HadoopDruidIndexerMapperTest.java b/indexing-hadoop/src/test/java/org/apache/druid/indexer/HadoopDruidIndexerMapperTest.java
index 43ca77d..e13663e 100644
--- a/indexing-hadoop/src/test/java/org/apache/druid/indexer/HadoopDruidIndexerMapperTest.java
+++ b/indexing-hadoop/src/test/java/org/apache/druid/indexer/HadoopDruidIndexerMapperTest.java
@@ -50,7 +50,6 @@ import org.junit.Test;
 
 import java.io.DataInput;
 import java.io.DataOutput;
-import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
@@ -242,13 +241,13 @@ public class HadoopDruidIndexerMapperTest
       }
 
       @Override
-      public void write(DataOutput out) throws IOException
+      public void write(DataOutput out)
       {
 
       }
 
       @Override
-      public void readFields(DataInput in) throws IOException
+      public void readFields(DataInput in)
       {
 
       }
diff --git a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTask.java b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTask.java
index 4f90017..19a2568 100644
--- a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTask.java
+++ b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTask.java
@@ -233,7 +233,7 @@ public class AppenderatorDriverRealtimeIndexTask extends AbstractTask implements
   }
 
   @Override
-  public TaskStatus run(final TaskToolbox toolbox) throws Exception
+  public TaskStatus run(final TaskToolbox toolbox)
   {
     runThread = Thread.currentThread();
 
diff --git a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java
index 62c23e7..5b67c25 100644
--- a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java
+++ b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java
@@ -230,7 +230,7 @@ public class HadoopIndexTask extends HadoopTask implements ChatHandler
   }
 
   @Override
-  public TaskStatus run(TaskToolbox toolbox) throws Exception
+  public TaskStatus run(TaskToolbox toolbox)
   {
     try {
       taskConfig = toolbox.getConfig();
diff --git a/indexing-service/src/test/java/org/apache/druid/indexing/overlord/supervisor/SupervisorResourceTest.java b/indexing-service/src/test/java/org/apache/druid/indexing/overlord/supervisor/SupervisorResourceTest.java
index 522307e..3b31dec 100644
--- a/indexing-service/src/test/java/org/apache/druid/indexing/overlord/supervisor/SupervisorResourceTest.java
+++ b/indexing-service/src/test/java/org/apache/druid/indexing/overlord/supervisor/SupervisorResourceTest.java
@@ -741,7 +741,7 @@ public class SupervisorResourceTest extends EasyMockSupport
   }
 
   @Test
-  public void testSpecGetHistoryWithAuthFailure() throws Exception
+  public void testSpecGetHistoryWithAuthFailure()
   {
     List<VersionedSupervisorSpec> versions1 = ImmutableList.of(
         new VersionedSupervisorSpec(
diff --git a/processing/src/main/java/org/apache/druid/segment/data/GenericIndexed.java b/processing/src/main/java/org/apache/druid/segment/data/GenericIndexed.java
index 5091294..e44a200 100644
--- a/processing/src/main/java/org/apache/druid/segment/data/GenericIndexed.java
+++ b/processing/src/main/java/org/apache/druid/segment/data/GenericIndexed.java
@@ -468,7 +468,7 @@ public class GenericIndexed<T> implements CloseableIndexed<T>, Serializer
   }
 
   @Override
-  public void close() throws IOException
+  public void close()
   {
     // nothing to close
   }
diff --git a/processing/src/test/java/org/apache/druid/query/aggregation/first/StringFirstBufferAggregatorTest.java b/processing/src/test/java/org/apache/druid/query/aggregation/first/StringFirstBufferAggregatorTest.java
index 573d55a..7d3e056 100644
--- a/processing/src/test/java/org/apache/druid/query/aggregation/first/StringFirstBufferAggregatorTest.java
+++ b/processing/src/test/java/org/apache/druid/query/aggregation/first/StringFirstBufferAggregatorTest.java
@@ -45,7 +45,7 @@ public class StringFirstBufferAggregatorTest
   }
 
   @Test
-  public void testBufferAggregate() throws Exception
+  public void testBufferAggregate()
   {
 
     final long[] timestamps = {1526724600L, 1526724700L, 1526724800L, 1526725900L, 1526725000L};
@@ -89,7 +89,7 @@ public class StringFirstBufferAggregatorTest
   }
 
   @Test
-  public void testNullBufferAggregate() throws Exception
+  public void testNullBufferAggregate()
   {
 
     final long[] timestamps = {2222L, 1111L, 3333L, 4444L, 5555L};
diff --git a/processing/src/test/java/org/apache/druid/query/aggregation/last/StringLastBufferAggregatorTest.java b/processing/src/test/java/org/apache/druid/query/aggregation/last/StringLastBufferAggregatorTest.java
index e621a4e..c3de598 100644
--- a/processing/src/test/java/org/apache/druid/query/aggregation/last/StringLastBufferAggregatorTest.java
+++ b/processing/src/test/java/org/apache/druid/query/aggregation/last/StringLastBufferAggregatorTest.java
@@ -45,7 +45,7 @@ public class StringLastBufferAggregatorTest
   }
 
   @Test
-  public void testBufferAggregate() throws Exception
+  public void testBufferAggregate()
   {
 
     final long[] timestamps = {1526724600L, 1526724700L, 1526724800L, 1526725900L, 1526725000L};
@@ -89,7 +89,7 @@ public class StringLastBufferAggregatorTest
   }
 
   @Test
-  public void testNullBufferAggregate() throws Exception
+  public void testNullBufferAggregate()
   {
 
     final long[] timestamps = {1111L, 2222L, 6666L, 4444L, 5555L};
diff --git a/server/src/main/java/org/apache/druid/client/cache/CaffeineCache.java b/server/src/main/java/org/apache/druid/client/cache/CaffeineCache.java
index 6ab0eb4..b7a1ea8 100644
--- a/server/src/main/java/org/apache/druid/client/cache/CaffeineCache.java
+++ b/server/src/main/java/org/apache/druid/client/cache/CaffeineCache.java
@@ -34,7 +34,6 @@ import org.apache.druid.java.util.emitter.service.ServiceEmitter;
 import org.apache.druid.java.util.emitter.service.ServiceMetricEvent;
 import org.apache.druid.utils.JvmUtils;
 
-import java.io.IOException;
 import java.nio.ByteBuffer;
 import java.util.Map;
 import java.util.OptionalLong;
@@ -119,7 +118,7 @@ public class CaffeineCache implements org.apache.druid.client.cache.Cache
 
   @Override
   @LifecycleStop
-  public void close() throws IOException
+  public void close()
   {
     cache.cleanUp();
   }
diff --git a/server/src/main/java/org/apache/druid/client/cache/MapCache.java b/server/src/main/java/org/apache/druid/client/cache/MapCache.java
index c8cf0e9..6ea5901 100644
--- a/server/src/main/java/org/apache/druid/client/cache/MapCache.java
+++ b/server/src/main/java/org/apache/druid/client/cache/MapCache.java
@@ -23,7 +23,6 @@ import com.google.common.primitives.Ints;
 import org.apache.druid.java.util.common.lifecycle.LifecycleStop;
 import org.apache.druid.java.util.emitter.service.ServiceEmitter;
 
-import java.io.IOException;
 import java.nio.ByteBuffer;
 import java.util.ArrayList;
 import java.util.Collections;
@@ -148,7 +147,7 @@ public class MapCache implements Cache
 
   @Override
   @LifecycleStop
-  public void close() throws IOException
+  public void close()
   {
     baseMap.clear();
     byteCountingLRUMap.clear();
diff --git a/server/src/main/java/org/apache/druid/client/cache/MemcachedCache.java b/server/src/main/java/org/apache/druid/client/cache/MemcachedCache.java
index df318a0..c13ca54 100644
--- a/server/src/main/java/org/apache/druid/client/cache/MemcachedCache.java
+++ b/server/src/main/java/org/apache/druid/client/cache/MemcachedCache.java
@@ -598,7 +598,7 @@ public class MemcachedCache implements Cache
 
   @Override
   @LifecycleStop
-  public void close() throws IOException
+  public void close()
   {
     monitor.stop();
   }
diff --git a/server/src/main/java/org/apache/druid/curator/PotentiallyGzippedCompressionProvider.java b/server/src/main/java/org/apache/druid/curator/PotentiallyGzippedCompressionProvider.java
index 7acddc4..6f5b765 100644
--- a/server/src/main/java/org/apache/druid/curator/PotentiallyGzippedCompressionProvider.java
+++ b/server/src/main/java/org/apache/druid/curator/PotentiallyGzippedCompressionProvider.java
@@ -37,13 +37,13 @@ public class PotentiallyGzippedCompressionProvider implements CompressionProvide
   }
 
   @Override
-  public byte[] compress(String path, byte[] data) throws Exception
+  public byte[] compress(String path, byte[] data)
   {
     return compressOutput ? base.compress(path, data) : data;
   }
 
   @Override
-  public byte[] decompress(String path, byte[] data) throws Exception
+  public byte[] decompress(String path, byte[] data)
   {
     try {
       return base.decompress(path, data);
diff --git a/server/src/main/java/org/apache/druid/server/security/AllowOptionsResourceFilter.java b/server/src/main/java/org/apache/druid/server/security/AllowOptionsResourceFilter.java
index c47b220..46fe78a 100644
--- a/server/src/main/java/org/apache/druid/server/security/AllowOptionsResourceFilter.java
+++ b/server/src/main/java/org/apache/druid/server/security/AllowOptionsResourceFilter.java
@@ -42,7 +42,7 @@ public class AllowOptionsResourceFilter implements Filter
   }
 
   @Override
-  public void init(FilterConfig filterConfig) throws ServletException
+  public void init(FilterConfig filterConfig)
   {
 
   }
diff --git a/server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java b/server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java
index 6c5c5d4..2eac081 100644
--- a/server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java
+++ b/server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java
@@ -287,7 +287,7 @@ public class DataSchemaTest
   }
   
   @Test
-  public void testEmptyDatasource() throws Exception
+  public void testEmptyDatasource()
   {
     Map<String, Object> parser = jsonMapper.convertValue(
         new StringInputRowParser(
diff --git a/server/src/test/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorDriverTest.java b/server/src/test/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorDriverTest.java
index 3a491e9..9c3e9cc 100644
--- a/server/src/test/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorDriverTest.java
+++ b/server/src/test/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorDriverTest.java
@@ -100,7 +100,7 @@ public class StreamAppenderatorDriverTest extends EasyMockSupport
   private DataSegmentKiller dataSegmentKiller;
 
   @Before
-  public void setUp() throws Exception
+  public void setUp()
   {
     appenderatorTester = new AppenderatorTester(MAX_ROWS_IN_MEMORY);
     allocator = new TestSegmentAllocator(DATA_SOURCE, Granularities.HOUR);
diff --git a/server/src/test/java/org/apache/druid/segment/realtime/firehose/EventReceiverFirehoseIdleTest.java b/server/src/test/java/org/apache/druid/segment/realtime/firehose/EventReceiverFirehoseIdleTest.java
index b625433..97edb6a 100644
--- a/server/src/test/java/org/apache/druid/segment/realtime/firehose/EventReceiverFirehoseIdleTest.java
+++ b/server/src/test/java/org/apache/druid/segment/realtime/firehose/EventReceiverFirehoseIdleTest.java
@@ -55,7 +55,7 @@ public class EventReceiverFirehoseIdleTest
   private HttpServletRequest req;
 
   @Before
-  public void setUp() throws Exception
+  public void setUp()
   {
     req = EasyMock.createMock(HttpServletRequest.class);
     eventReceiverFirehoseFactory = new EventReceiverFirehoseFactory(
diff --git a/sql/src/main/java/org/apache/druid/sql/http/ResultFormat.java b/sql/src/main/java/org/apache/druid/sql/http/ResultFormat.java
index 2e95993..bb9979c 100644
--- a/sql/src/main/java/org/apache/druid/sql/http/ResultFormat.java
+++ b/sql/src/main/java/org/apache/druid/sql/http/ResultFormat.java
@@ -68,7 +68,7 @@ public enum ResultFormat
     }
 
     @Override
-    public Writer createFormatter(final OutputStream outputStream, final ObjectMapper jsonMapper) throws IOException
+    public Writer createFormatter(final OutputStream outputStream, final ObjectMapper jsonMapper)
     {
       return new CsvWriter(outputStream);
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org