You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jieshan Bean (JIRA)" <ji...@apache.org> on 2012/04/30 08:50:50 UTC
[jira] [Created] (HBASE-5900) HRegion#FIXED_OVERHEAD is
miscalculated in 94.
Jieshan Bean created HBASE-5900:
-----------------------------------
Summary: HRegion#FIXED_OVERHEAD is miscalculated in 94.
Key: HBASE-5900
URL: https://issues.apache.org/jira/browse/HBASE-5900
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.94.0
Reporter: Jieshan Bean
Assignee: Jieshan Bean
Fix For: 0.94.1
After apply the patch of HBASE-5611, and tested on a 32-bit machine. This problem was triggered.
Before this patch, TestHeapSize is passed by pure coincidence in 94.
{noformat}
public static final long FIXED_OVERHEAD = ClassSize.align(
ClassSize.OBJECT +
ClassSize.ARRAY +
30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
(6 * Bytes.SIZEOF_LONG) +
Bytes.SIZEOF_BOOLEAN);
{noformat}
Actually, there are 31 REFERENCEs and 5 LONGs in HRegion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5900) HRegion#FIXED_OVERHEAD is
miscalculated in 94.
Posted by "Jieshan Bean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5900:
--------------------------------
Status: Patch Available (was: Open)
> HRegion#FIXED_OVERHEAD is miscalculated in 94.
> ----------------------------------------------
>
> Key: HBASE-5900
> URL: https://issues.apache.org/jira/browse/HBASE-5900
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.1
>
> Attachments: HRegion-FIEED_OVERHEAD.patch
>
>
> After apply the patch of HBASE-5611, and tested on a 32-bit machine. This problem was triggered.
> Before this patch, TestHeapSize is passed by pure coincidence in 94.
> {noformat}
> public static final long FIXED_OVERHEAD = ClassSize.align(
> ClassSize.OBJECT +
> ClassSize.ARRAY +
> 30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
> (6 * Bytes.SIZEOF_LONG) +
> Bytes.SIZEOF_BOOLEAN);
> {noformat}
> Actually, there are 31 REFERENCEs and 5 LONGs in HRegion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5900) HRegion#FIXED_OVERHEAD is
miscalculated in 94.
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5900:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Fix included in the patch for HBASE-5611.
> HRegion#FIXED_OVERHEAD is miscalculated in 94.
> ----------------------------------------------
>
> Key: HBASE-5900
> URL: https://issues.apache.org/jira/browse/HBASE-5900
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.1
>
> Attachments: HRegion-FIEED_OVERHEAD.patch
>
>
> After apply the patch of HBASE-5611, and tested on a 32-bit machine. This problem was triggered.
> Before this patch, TestHeapSize is passed by pure coincidence in 94.
> {noformat}
> public static final long FIXED_OVERHEAD = ClassSize.align(
> ClassSize.OBJECT +
> ClassSize.ARRAY +
> 30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
> (6 * Bytes.SIZEOF_LONG) +
> Bytes.SIZEOF_BOOLEAN);
> {noformat}
> Actually, there are 31 REFERENCEs and 5 LONGs in HRegion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5900) HRegion#FIXED_OVERHEAD is
miscalculated in 94.
Posted by "Jieshan Bean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264693#comment-13264693 ]
Jieshan Bean commented on HBASE-5900:
-------------------------------------
Patch will be uploaded after full tests today.
> HRegion#FIXED_OVERHEAD is miscalculated in 94.
> ----------------------------------------------
>
> Key: HBASE-5900
> URL: https://issues.apache.org/jira/browse/HBASE-5900
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.1
>
>
> After apply the patch of HBASE-5611, and tested on a 32-bit machine. This problem was triggered.
> Before this patch, TestHeapSize is passed by pure coincidence in 94.
> {noformat}
> public static final long FIXED_OVERHEAD = ClassSize.align(
> ClassSize.OBJECT +
> ClassSize.ARRAY +
> 30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
> (6 * Bytes.SIZEOF_LONG) +
> Bytes.SIZEOF_BOOLEAN);
> {noformat}
> Actually, there are 31 REFERENCEs and 5 LONGs in HRegion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5900) HRegion#FIXED_OVERHEAD is
miscalculated in 94.
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264934#comment-13264934 ]
Zhihong Yu commented on HBASE-5900:
-----------------------------------
Please keep the original indentation so that it is easy to see the changes:
{code}
+
+ public static final long HREGION_CLASS_SIZE = ClassSize.OBJECT
+ + ClassSize.ARRAY + 31 * ClassSize.REFERENCE + Bytes.SIZEOF_INT
+ + (5 * Bytes.SIZEOF_LONG) + Bytes.SIZEOF_BOOLEAN;
- public static final long FIXED_OVERHEAD = ClassSize.align(
- ClassSize.OBJECT +
- ClassSize.ARRAY +
- 30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
- (6 * Bytes.SIZEOF_LONG) +
- Bytes.SIZEOF_BOOLEAN);
{code}
I ran TestHeapSize with the patch and it passed.
Let's keep the patch in minimal form with the fix to FIXED_OVERHEAD only.
> HRegion#FIXED_OVERHEAD is miscalculated in 94.
> ----------------------------------------------
>
> Key: HBASE-5900
> URL: https://issues.apache.org/jira/browse/HBASE-5900
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.1
>
> Attachments: HRegion-FIEED_OVERHEAD.patch
>
>
> After apply the patch of HBASE-5611, and tested on a 32-bit machine. This problem was triggered.
> Before this patch, TestHeapSize is passed by pure coincidence in 94.
> {noformat}
> public static final long FIXED_OVERHEAD = ClassSize.align(
> ClassSize.OBJECT +
> ClassSize.ARRAY +
> 30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
> (6 * Bytes.SIZEOF_LONG) +
> Bytes.SIZEOF_BOOLEAN);
> {noformat}
> Actually, there are 31 REFERENCEs and 5 LONGs in HRegion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5900) HRegion#FIXED_OVERHEAD is
miscalculated in 94.
Posted by "Jieshan Bean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5900:
--------------------------------
Attachment: HRegion-FIEED_OVERHEAD.patch
> HRegion#FIXED_OVERHEAD is miscalculated in 94.
> ----------------------------------------------
>
> Key: HBASE-5900
> URL: https://issues.apache.org/jira/browse/HBASE-5900
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.1
>
> Attachments: HRegion-FIEED_OVERHEAD.patch
>
>
> After apply the patch of HBASE-5611, and tested on a 32-bit machine. This problem was triggered.
> Before this patch, TestHeapSize is passed by pure coincidence in 94.
> {noformat}
> public static final long FIXED_OVERHEAD = ClassSize.align(
> ClassSize.OBJECT +
> ClassSize.ARRAY +
> 30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
> (6 * Bytes.SIZEOF_LONG) +
> Bytes.SIZEOF_BOOLEAN);
> {noformat}
> Actually, there are 31 REFERENCEs and 5 LONGs in HRegion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5900) HRegion#FIXED_OVERHEAD is
miscalculated in 94.
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5900:
------------------------------
Fix Version/s: (was: 0.94.1)
0.94.0
> HRegion#FIXED_OVERHEAD is miscalculated in 94.
> ----------------------------------------------
>
> Key: HBASE-5900
> URL: https://issues.apache.org/jira/browse/HBASE-5900
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0
>
> Attachments: HRegion-FIEED_OVERHEAD.patch
>
>
> After apply the patch of HBASE-5611, and tested on a 32-bit machine. This problem was triggered.
> Before this patch, TestHeapSize is passed by pure coincidence in 94.
> {noformat}
> public static final long FIXED_OVERHEAD = ClassSize.align(
> ClassSize.OBJECT +
> ClassSize.ARRAY +
> 30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
> (6 * Bytes.SIZEOF_LONG) +
> Bytes.SIZEOF_BOOLEAN);
> {noformat}
> Actually, there are 31 REFERENCEs and 5 LONGs in HRegion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5900) HRegion#FIXED_OVERHEAD is
miscalculated in 94.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264861#comment-13264861 ]
Hadoop QA commented on HBASE-5900:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525053/HRegion-FIEED_OVERHEAD.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1688//console
This message is automatically generated.
> HRegion#FIXED_OVERHEAD is miscalculated in 94.
> ----------------------------------------------
>
> Key: HBASE-5900
> URL: https://issues.apache.org/jira/browse/HBASE-5900
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.1
>
> Attachments: HRegion-FIEED_OVERHEAD.patch
>
>
> After apply the patch of HBASE-5611, and tested on a 32-bit machine. This problem was triggered.
> Before this patch, TestHeapSize is passed by pure coincidence in 94.
> {noformat}
> public static final long FIXED_OVERHEAD = ClassSize.align(
> ClassSize.OBJECT +
> ClassSize.ARRAY +
> 30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
> (6 * Bytes.SIZEOF_LONG) +
> Bytes.SIZEOF_BOOLEAN);
> {noformat}
> Actually, there are 31 REFERENCEs and 5 LONGs in HRegion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5900) HRegion#FIXED_OVERHEAD is
miscalculated in 94.
Posted by "Jieshan Bean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266309#comment-13266309 ]
Jieshan Bean commented on HBASE-5900:
-------------------------------------
TestChangingEncoding is added just for testing FIXED_OVERHEAD. And the size of FIXED_OVERHEAD before align is needed, that's why I introduced a new variable here.
I saw the new patch in HBASE-5611 had included this change. So this patch is not needed now.
Thank you, Ted.
> HRegion#FIXED_OVERHEAD is miscalculated in 94.
> ----------------------------------------------
>
> Key: HBASE-5900
> URL: https://issues.apache.org/jira/browse/HBASE-5900
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.1
>
> Attachments: HRegion-FIEED_OVERHEAD.patch
>
>
> After apply the patch of HBASE-5611, and tested on a 32-bit machine. This problem was triggered.
> Before this patch, TestHeapSize is passed by pure coincidence in 94.
> {noformat}
> public static final long FIXED_OVERHEAD = ClassSize.align(
> ClassSize.OBJECT +
> ClassSize.ARRAY +
> 30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
> (6 * Bytes.SIZEOF_LONG) +
> Bytes.SIZEOF_BOOLEAN);
> {noformat}
> Actually, there are 31 REFERENCEs and 5 LONGs in HRegion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira