You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/16 09:52:03 UTC
[GitHub] [skywalking] cngdkxw opened a new pull request #4526: Add spring
cloud feign 2.x plugin
cngdkxw opened a new pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526
- spring cloud feign 2.x plugin
- spring cloud feign 2.x plugin test scenario
- spring cloud feign 1.x plugin test scenario
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4526: Add spring cloud
feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#issuecomment-599506566
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=h1) Report
> Merging [#4526](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/164d34f7fa5aa388bd9b051cd6bf20b260a60d5a&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4526 +/- ##
=======================================
Coverage 25.55% 25.55%
=======================================
Files 1244 1244
Lines 28943 28943
Branches 3965 3965
=======================================
Hits 7396 7396
Misses 20866 20866
Partials 681 681
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=footer). Last update [164d34f...164d34f](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4526:
Add spring cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#discussion_r393430221
##########
File path: docs/en/setup/service-agent/java-agent/Supported-list.md
##########
@@ -17,7 +17,7 @@
* [Netty SocketIO](https://github.com/mrniko/netty-socketio) 1.x
* HTTP Client
* [Feign](https://github.com/OpenFeign/feign) 9.x
- * [Netflix Spring Cloud Feign](https://github.com/spring-cloud/spring-cloud-netflix/tree/master/spring-cloud-starter-feign) 1.1.x, 1.2.x, 1.3.x
+ * [Netflix Spring Cloud Feign](https://github.com/spring-cloud/spring-cloud-netflix/tree/master/spring-cloud-starter-feign) 1.1.x, 1.2.x, 1.3.x(Except 1.3.3), 1.4.x, 2.x
Review comment:
Just curious, what happens in 1.3.3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4526: Add spring
cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#issuecomment-599506566
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=h1) Report
> Merging [#4526](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/336e6506942d1c4efac00414f9a4aef274060c07&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4526 +/- ##
==========================================
- Coverage 25.56% 25.53% -0.03%
==========================================
Files 1244 1244
Lines 28951 28951
Branches 3968 3968
==========================================
- Hits 7400 7393 -7
- Misses 20867 20874 +7
Partials 684 684
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=footer). Last update [3941d15...3941d15](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4526: Add spring cloud
feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#issuecomment-599443269
Please consider to rebase your commits to one. There is a long change list now, but don't relate to the PR review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4526: Add spring
cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#issuecomment-599506566
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=h1) Report
> Merging [#4526](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8187ccd416c1e9da84f06e2cc7c939c54d84380?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4526 +/- ##
==========================================
+ Coverage 25.53% 25.56% +0.02%
==========================================
Files 1244 1244
Lines 28951 28951
Branches 3968 3968
==========================================
+ Hits 7393 7400 +7
+ Misses 20874 20867 -7
Partials 684 684
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=footer). Last update [c8187cc...11bb3e9](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4526:
Add spring cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#discussion_r394788338
##########
File path: apm-sniffer/apm-sdk-plugin/spring-plugins/spring-cloud/spring-cloud-feign-2.x-plugin/pom.xml
##########
@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.skywalking</groupId>
+ <artifactId>spring-cloud</artifactId>
+ <version>7.0.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>apm-spring-cloud-feign-2.x-plugin</artifactId>
+ <version>7.0.0-SNAPSHOT</version>
Review comment:
This is not right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4526: Add spring cloud
feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#issuecomment-600956849
Main branch version updated, please follow the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on a change in pull request #4526:
Add spring cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on a change in pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#discussion_r393611368
##########
File path: docs/en/setup/service-agent/java-agent/Supported-list.md
##########
@@ -17,7 +17,7 @@
* [Netty SocketIO](https://github.com/mrniko/netty-socketio) 1.x
* HTTP Client
* [Feign](https://github.com/OpenFeign/feign) 9.x
- * [Netflix Spring Cloud Feign](https://github.com/spring-cloud/spring-cloud-netflix/tree/master/spring-cloud-starter-feign) 1.1.x, 1.2.x, 1.3.x
+ * [Netflix Spring Cloud Feign](https://github.com/spring-cloud/spring-cloud-netflix/tree/master/spring-cloud-starter-feign) 1.1.x, 1.2.x, 1.3.x(Except 1.3.3), 1.4.x, 2.x
Review comment:
1.1.x needs springboot 1.3.x, 1.2+ needs springboot 1.5.x, 2.x needs springboot 2.x.
Can't download 1.3.3 dependency from maven repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4526: Add spring
cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#issuecomment-599506566
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3941d15`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4526 +/- ##
=========================================
Coverage ? 25.53%
=========================================
Files ? 1244
Lines ? 28951
Branches ? 3968
=========================================
Hits ? 7393
Misses ? 20874
Partials ? 684
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...strix/v1/HystrixCommandGetFallbackInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaHlzdHJpeC0xLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vaHlzdHJpeC92MS9IeXN0cml4Q29tbWFuZEdldEZhbGxiYWNrSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lugin/jdk/http/HttpClientParseHttpInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYm9vdHN0cmFwLXBsdWdpbnMvamRrLWh0dHAtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vamRrL2h0dHAvSHR0cENsaWVudFBhcnNlSHR0cEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../trace/component/command/InstanceResetCommand.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0luc3RhbmNlUmVzZXRDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...n/jdbc/JDBCPreparedStatementSetterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vamRiYy1jb21tb25zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vamRiYy9KREJDUHJlcGFyZWRTdGF0ZW1lbnRTZXR0ZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...skywalking/apm/agent/core/profile/ProfileTask.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...uteAndExecuteAsyncWithStatementArgInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vY2Fzc2FuZHJhLWphdmEtZHJpdmVyLTMueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jYXNzYW5kcmEvamF2YS9kcml2ZXIvdjMvU2Vzc2lvbk1hbmFnZXJFeGVjdXRlQW5kRXhlY3V0ZUFzeW5jV2l0aFN0YXRlbWVudEFyZ0ludGVyY2VwdG9yLmphdmE=) | `43.33% <0.00%> (ø)` | |
| [...king/oap/query/graphql/resolver/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL01ldGFkYXRhUXVlcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=footer). Last update [3941d15...3941d15](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4526:
Add spring cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#discussion_r393640884
##########
File path: docs/en/setup/service-agent/java-agent/Supported-list.md
##########
@@ -17,7 +17,7 @@
* [Netty SocketIO](https://github.com/mrniko/netty-socketio) 1.x
* HTTP Client
* [Feign](https://github.com/OpenFeign/feign) 9.x
- * [Netflix Spring Cloud Feign](https://github.com/spring-cloud/spring-cloud-netflix/tree/master/spring-cloud-starter-feign) 1.1.x, 1.2.x, 1.3.x
+ * [Netflix Spring Cloud Feign](https://github.com/spring-cloud/spring-cloud-netflix/tree/master/spring-cloud-starter-feign) 1.1.x, 1.2.x, 1.3.x(Except 1.3.3), 1.4.x, 2.x
Review comment:
If it can't download from the Maven central, we don't need to indicate this in the doc, because users can't use it too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4526: Add spring cloud
feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#issuecomment-600441624
We are working on 7.0.0 release, I will back to this after that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4526: Add spring
cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#issuecomment-599506566
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=h1) Report
> Merging [#4526](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d548ea183c86966bfc7841677fe443981a5d56be&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4526 +/- ##
=======================================
Coverage 25.52% 25.52%
=======================================
Files 1244 1244
Lines 28943 28943
Branches 3965 3965
=======================================
Hits 7389 7389
Misses 20873 20873
Partials 681 681
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=footer). Last update [d548ea1...d548ea1](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4526: Add spring cloud
feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4526:
Add spring cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#discussion_r392898260
##########
File path: .github/workflows/plugins-test.yaml
##########
@@ -28,6 +28,39 @@ on:
- '.github/workflows/plugins-test.yaml'
jobs:
+ SpringCloud_Feign:
Review comment:
Why do you add a new group?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4526:
Add spring cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#discussion_r393431602
##########
File path: apm-sniffer/apm-sdk-plugin/spring-plugins/spring-cloud/netflix-plugins/spring-cloud-feign-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/string/cloud/netflix/feign/v2/define/LoadBalancerFeignClientInstrumentation.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.string.cloud.netflix.feign.v2.define;
+
+import net.bytebuddy.description.method.MethodDescription;
+import net.bytebuddy.matcher.ElementMatcher;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.ConstructorInterceptPoint;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.InstanceMethodsInterceptPoint;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.ClassInstanceMethodsEnhancePluginDefine;
+import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
+
+import static net.bytebuddy.matcher.ElementMatchers.named;
+import static org.apache.skywalking.apm.agent.core.plugin.match.NameMatch.byName;
+
+public class LoadBalancerFeignClientInstrumentation extends ClassInstanceMethodsEnhancePluginDefine {
+
+ public static final String ENHANCE_CLASS = "org.springframework.cloud.openfeign.ribbon.LoadBalancerFeignClient";
Review comment:
According to this, feign is not a netflix component anymore. You should move it to the `spring-cloud` folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4526:
Add spring cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#discussion_r393432480
##########
File path: docs/en/setup/service-agent/java-agent/Supported-list.md
##########
@@ -17,7 +17,7 @@
* [Netty SocketIO](https://github.com/mrniko/netty-socketio) 1.x
* HTTP Client
* [Feign](https://github.com/OpenFeign/feign) 9.x
- * [Netflix Spring Cloud Feign](https://github.com/spring-cloud/spring-cloud-netflix/tree/master/spring-cloud-starter-feign) 1.1.x, 1.2.x, 1.3.x
+ * [Netflix Spring Cloud Feign](https://github.com/spring-cloud/spring-cloud-netflix/tree/master/spring-cloud-starter-feign) 1.1.x, 1.2.x, 1.3.x(Except 1.3.3), 1.4.x, 2.x
Review comment:
Also here, 2.x should not belong to Netflix right? The old link is not working anymore. Please fix this by the current one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4526: Add spring
cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#issuecomment-599506566
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=h1) Report
> Merging [#4526](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8187ccd416c1e9da84f06e2cc7c939c54d84380?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4526 +/- ##
==========================================
+ Coverage 25.53% 25.56% +0.02%
==========================================
Files 1244 1244
Lines 28951 28951
Branches 3968 3968
==========================================
+ Hits 7393 7400 +7
+ Misses 20874 20867 -7
Partials 684 684
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4526/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=footer). Last update [c8187cc...11bb3e9](https://codecov.io/gh/apache/skywalking/pull/4526?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4526:
Add spring cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#discussion_r394788157
##########
File path: apm-sniffer/apm-sdk-plugin/spring-plugins/spring-cloud/spring-cloud-feign-2.x-plugin/pom.xml
##########
@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.skywalking</groupId>
+ <artifactId>spring-cloud</artifactId>
+ <version>7.0.0-SNAPSHOT</version>
Review comment:
This version is not right. Please fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on a change in pull request #4526:
Add spring cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on a change in pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#discussion_r393001147
##########
File path: .github/workflows/plugins-test.yaml
##########
@@ -28,6 +28,39 @@ on:
- '.github/workflows/plugins-test.yaml'
jobs:
+ SpringCloud_Feign:
Review comment:
Now, combined to Feign_Canal_Armeria
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on a change in pull request #4526:
Add spring cloud feign 2.x plugin
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on a change in pull request #4526: Add spring cloud feign 2.x plugin
URL: https://github.com/apache/skywalking/pull/4526#discussion_r393611368
##########
File path: docs/en/setup/service-agent/java-agent/Supported-list.md
##########
@@ -17,7 +17,7 @@
* [Netty SocketIO](https://github.com/mrniko/netty-socketio) 1.x
* HTTP Client
* [Feign](https://github.com/OpenFeign/feign) 9.x
- * [Netflix Spring Cloud Feign](https://github.com/spring-cloud/spring-cloud-netflix/tree/master/spring-cloud-starter-feign) 1.1.x, 1.2.x, 1.3.x
+ * [Netflix Spring Cloud Feign](https://github.com/spring-cloud/spring-cloud-netflix/tree/master/spring-cloud-starter-feign) 1.1.x, 1.2.x, 1.3.x(Except 1.3.3), 1.4.x, 2.x
Review comment:
1.1.x needs springboot 1.3.x, 1.2+ needs springboot 1.5.x, 2.x needs springboot 2.x.
Can't download 1.3.3 dependency in maven repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services