You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (JIRA)" <de...@db.apache.org> on 2006/04/26 15:53:03 UTC
[jira] Created: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
--------------------------------------------------------------------------------
Key: DERBY-1253
URL: http://issues.apache.org/jira/browse/DERBY-1253
Project: Derby
Type: Improvement
Components: JDBC
Versions: 10.2.0.0
Reporter: Rick Hillegas
Fix For: 10.2.0.0
The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=comments#action_12377482 ]
Rick Hillegas commented on DERBY-1253:
--------------------------------------
Committed derby-1253.v1.diff at subversion revision 399072. I made the following changes to the patch:
1) Commented out the Blob/Clob exclusions because Lance has said that these methods are mandatory
2) Added Connection.createStruct() and createArray() to the exclusions list since Kristian has filled these in now
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_verifier.diff, bug1253_verifier2.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Rick Hillegas updated DERBY-1253:
---------------------------------
Urgency: Normal
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Fix For: 10.2.0.0
>
> Attachments: bug1253_forwarding.diff, bug1253_vanishedMethods.diff, bug1253_verifier.diff, bug1253_verifier2.diff, bug1253_verifier3_complianceChapter.diff, bug1253_verifier4_networkResultSet.diff, bug1253_wireIn.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Missing JDBC3 methods, was: [jira] Updated: (DERBY-1253) Verify
that we don't raise SQLFeatureNotSupportedException for mandatory methods
Posted by "Lance J. Andersen" <La...@Sun.COM>.
Hi Rick,
named parameters are optional WRT CallableStatements but they need to
throw SQLFeatureNotSupportedException.
This is also clarified in the JDBC 4 spec compliance chapter
Rick Hillegas wrote:
> Hi Lance,
>
> Here's another gap between Derby's JDBC3 implementation and a
> reasonable interpretation of the spec: Currently, Derby supports
> CallableStatement methods of the form:
>
> getXXX( int paramNumber) and
> setXXX( int paramNumber, FOO paramValue )
>
> but Derby does not implement the corresponding CallableStatement
> methods (they throw "Not implemented" exceptions):
>
> getXXX( String paramName) and
> setXXX( String paramName, FOO paramValue )
>
> Is this asymmetry OK or do you think that methods in the second block
> are mandatory when the corresponding methods in the first block work?
>
> Thanks,
> -Rick
>
>
> Lance J. Andersen wrote:
>
>> Hi Dyre,
>>
>> yes that is correct, if you are supporting those data types it is
>> expected that the required methods are there in order to provide
>> developers with a consistent set of methods. It does not make sense
>> to just pick and choose especially seeing these data types have been
>> around in JDBC for quite some time now. Lack of support will make it
>> much more difficult for users to migrate from other backends which
>> support those data types to Derby.
>>
>> Dyre.Tjeldvoll@Sun.COM wrote:
>>
>>> "Lance J. Andersen" <La...@Sun.COM> writes:
>>>
>>>
>>>
>>>> If you support a data type such as Blob/Clob, you must implement all
>>>> methods on the interface, not pick and choose.
>>>>
>>>> If your backend does not support the data type, then all methods
>>>> should throw SQLFeatureNotSupportedException.
>>>>
>>>> This was a problem in the earlier JDBC specs as it did not clarify
>>>> which methods were required and which were not.
>>>>
>>>
>>> Hi Lance, thanks for the clarification.
>>> Currently we are missing:
>>>
>>> Blob.getBinaryStream(long,long)
>>> Blob.setBinaryStream(long)
>>> Blob.setBytes(long, byte[])
>>> Blob.setBytes(long, byte[], int, int)
>>> Blob.truncate(long)
>>> Blob.free() {DERBY-1145}
>>>
>>> Clob.getCharacterStream(long,long) Clob.setAsciiStream(long)
>>> Clob.setCharacterStream(long)
>>> Clob.setString(long, String)
>>> Clob.setString(long, String, int, int)
>>> Clob.truncate(long)
>>> Clob.free() {DERBY-1145}
>>>
>>>
>>> I assume that this means that we also need to implement:
>>>
>>> Connection.create[BC]lob()
>>> PreparedStatement.set[BC]lob()
>>> CallableStatement.set[BC]lob() (except named parameter variants)
>>> CallableStatement.get[BC]lob() (except named parameter variants) ?
>>>
>>> If so; there is indeed much work that needs to be done before Derby
>>> can claim to support Blob/Clob in Jdbc4 :(
>>>
>>>
>>>
>
Missing JDBC3 methods, was: [jira] Updated: (DERBY-1253) Verify that
we don't raise SQLFeatureNotSupportedException for mandatory methods
Posted by Rick Hillegas <Ri...@Sun.COM>.
Hi Lance,
Here's another gap between Derby's JDBC3 implementation and a reasonable
interpretation of the spec: Currently, Derby supports CallableStatement
methods of the form:
getXXX( int paramNumber) and
setXXX( int paramNumber, FOO paramValue )
but Derby does not implement the corresponding CallableStatement methods
(they throw "Not implemented" exceptions):
getXXX( String paramName) and
setXXX( String paramName, FOO paramValue )
Is this asymmetry OK or do you think that methods in the second block
are mandatory when the corresponding methods in the first block work?
Thanks,
-Rick
Lance J. Andersen wrote:
> Hi Dyre,
>
> yes that is correct, if you are supporting those data types it is
> expected that the required methods are there in order to provide
> developers with a consistent set of methods. It does not make sense
> to just pick and choose especially seeing these data types have been
> around in JDBC for quite some time now. Lack of support will make it
> much more difficult for users to migrate from other backends which
> support those data types to Derby.
>
> Dyre.Tjeldvoll@Sun.COM wrote:
>
>>"Lance J. Andersen" <La...@Sun.COM> writes:
>>
>>
>>
>>>If you support a data type such as Blob/Clob, you must implement all
>>>methods on the interface, not pick and choose.
>>>
>>>If your backend does not support the data type, then all methods
>>>should throw SQLFeatureNotSupportedException.
>>>
>>>This was a problem in the earlier JDBC specs as it did not clarify
>>>which methods were required and which were not.
>>>
>>>
>>
>>Hi Lance, thanks for the clarification.
>>
>>Currently we are missing:
>>
>>Blob.getBinaryStream(long,long)
>>Blob.setBinaryStream(long)
>>Blob.setBytes(long, byte[])
>>Blob.setBytes(long, byte[], int, int)
>>Blob.truncate(long)
>>Blob.free() {DERBY-1145}
>>
>>Clob.getCharacterStream(long,long)
>>Clob.setAsciiStream(long)
>>Clob.setCharacterStream(long)
>>Clob.setString(long, String)
>>Clob.setString(long, String, int, int)
>>Clob.truncate(long)
>>Clob.free() {DERBY-1145}
>>
>>
>>I assume that this means that we also need to implement:
>>
>>Connection.create[BC]lob()
>>PreparedStatement.set[BC]lob()
>>CallableStatement.set[BC]lob() (except named parameter variants)
>>CallableStatement.get[BC]lob() (except named parameter variants) ?
>>
>>If so; there is indeed much work that needs to be done before Derby
>>can claim to support Blob/Clob in Jdbc4 :(
>>
>>
>>
Re: [jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Lance J. Andersen" <La...@Sun.COM>.
Hi Dyre,
yes that is correct, if you are supporting those data types it is
expected that the required methods are there in order to provide
developers with a consistent set of methods. It does not make sense to
just pick and choose especially seeing these data types have been around
in JDBC for quite some time now. Lack of support will make it much more
difficult for users to migrate from other backends which support those
data types to Derby.
Dyre.Tjeldvoll@Sun.COM wrote:
> "Lance J. Andersen" <La...@Sun.COM> writes:
>
>
>> If you support a data type such as Blob/Clob, you must implement all
>> methods on the interface, not pick and choose.
>>
>> If your backend does not support the data type, then all methods
>> should throw SQLFeatureNotSupportedException.
>>
>> This was a problem in the earlier JDBC specs as it did not clarify
>> which methods were required and which were not.
>>
>
> Hi Lance, thanks for the clarification.
>
> Currently we are missing:
>
> Blob.getBinaryStream(long,long)
> Blob.setBinaryStream(long)
> Blob.setBytes(long, byte[])
> Blob.setBytes(long, byte[], int, int)
> Blob.truncate(long)
> Blob.free() {DERBY-1145}
>
> Clob.getCharacterStream(long,long)
> Clob.setAsciiStream(long)
> Clob.setCharacterStream(long)
> Clob.setString(long, String)
> Clob.setString(long, String, int, int)
> Clob.truncate(long)
> Clob.free() {DERBY-1145}
>
>
> I assume that this means that we also need to implement:
>
> Connection.create[BC]lob()
> PreparedStatement.set[BC]lob()
> CallableStatement.set[BC]lob() (except named parameter variants)
> CallableStatement.get[BC]lob() (except named parameter variants) ?
>
> If so; there is indeed much work that needs to be done before Derby
> can claim to support Blob/Clob in Jdbc4 :(
>
>
Re: [jira] Updated: (DERBY-1253) Verify that we don't raise SQLFeatureNotSupportedException
for mandatory methods
Posted by Daniel John Debrunner <dj...@apache.org>.
Dyre.Tjeldvoll@Sun.COM wrote:
> "Lance J. Andersen" <La...@Sun.COM> writes:
>
>
>>If you support a data type such as Blob/Clob, you must implement all
>>methods on the interface, not pick and choose.
>>
>>If your backend does not support the data type, then all methods
>>should throw SQLFeatureNotSupportedException.
>>
>>This was a problem in the earlier JDBC specs as it did not clarify
>>which methods were required and which were not.
>
>
> Hi Lance, thanks for the clarification.
>
> Currently we are missing:
>
> Blob.getBinaryStream(long,long)
> Blob.setBinaryStream(long)
> Blob.setBytes(long, byte[])
> Blob.setBytes(long, byte[], int, int)
> Blob.truncate(long)
> Blob.free() {DERBY-1145}
>
> Clob.getCharacterStream(long,long)
> Clob.setAsciiStream(long)
> Clob.setCharacterStream(long)
> Clob.setString(long, String)
> Clob.setString(long, String, int, int)
> Clob.truncate(long)
> Clob.free() {DERBY-1145}
>
>
> I assume that this means that we also need to implement:
>
> Connection.create[BC]lob()
> PreparedStatement.set[BC]lob()
> CallableStatement.set[BC]lob() (except named parameter variants)
> CallableStatement.get[BC]lob() (except named parameter variants) ?
>
> If so; there is indeed much work that needs to be done before Derby
> can claim to support Blob/Clob in Jdbc4 :(
And some thought needs to go into supporting these methods, see section
3.3 of JDBC 3.0. Do we implement updating the LOB updates the column or
updates a copy, does the client need to match embedded here?
Dan.
Re: [jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by Dy...@Sun.COM.
"Lance J. Andersen" <La...@Sun.COM> writes:
> If you support a data type such as Blob/Clob, you must implement all
> methods on the interface, not pick and choose.
>
> If your backend does not support the data type, then all methods
> should throw SQLFeatureNotSupportedException.
>
> This was a problem in the earlier JDBC specs as it did not clarify
> which methods were required and which were not.
Hi Lance, thanks for the clarification.
Currently we are missing:
Blob.getBinaryStream(long,long)
Blob.setBinaryStream(long)
Blob.setBytes(long, byte[])
Blob.setBytes(long, byte[], int, int)
Blob.truncate(long)
Blob.free() {DERBY-1145}
Clob.getCharacterStream(long,long)
Clob.setAsciiStream(long)
Clob.setCharacterStream(long)
Clob.setString(long, String)
Clob.setString(long, String, int, int)
Clob.truncate(long)
Clob.free() {DERBY-1145}
I assume that this means that we also need to implement:
Connection.create[BC]lob()
PreparedStatement.set[BC]lob()
CallableStatement.set[BC]lob() (except named parameter variants)
CallableStatement.get[BC]lob() (except named parameter variants) ?
If so; there is indeed much work that needs to be done before Derby
can claim to support Blob/Clob in Jdbc4 :(
--
dt
Re: [jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Lance J. Andersen" <La...@Sun.COM>.
If you support a data type such as Blob/Clob, you must implement all
methods on the interface, not pick and choose.
If your backend does not support the data type, then all methods should
throw SQLFeatureNotSupportedException.
This was a problem in the earlier JDBC specs as it did not clarify which
methods were required and which were not.
Dyre Tjeldvoll (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
>
> Dyre Tjeldvoll updated DERBY-1253:
> ----------------------------------
>
> Attachment: derby-1253.v1.diff
> derby-1253.v1.stat
>
> Attaching a patch that updates the exclude map with additional interfaces and methods.
> It still fails, but complains about fewer unsupported methods. I have run the test in embedded and DerbyNetClient, but I have not run any other tests.
>
> The indentation mode that I use doesn't seem to grok such complicated array initializations, so the indentation is a bit strange in some places. And I have not even tried to avoid lines longer than 80 chars here, since that would make the exclude map initialization unreadable...
>
> I'm a bit unsure about what to accept for Blob/Clob. All the methods in these interfaces are allowed to throw NotImplemented, but I'm wondering if the spec allows only some of them to be not implemented?
>
>
>
>> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
>> --------------------------------------------------------------------------------
>>
>> Key: DERBY-1253
>> URL: http://issues.apache.org/jira/browse/DERBY-1253
>> Project: Derby
>> Type: Improvement
>>
>
>
>> Components: JDBC
>> Versions: 10.2.0.0
>> Reporter: Rick Hillegas
>> Assignee: Dyre Tjeldvoll
>> Fix For: 10.2.0.0
>> Attachments: bug1253_verifier.diff, bug1253_verifier2.diff, derby-1253.v1.diff, derby-1253.v1.stat
>>
>> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
>>
>
>
[jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Dyre Tjeldvoll updated DERBY-1253:
----------------------------------
Attachment: derby-1253.v1.diff
derby-1253.v1.stat
Attaching a patch that updates the exclude map with additional interfaces and methods.
It still fails, but complains about fewer unsupported methods. I have run the test in embedded and DerbyNetClient, but I have not run any other tests.
The indentation mode that I use doesn't seem to grok such complicated array initializations, so the indentation is a bit strange in some places. And I have not even tried to avoid lines longer than 80 chars here, since that would make the exclude map initialization unreadable...
I'm a bit unsure about what to accept for Blob/Clob. All the methods in these interfaces are allowed to throw NotImplemented, but I'm wondering if the spec allows only some of them to be not implemented?
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_verifier.diff, bug1253_verifier2.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Rick Hillegas updated DERBY-1253:
---------------------------------
Attachment: bug1253_vanishedMethods.diff
Attaching bug1253_vanishedMethods.diff. This makes the UnsupportedVetter test smart enough to handle methods which change shape from one build of the jdk to the next. Previously, the test would raise an error and exit if an optional jdk method changed shape. Now we get more information when these errors occur. Touches the following file:
M java\testing\org\apache\derbyTesting\functionTests\tests\jdbc4\UnsupportedVetter.java
Committed at subversion revision 412220.
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_forwarding.diff, bug1253_vanishedMethods.diff, bug1253_verifier.diff, bug1253_verifier2.diff, bug1253_verifier3_complianceChapter.diff, bug1253_verifier4_networkResultSet.diff, bug1253_wireIn.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Dyre Tjeldvoll reassigned DERBY-1253:
-------------------------------------
Assign To: (was: Dyre Tjeldvoll)
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Fix For: 10.2.0.0
> Attachments: bug1253_forwarding.diff, bug1253_vanishedMethods.diff, bug1253_verifier.diff, bug1253_verifier2.diff, bug1253_verifier3_complianceChapter.diff, bug1253_verifier4_networkResultSet.diff, bug1253_wireIn.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Rick Hillegas updated DERBY-1253:
---------------------------------
Attachment: bug1253_verifier.diff
Attaching bug955_verifier.diff, which contains a junit test, UnsupportedVetter. This test lists out all of the methods which raise SQLFeatureNotSupportedException. The test also includes a table for adding descriptors of methods which we can ignore because the spec says they are allowed to raise this exception.
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Fix For: 10.2.0.0
> Attachments: bug1253_verifier.diff
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=comments#action_12377540 ]
Dyre Tjeldvoll commented on DERBY-1253:
---------------------------------------
Thanks for committing Rick.
> 1) Commented out the Blob/Clob exclusions because Lance has said that these methods are mandatory
Should we not comment out the Blob/Clob related methods in PreparedStatement and CallableStatement, as well? From the spec it appears that they too are mandatory if you support Blob/Clob.
I'm unsure about Connection.create[BC]lob, though. The spec draft marks them as optional, but does not have the same caveat which make the methods mandatory if you support the datatype.
2) Added Connection.createStruct() and createArray() to the exclusions list since Kristian has filled these in now
Not sure I understand the last comment. If those methods have been added, you would want to REMOVE them from the exclusion list, wouldn't you? Or do you mean that these methods now throw Unsupported, and did not do so before?
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_verifier.diff, bug1253_verifier2.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Rick Hillegas updated DERBY-1253:
---------------------------------
Attachment: bug1253_verifier4_networkResultSet.diff
Committed bug1253_verifier4_networkResultSet.diff at subversion revision 400172. This makes the following changes:
1) Changes the NotSupported exception raised by network ResultSets to be an UnimplementedFeature exception which we map to SQLFeatureNotSupportedException under JDBC4. This in turn lets UnsupportedVetter see which methods aren't supported by network ResultSets.
2) Made a change to Sed so that we can eliminate another jdk16-specific canon (the one for the updatableResultSet test).
3) Expanded the table of excluded methods in UnsupportedVetter. This table now contains additional methods just made optional by the JDBC4 expert group. Those additional methods are documented in DERBY-1281.
It would be helpful if someone could run updatableResultSet on the J2ME vm to verify whether we need canon changes for that platform.
Derbyall passes on 1.4 modulo wisconsin diffs. I also verified the updatableResultSet test on jdk13 and jdk16 under the embedded and DerbyNetClient frameworks. Touches the following files:
M java/testing/org/apache/derbyTesting/functionTests/harness/Sed.java
M java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/jdk16/updatableResultSet.out
M java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/jdk14/updatableResultSet.out
M java/client/org/apache/derby/client/am/ResultSet.java
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/UnsupportedVetter.java
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_verifier.diff, bug1253_verifier2.diff, bug1253_verifier3_complianceChapter.diff, bug1253_verifier4_networkResultSet.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Dyre Tjeldvoll reassigned DERBY-1253:
-------------------------------------
Assign To: Dyre Tjeldvoll
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_verifier.diff
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Rick Hillegas updated DERBY-1253:
---------------------------------
Attachment: bug1253_wireIn.diff
Attaching bug1253_wireIn.diff. This adds the UnsupportedVetter test to the jdbc4 test suite. Committed at subversion revision 410694. Touches the following files:
M java\testing\org\apache\derbyTesting\functionTests\tests\jdbc4\UnsupportedVetter.java
M java\testing\org\apache\derbyTesting\functionTests\suites\jdbc40.runall
Added special markers to the mandatory LOB-supporting methods which Derby does not implement. See the class header of UnsupportedVetter for instructions on how to vet strictly and disclose this compliance gap.
At this point, this test will track additional flexing of the JDBC4 spec.
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_forwarding.diff, bug1253_verifier.diff, bug1253_verifier2.diff, bug1253_verifier3_complianceChapter.diff, bug1253_verifier4_networkResultSet.diff, bug1253_wireIn.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Lance J. Andersen" <La...@Sun.COM>.
Daniel John Debrunner (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DERBY-1253?page=comments#action_12376549 ]
>
> Daniel John Debrunner commented on DERBY-1253:
> ----------------------------------------------
>
> Is this mandatory/optional method scheme discussed in the JDBC 4.0 spec?
oh this is in the compliance chapter and the compliance chapter and the
javadocs have been updated to reflect what is mandatory and what is
optional.
makes it easier for everyone as it was a bit of a guessing game before...
> In my latest copy of the spec and java doc I cannot find any reference to it. I do see the concept of "Required Interface" but that says any unimplemented methods can throw SQLFeatureNotSupportedException.
>
>
>> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
>> --------------------------------------------------------------------------------
>>
>> Key: DERBY-1253
>> URL: http://issues.apache.org/jira/browse/DERBY-1253
>> Project: Derby
>> Type: Improvement
>>
>
>
>> Components: JDBC
>> Versions: 10.2.0.0
>> Reporter: Rick Hillegas
>> Assignee: Dyre Tjeldvoll
>> Fix For: 10.2.0.0
>> Attachments: bug1253_verifier.diff
>>
>> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
>>
>
>
Re: [jira] Commented: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Lance J. Andersen" <La...@Sun.COM>.
This is required.
Daniel John Debrunner (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DERBY-1253?page=comments#action_12376549 ]
>
> Daniel John Debrunner commented on DERBY-1253:
> ----------------------------------------------
>
> Is this mandatory/optional method scheme discussed in the JDBC 4.0 spec? In my latest copy of the spec and java doc I cannot find any reference to it. I do see the concept of "Required Interface" but that says any unimplemented methods can throw SQLFeatureNotSupportedException.
>
>
>> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
>> --------------------------------------------------------------------------------
>>
>> Key: DERBY-1253
>> URL: http://issues.apache.org/jira/browse/DERBY-1253
>> Project: Derby
>> Type: Improvement
>>
>
>
>> Components: JDBC
>> Versions: 10.2.0.0
>> Reporter: Rick Hillegas
>> Assignee: Dyre Tjeldvoll
>> Fix For: 10.2.0.0
>> Attachments: bug1253_verifier.diff
>>
>> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
>>
>
>
[jira] Commented: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=comments#action_12376549 ]
Daniel John Debrunner commented on DERBY-1253:
----------------------------------------------
Is this mandatory/optional method scheme discussed in the JDBC 4.0 spec? In my latest copy of the spec and java doc I cannot find any reference to it. I do see the concept of "Required Interface" but that says any unimplemented methods can throw SQLFeatureNotSupportedException.
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_verifier.diff
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Rick Hillegas updated DERBY-1253:
---------------------------------
Attachment: bug1253_forwarding.diff
Committed bug1253_forwarding.diff at subversion revision 408772. This patch forwards some miscellaneous JDBC4 calls to competent objects. These missing implementations were disclosed by UnsupportedVetter. Touches the following files:
M java\engine\org\apache\derby\jdbc\EmbeddedXADataSource40.java
M java\engine\org\apache\derby\jdbc\EmbeddedConnectionPoolDataSource40.java
M java\client\org\apache\derby\client\am\LogicalConnection40.java
The JDBC4 tests runs cleanly.
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_forwarding.diff, bug1253_verifier.diff, bug1253_verifier2.diff, bug1253_verifier3_complianceChapter.diff, bug1253_verifier4_networkResultSet.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Rick Hillegas updated DERBY-1253:
---------------------------------
Attachment: bug1253_verifier2.diff
Committed bug1253_verifier2.diff at subversion revision 397926. This just exposes this test (which I have not wired into any suite yet). I have commented out the close on the connection because this was raising an Invalid Transaction State exception on linux. I don't see this problem on xp/cywgin. I will log a bug for tracking this discrepancy.
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_verifier.diff, bug1253_verifier2.diff
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Rick Hillegas updated DERBY-1253:
---------------------------------
Attachment: bug1253_verifier3_complianceChapter.diff
Commmitted bug1253_verifier3_complianceChapter.diff at subversion revision 399482. This modifies the table of excludable (optional) methods, based on my review of the revised, draft JDBC4 Compliance chapter.
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_verifier.diff, bug1253_verifier2.diff, bug1253_verifier3_complianceChapter.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Rick Hillegas closed DERBY-1253.
--------------------------------
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.2.1.0
> Reporter: Rick Hillegas
> Fix For: 10.2.1.0
>
> Attachments: bug1253_forwarding.diff, bug1253_vanishedMethods.diff, bug1253_verifier.diff, bug1253_verifier2.diff, bug1253_verifier3_complianceChapter.diff, bug1253_verifier4_networkResultSet.diff, bug1253_wireIn.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=all ]
Rick Hillegas resolved DERBY-1253.
----------------------------------
Resolution: Fixed
We have finished the work for this issue. If there are bugs, they should be logged as separate JIRAs at this point.
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.2.1.0
> Reporter: Rick Hillegas
> Fix For: 10.2.1.0
>
> Attachments: bug1253_forwarding.diff, bug1253_vanishedMethods.diff, bug1253_verifier.diff, bug1253_verifier2.diff, bug1253_verifier3_complianceChapter.diff, bug1253_verifier4_networkResultSet.diff, bug1253_wireIn.diff, derby-1253.v1.diff, derby-1253.v1.stat
>
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1253) Verify that we don't raise
SQLFeatureNotSupportedException for mandatory methods
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1253?page=comments#action_12376584 ]
Rick Hillegas commented on DERBY-1253:
--------------------------------------
Lance has clarified that this is documented in the Compliance chapter and in the javadoc.
> Verify that we don't raise SQLFeatureNotSupportedException for mandatory methods
> --------------------------------------------------------------------------------
>
> Key: DERBY-1253
> URL: http://issues.apache.org/jira/browse/DERBY-1253
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: bug1253_verifier.diff
>
> The jdk16 javadoc marks optional methods as being able to raise SQLFeatureNotSupportedException. Make sure that we don't raise this exception for mandatory methods--unless we clearly understand why we have chosen to deviate from the JDBC spec.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira