[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #858: MINIFICPP-1300 - Decouple ControllerServiceProvider ownerships from use-only components

[GitBox <gi...@apache.org>]

adamdebreceni commented on a change in pull request #858:
URL: https://github.com/apache/nifi-minifi-cpp/pull/858#discussion_r468546189



##########
File path: extensions/coap/protocols/CoapC2Protocol.cpp
##########
@@ -39,7 +39,7 @@ CoapProtocol::CoapProtocol(const std::string &name, const utils::Identifier &uui
 
 CoapProtocol::~CoapProtocol() = default;
 
-void CoapProtocol::initialize(const std::shared_ptr<core::controller::ControllerServiceProvider> &controller, const std::shared_ptr<Configure> &configure) {
+void CoapProtocol::initialize(core::controller::ControllerServiceProvider* controller, const std::shared_ptr<Configure> &configure) {

Review comment:
       if we take a pointer, it's our responsibility to null-check it, we assume here that it is non-null, we should either handle nullptr or take a reference, (in theory we could use a gls::non_null<...>, but references are more succinctly command validity)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org