You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ti...@apache.org on 2013/08/08 22:50:28 UTC
git commit: [CB-4036] - fixed up some small errors
Updated Branches:
refs/heads/engineCheck e9f12a58c -> 2db5b2015
[CB-4036] - fixed up some small errors
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugman/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugman/commit/2db5b201
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugman/tree/2db5b201
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugman/diff/2db5b201
Branch: refs/heads/engineCheck
Commit: 2db5b2015bf0c4b5a388d6175238d86c8cb2137a
Parents: e9f12a5
Author: Tim Kim <ti...@adobe.com>
Authored: Thu Aug 8 13:50:18 2013 -0700
Committer: Tim Kim <ti...@adobe.com>
Committed: Thu Aug 8 13:50:18 2013 -0700
----------------------------------------------------------------------
src/install.js | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/2db5b201/src/install.js
----------------------------------------------------------------------
diff --git a/src/install.js b/src/install.js
index fee217e..accc25a 100644
--- a/src/install.js
+++ b/src/install.js
@@ -83,9 +83,9 @@ function callEngineScripts(engines) {
var engineScriptVersion;
engines.forEach(function(engine){
- if(fs.exists(engine.scriptTarget)){
+ if(fs.existsSync(engine.scriptTarget)){
fs.chmodSync(engine.scriptTarget, '755');
- engineScript = shell.exec(versionPath, {silent: true});
+ engineScript = shell.exec(engine.scriptTarget, {silent: true});
if (engineScript.code === 0) {
engineScriptVersion = engineScript.output.trim();
@@ -103,7 +103,6 @@ function callEngineScripts(engines) {
require('../plugman').emit('log', 'Cordova project '+ engine.scriptTarget +' not detected (lacks a '+ engine.scriptTarget +' script), continuing.');
}
engine.currentVersion = engineScriptVersion;
-
});
return engines;
@@ -121,7 +120,7 @@ function getEngines(pluginElement, platform, project_dir){
// this may need some changes - what to do for default platforms - why need to specify platforms?
if(engine.attrib["platform"] === platform || engine.attrib["platform"] === '*'){
if(defaultEngines[engine.attrib["name"]]){
- defaultEngines[engine.attrib["name"]].minVersion = defaultEngines[engine.attrib["version"]];
+ defaultEngines[engine.attrib["name"]].minVersion = engine.attrib["version"];
defaultEngines[engine.attrib["name"]].scriptTarget = path.join(project_dir, defaultEngines[engine.attrib["name"]].scriptTarget);
uncheckedEngines.push(defaultEngines[engine.attrib["name"]]);
}else{