You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Dan Tran (JIRA)" <ji...@codehaus.org> on 2006/01/13 07:42:02 UTC
[jira] Created: (MASSEMBLY-61) Should remove/deprecate
AbstractUnpackAssembly's classifier field
Should remove/deprecate AbstractUnpackAssembly's classifier field
-----------------------------------------------------------------
Key: MASSEMBLY-61
URL: http://jira.codehaus.org/browse/MASSEMBLY-61
Project: Maven 2.x Assembly Plugin
Type: Improvement
Versions: 2.1
Environment: xp
Reporter: Dan Tran
Fix For: 2.1
Before the changes of supporting multiple descriptors, we use classifier to allow user to override the default
descriptor's id as classifier. Now it is no longer valid unless we introduce multitple classifier fields with match of number of descriptors
WDYT?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MASSEMBLY-61) Should remove/deprecate
AbstractUnpackAssembly's classifier field
Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-61?page=comments#action_56429 ]
Dan Tran commented on MASSEMBLY-61:
-----------------------------------
why dont we just remove it completely? What is the point of giving user 2 options to name the classifier in the descriptor?
1. descriptor id
2. classifier
isn't that redundant?
> Should remove/deprecate AbstractUnpackAssembly's classifier field
> -----------------------------------------------------------------
>
> Key: MASSEMBLY-61
> URL: http://jira.codehaus.org/browse/MASSEMBLY-61
> Project: Maven 2.x Assembly Plugin
> Type: Improvement
> Versions: 2.1
> Environment: xp
> Reporter: Dan Tran
> Fix For: 2.1
>
>
> Before the changes of supporting multiple descriptors, we use classifier to allow user to override the default
> descriptor's id as classifier. Now it is no longer valid unless we introduce multitple classifier fields with match of number of descriptors
> WDYT?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MASSEMBLY-61) Should remove/deprecate
AbstractUnpackAssembly's classifier field
Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-61?page=all ]
Dan Tran closed MASSEMBLY-61:
-----------------------------
Assign To: Dan Tran
Resolution: Fixed
AbstractUnpackingMojo's classifer field is now deprecated.
> Should remove/deprecate AbstractUnpackAssembly's classifier field
> -----------------------------------------------------------------
>
> Key: MASSEMBLY-61
> URL: http://jira.codehaus.org/browse/MASSEMBLY-61
> Project: Maven 2.x Assembly Plugin
> Type: Improvement
> Versions: 2.1
> Environment: xp
> Reporter: Dan Tran
> Assignee: Dan Tran
> Fix For: 2.1
>
>
> Before the changes of supporting multiple descriptors, we use classifier to allow user to override the default
> descriptor's id as classifier. Now it is no longer valid unless we introduce multitple classifier fields with match of number of descriptors
> WDYT?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MASSEMBLY-61) Should remove/deprecate
AbstractUnpackAssembly's classifier field
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-61?page=comments#action_56514 ]
Brett Porter commented on MASSEMBLY-61:
---------------------------------------
that sounds fine. Maybe we should rename it to be more explicit.
> Should remove/deprecate AbstractUnpackAssembly's classifier field
> -----------------------------------------------------------------
>
> Key: MASSEMBLY-61
> URL: http://jira.codehaus.org/browse/MASSEMBLY-61
> Project: Maven 2.x Assembly Plugin
> Type: Improvement
> Versions: 2.1
> Environment: xp
> Reporter: Dan Tran
> Fix For: 2.1
>
>
> Before the changes of supporting multiple descriptors, we use classifier to allow user to override the default
> descriptor's id as classifier. Now it is no longer valid unless we introduce multitple classifier fields with match of number of descriptors
> WDYT?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MASSEMBLY-61) Should remove/deprecate
AbstractUnpackAssembly's classifier field
Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-61?page=comments#action_56532 ]
Dan Tran commented on MASSEMBLY-61:
-----------------------------------
Conversions with Brett and Carlo on IRC
<carlos> dantran: we can't remove anything, remember backwards compatability
<brett> @deprecate
<dantran> so move it to descritor also break thing
<brett> no move, add and deprecate
<dantran> i propose that deprecate it first then remove it later
<dantran> oh, i thought you want introduce a classifer field in the descriptor
<dantran> brett <---- agreed. Let's make it part of the descriptor.
<dantran> it = classifier?
<dantran> or make the descriptor as classifier
<dantran> or make the descriptorID as classifier
* brett remembers the original purpose
<brett> the classifier was to override the one from the built-in descriptor
<brett> they can define their own
<brett> so I say just deprecate the one in the plugin, nothing else needed
> Should remove/deprecate AbstractUnpackAssembly's classifier field
> -----------------------------------------------------------------
>
> Key: MASSEMBLY-61
> URL: http://jira.codehaus.org/browse/MASSEMBLY-61
> Project: Maven 2.x Assembly Plugin
> Type: Improvement
> Versions: 2.1
> Environment: xp
> Reporter: Dan Tran
> Fix For: 2.1
>
>
> Before the changes of supporting multiple descriptors, we use classifier to allow user to override the default
> descriptor's id as classifier. Now it is no longer valid unless we introduce multitple classifier fields with match of number of descriptors
> WDYT?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MASSEMBLY-61) Should remove/deprecate
AbstractUnpackAssembly's classifier field
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-61?page=comments#action_56417 ]
Brett Porter commented on MASSEMBLY-61:
---------------------------------------
agreed. Let's make it part of the descriptor.
> Should remove/deprecate AbstractUnpackAssembly's classifier field
> -----------------------------------------------------------------
>
> Key: MASSEMBLY-61
> URL: http://jira.codehaus.org/browse/MASSEMBLY-61
> Project: Maven 2.x Assembly Plugin
> Type: Improvement
> Versions: 2.1
> Environment: xp
> Reporter: Dan Tran
> Fix For: 2.1
>
>
> Before the changes of supporting multiple descriptors, we use classifier to allow user to override the default
> descriptor's id as classifier. Now it is no longer valid unless we introduce multitple classifier fields with match of number of descriptors
> WDYT?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org