You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "git-init-priyanshu (via GitHub)" <gi...@apache.org> on 2023/06/22 05:58:42 UTC
[GitHub] [superset] git-init-priyanshu opened a new issue, #24478: Transition of Navbar from dark to light is not smooth
git-init-priyanshu opened a new issue, #24478:
URL: https://github.com/apache/superset/issues/24478
## Screenshot
https://github.com/apache/superset/assets/110045644/f8c985f5-30a9-4ac3-a854-2f77c7930a97
## Description
While scrolling the transition of Navbar from dark to light or vice-versa is not smooth.
## Design input
May I submit a pull request to address this issue? I just added a transition of 0.5 sec to the navbar and it looks much better now.
https://github.com/apache/superset/assets/110045644/377c11a7-a7f6-475f-8c6b-da4be1ba7380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Transition of Navbar from dark to light is not smooth [superset]
Posted by "git-init-priyanshu (via GitHub)" <gi...@apache.org>.
git-init-priyanshu commented on issue #24478:
URL: https://github.com/apache/superset/issues/24478#issuecomment-1977908082
> Oops, this issue never got closed with your PR. Thanks for that!
Haha, thanks for merging my first open-source PR. Now that I look at it, I realize it is not very impactful, but it was a good start, I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Transition of Navbar from dark to light is not smooth [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #24478: Transition of Navbar from dark to light is not smooth
URL: https://github.com/apache/superset/issues/24478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Transition of Navbar from dark to light is not smooth [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #24478:
URL: https://github.com/apache/superset/issues/24478#issuecomment-1977330658
Oops, this issue never got closed with your PR. Thanks for that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org