You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2020/12/14 08:36:12 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #184: Add faucet app
atoulme opened a new pull request #184:
URL: https://github.com/apache/incubator-tuweni/pull/184
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
## PR description
Adds an example faucet application to Apache Tuweni, built with Spring and github auth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #184: Add faucet app
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-tuweni/pull/184#issuecomment-745008571
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=h1) Report
> Merging [#184](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=desc) (7532a47) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/1f91a083dff2526edcb31df620bea927854ee550?el=desc) (1f91a08) will **decrease** coverage by `4.86%`.
> The diff coverage is `22.72%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #184 +/- ##
============================================
- Coverage 65.74% 60.87% -4.87%
+ Complexity 4173 3878 -295
============================================
Files 371 347 -24
Lines 19910 19570 -340
Branches 2590 2587 -3
============================================
- Hits 13090 11914 -1176
- Misses 5366 6317 +951
+ Partials 1454 1339 -115
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.87% <22.72%> (-0.14%)` | `0.00 <2.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/tuweni/jsonrpc/ClientRequestException.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9DbGllbnRSZXF1ZXN0RXhjZXB0aW9uLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `89.28% <0.00%> (-3.31%)` | `3.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `33.33% <21.95%> (-61.41%)` | `3.00 <1.00> (ø)` | |
| [...ain/java/org/apache/tuweni/units/ethereum/Wei.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-dW5pdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS91bml0cy9ldGhlcmV1bS9XZWkuamF2YQ==) | `68.00% <100.00%> (+1.33%)` | `10.00 <1.00> (+1.00)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [68 more](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=footer). Last update [1f91a08...c8c3a6b](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #184: Add faucet app
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-tuweni/pull/184#issuecomment-745008571
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=h1) Report
> Merging [#184](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=desc) (28fb7ca) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/1f91a083dff2526edcb31df620bea927854ee550?el=desc) (1f91a08) will **decrease** coverage by `4.85%`.
> The diff coverage is `22.72%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #184 +/- ##
============================================
- Coverage 65.74% 60.89% -4.86%
+ Complexity 4173 3878 -295
============================================
Files 371 347 -24
Lines 19910 19570 -340
Branches 2590 2587 -3
============================================
- Hits 13090 11917 -1173
- Misses 5366 6312 +946
+ Partials 1454 1341 -113
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.89% <22.72%> (-0.12%)` | `0.00 <2.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/tuweni/jsonrpc/ClientRequestException.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9DbGllbnRSZXF1ZXN0RXhjZXB0aW9uLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `89.28% <0.00%> (-3.31%)` | `3.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `33.33% <21.95%> (-61.41%)` | `3.00 <1.00> (ø)` | |
| [...ain/java/org/apache/tuweni/units/ethereum/Wei.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-dW5pdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS91bml0cy9ldGhlcmV1bS9XZWkuamF2YQ==) | `68.00% <100.00%> (+1.33%)` | `10.00 <1.00> (+1.00)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [67 more](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=footer). Last update [1f91a08...28fb7ca](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #184: Add faucet app
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-tuweni/pull/184#issuecomment-745008571
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=h1) Report
> Merging [#184](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=desc) (dde9c96) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/1f91a083dff2526edcb31df620bea927854ee550?el=desc) (1f91a08) will **decrease** coverage by `4.86%`.
> The diff coverage is `22.72%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #184 +/- ##
============================================
- Coverage 65.74% 60.87% -4.87%
+ Complexity 4173 3878 -295
============================================
Files 371 347 -24
Lines 19910 19570 -340
Branches 2590 2587 -3
============================================
- Hits 13090 11914 -1176
- Misses 5366 6315 +949
+ Partials 1454 1341 -113
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.87% <22.72%> (-0.14%)` | `0.00 <2.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/tuweni/jsonrpc/ClientRequestException.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9DbGllbnRSZXF1ZXN0RXhjZXB0aW9uLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `89.28% <0.00%> (-3.31%)` | `3.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `33.33% <21.95%> (-61.41%)` | `3.00 <1.00> (ø)` | |
| [...ain/java/org/apache/tuweni/units/ethereum/Wei.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-dW5pdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS91bml0cy9ldGhlcmV1bS9XZWkuamF2YQ==) | `68.00% <100.00%> (+1.33%)` | `10.00 <1.00> (+1.00)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [70 more](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=footer). Last update [1f91a08...28fb7ca](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #184: Add faucet app
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-tuweni/pull/184#issuecomment-745008571
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=h1) Report
> Merging [#184](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=desc) (dde9c96) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/1f91a083dff2526edcb31df620bea927854ee550?el=desc) (1f91a08) will **decrease** coverage by `4.86%`.
> The diff coverage is `22.72%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #184 +/- ##
============================================
- Coverage 65.74% 60.87% -4.87%
+ Complexity 4173 3878 -295
============================================
Files 371 347 -24
Lines 19910 19570 -340
Branches 2590 2587 -3
============================================
- Hits 13090 11914 -1176
- Misses 5366 6315 +949
+ Partials 1454 1341 -113
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.87% <22.72%> (-0.14%)` | `0.00 <2.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/tuweni/jsonrpc/ClientRequestException.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9DbGllbnRSZXF1ZXN0RXhjZXB0aW9uLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `89.28% <0.00%> (-3.31%)` | `3.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `33.33% <21.95%> (-61.41%)` | `3.00 <1.00> (ø)` | |
| [...ain/java/org/apache/tuweni/units/ethereum/Wei.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-dW5pdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS91bml0cy9ldGhlcmV1bS9XZWkuamF2YQ==) | `68.00% <100.00%> (+1.33%)` | `10.00 <1.00> (+1.00)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [70 more](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=footer). Last update [1f91a08...dde9c96](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #184: Add faucet app
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-tuweni/pull/184#issuecomment-745008571
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=h1) Report
> Merging [#184](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=desc) (c8c3a6b) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/1f91a083dff2526edcb31df620bea927854ee550?el=desc) (1f91a08) will **decrease** coverage by `4.86%`.
> The diff coverage is `22.72%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #184 +/- ##
============================================
- Coverage 65.74% 60.87% -4.87%
+ Complexity 4173 3878 -295
============================================
Files 371 347 -24
Lines 19910 19570 -340
Branches 2590 2587 -3
============================================
- Hits 13090 11914 -1176
- Misses 5366 6314 +948
+ Partials 1454 1342 -112
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.87% <22.72%> (-0.14%)` | `0.00 <2.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/tuweni/jsonrpc/ClientRequestException.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9DbGllbnRSZXF1ZXN0RXhjZXB0aW9uLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `89.28% <0.00%> (-3.31%)` | `3.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `33.33% <21.95%> (-61.41%)` | `3.00 <1.00> (ø)` | |
| [...ain/java/org/apache/tuweni/units/ethereum/Wei.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-dW5pdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS91bml0cy9ldGhlcmV1bS9XZWkuamF2YQ==) | `68.00% <100.00%> (+1.33%)` | `10.00 <1.00> (+1.00)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [69 more](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=footer). Last update [1f91a08...c8c3a6b](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #184: Add faucet app
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-tuweni/pull/184#issuecomment-745008571
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=h1) Report
> Merging [#184](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=desc) (28fb7ca) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/1f91a083dff2526edcb31df620bea927854ee550?el=desc) (1f91a08) will **decrease** coverage by `4.85%`.
> The diff coverage is `22.72%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #184 +/- ##
============================================
- Coverage 65.74% 60.89% -4.86%
+ Complexity 4173 3878 -295
============================================
Files 371 347 -24
Lines 19910 19570 -340
Branches 2590 2587 -3
============================================
- Hits 13090 11917 -1173
- Misses 5366 6312 +946
+ Partials 1454 1341 -113
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.89% <22.72%> (-0.12%)` | `0.00 <2.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/tuweni/jsonrpc/ClientRequestException.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9DbGllbnRSZXF1ZXN0RXhjZXB0aW9uLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `89.28% <0.00%> (-3.31%)` | `3.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `33.33% <21.95%> (-61.41%)` | `3.00 <1.00> (ø)` | |
| [...ain/java/org/apache/tuweni/units/ethereum/Wei.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-dW5pdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS91bml0cy9ldGhlcmV1bS9XZWkuamF2YQ==) | `68.00% <100.00%> (+1.33%)` | `10.00 <1.00> (+1.00)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [67 more](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=footer). Last update [1f91a08...c8c3a6b](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #184: Add faucet app
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #184:
URL: https://github.com/apache/incubator-tuweni/pull/184#issuecomment-745008571
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=h1) Report
> Merging [#184](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=desc) (79da1b6) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/1f91a083dff2526edcb31df620bea927854ee550?el=desc) (1f91a08) will **decrease** coverage by `4.90%`.
> The diff coverage is `22.72%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #184 +/- ##
============================================
- Coverage 65.74% 60.84% -4.91%
+ Complexity 4173 3878 -295
============================================
Files 371 347 -24
Lines 19910 19570 -340
Branches 2590 2587 -3
============================================
- Hits 13090 11907 -1183
- Misses 5366 6322 +956
+ Partials 1454 1341 -113
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.84% <22.72%> (-0.17%)` | `0.00 <2.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/tuweni/jsonrpc/ClientRequestException.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9DbGllbnRSZXF1ZXN0RXhjZXB0aW9uLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `89.28% <0.00%> (-3.31%)` | `3.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `33.33% <21.95%> (-61.41%)` | `3.00 <1.00> (ø)` | |
| [...ain/java/org/apache/tuweni/units/ethereum/Wei.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-dW5pdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS91bml0cy9ldGhlcmV1bS9XZWkuamF2YQ==) | `68.00% <100.00%> (+1.33%)` | `10.00 <1.00> (+1.00)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [70 more](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=footer). Last update [1f91a08...dde9c96](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #184: Add faucet app
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-tuweni/pull/184#issuecomment-745008571
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=h1) Report
> Merging [#184](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=desc) (28fb7ca) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/1f91a083dff2526edcb31df620bea927854ee550?el=desc) (1f91a08) will **decrease** coverage by `4.85%`.
> The diff coverage is `22.72%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #184 +/- ##
============================================
- Coverage 65.74% 60.89% -4.86%
+ Complexity 4173 3878 -295
============================================
Files 371 347 -24
Lines 19910 19570 -340
Branches 2590 2587 -3
============================================
- Hits 13090 11917 -1173
- Misses 5366 6312 +946
+ Partials 1454 1341 -113
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.89% <22.72%> (-0.12%)` | `0.00 <2.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/tuweni/jsonrpc/ClientRequestException.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9DbGllbnRSZXF1ZXN0RXhjZXB0aW9uLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `89.28% <0.00%> (-3.31%)` | `3.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `33.33% <21.95%> (-61.41%)` | `3.00 <1.00> (ø)` | |
| [...ain/java/org/apache/tuweni/units/ethereum/Wei.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-dW5pdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS91bml0cy9ldGhlcmV1bS9XZWkuamF2YQ==) | `68.00% <100.00%> (+1.33%)` | `10.00 <1.00> (+1.00)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [67 more](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=footer). Last update [1f91a08...7532a47](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #184: Add faucet app
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-tuweni/pull/184#issuecomment-745008571
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=h1) Report
> Merging [#184](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=desc) (7532a47) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/1f91a083dff2526edcb31df620bea927854ee550?el=desc) (1f91a08) will **decrease** coverage by `0.19%`.
> The diff coverage is `24.44%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #184 +/- ##
============================================
- Coverage 65.74% 65.55% -0.20%
+ Complexity 4173 4172 -1
============================================
Files 371 372 +1
Lines 19910 19951 +41
Branches 2590 2594 +4
============================================
- Hits 13090 13079 -11
- Misses 5366 5419 +53
+ Partials 1454 1453 -1
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `47.88% <100.00%> (-0.19%)` | `0.00 <0.00> (ø)` | |
| unit | `60.87% <22.72%> (-0.14%)` | `0.00 <2.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/tuweni/jsonrpc/ClientRequestException.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9DbGllbnRSZXF1ZXN0RXhjZXB0aW9uLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `89.28% <0.00%> (-3.31%)` | `3.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `33.33% <21.95%> (-61.41%)` | `3.00 <1.00> (ø)` | |
| [...g/apache/tuweni/scuttlebutt/lib/KeyFileLoader.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtY2xpZW50LWxpYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3NjdXR0bGVidXR0L2xpYi9LZXlGaWxlTG9hZGVyLmphdmE=) | `76.92% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ain/java/org/apache/tuweni/units/ethereum/Wei.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-dW5pdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS91bml0cy9ldGhlcmV1bS9XZWkuamF2YQ==) | `68.00% <100.00%> (+1.33%)` | `10.00 <1.00> (+1.00)` | |
| [...org/apache/tuweni/rlpx/wire/DisconnectMessage.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9EaXNjb25uZWN0TWVzc2FnZS5qYXZh) | `90.00% <0.00%> (-10.00%)` | `6.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/DefaultWireConnection.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9EZWZhdWx0V2lyZUNvbm5lY3Rpb24uamF2YQ==) | `73.37% <0.00%> (-4.74%)` | `29.00% <0.00%> (ø%)` | |
| [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `79.48% <0.00%> (-3.42%)` | `14.00% <0.00%> (ø%)` | |
| [.../org/apache/tuweni/rlpx/wire/DisconnectReason.java](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9EaXNjb25uZWN0UmVhc29uLmphdmE=) | `54.54% <0.00%> (-3.04%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-tuweni/pull/184/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=footer). Last update [1f91a08...c8c3a6b](https://codecov.io/gh/apache/incubator-tuweni/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #184: Add faucet app
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #184:
URL: https://github.com/apache/incubator-tuweni/pull/184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org