You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "marsevilspirit (via GitHub)" <gi...@apache.org> on 2025/05/02 11:09:28 UTC
[PR] feat: support new triple non-IDL mode [dubbo-go]
marsevilspirit opened a new pull request, #2858:
URL: https://github.com/apache/dubbo-go/pull/2858
The PR has temporarily introduced a new field "IDL-mode" to the URL. This field is intended to differentiate between the "new triple non-IDL mode" and the "old triple non-IDL mode." The new field will be removed when the old triple protocol is deprecated, and "info" will then be used to distinguish whether it is an IDL or not.
It supports two types of launch modes: 'server and client', and 'instance'.
Currently, launching non-idl mode with dubbo.load is not supported, and it is expected to be implemented in the next PR.
The new triple non-IDL mode currently does not support protobuf and protojson serialization.
In the future, a generic call will be implemented, allowing the client to call the service without APIs.
This PR introduces some new APIs for users.
service:
```go
type GreetService struct{}
func (s *GreetService) Greet(ctx context.Context, name string) (string, error) {
return "hello " + name, nil
}
```
Server:
```go
func main() {
srv, err := server.NewServer(
server.WithServerProtocol(
protocol.WithPort(20000),
protocol.WithTriple(),
),
)
if err != nil {
panic(err)
}
if err := srv.RegisterService(&api.GreetService{}); err != nil {
panic(err)
}
if err := srv.Serve(); err != nil {
panic(err)
}
}
```
client:
```go
func main() {
cli, err := client.NewClient(
client.WithClientURL("127.0.0.1:20000"),
client.WithClientSerialization(constant.MsgpackSerialization),
)
if err != nil {
panic(err)
}
conn, err := cli.NewService(&api.GreetService{})
if err != nil {
panic(err)
}
var resp string
if err := conn.CallUnary(context.Background(), []any{"world"}, &resp, "Greet"); err != nil {
panic(err)
}
logger.Infof("Get Response: %s", resp)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2893112306
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "marsevilspirit (via GitHub)" <gi...@apache.org>.
marsevilspirit commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2083421605
##########
client/client.go:
##########
@@ -96,12 +112,29 @@ func (conn *Connection) CallBidiStream(ctx context.Context, methodName string, o
return res.Result(), res.Error()
}
+func (cli *Client) NewService(service any, opts ...ReferenceOption) (*Connection, error) {
+ interafceName := common.GetReference(service)
Review Comment:
you are right.
##########
client/client.go:
##########
@@ -96,12 +112,29 @@ func (conn *Connection) CallBidiStream(ctx context.Context, methodName string, o
return res.Result(), res.Error()
}
+func (cli *Client) NewService(service any, opts ...ReferenceOption) (*Connection, error) {
+ interafceName := common.GetReference(service)
Review Comment:
Oops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "marsevilspirit (via GitHub)" <gi...@apache.org>.
marsevilspirit commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2082991244
##########
common/constant/key.go:
##########
@@ -64,6 +64,16 @@ const (
MaxServerRecvMsgSize = "max-server-recv-msg-size"
KeepAliveInterval = "keep-alive-interval"
KeepAliveTimeout = "keep-alive-timeout"
+
+ // TODO: remove IDLMode after old triple removed
+ IDLMode = "IDL-mode"
+)
+
+// TODO: remove this after old triple removed
+// IDLMode
+const (
+ IDL = "IDL"
+ NONIDL = "non-IDL"
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "1kasa (via GitHub)" <gi...@apache.org>.
1kasa commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2083217269
##########
client/client.go:
##########
@@ -96,12 +112,29 @@ func (conn *Connection) CallBidiStream(ctx context.Context, methodName string, o
return res.Result(), res.Error()
}
+func (cli *Client) NewService(service any, opts ...ReferenceOption) (*Connection, error) {
+ interafceName := common.GetReference(service)
Review Comment:
typo error，I think you meanning interfaceName?
##########
client/client.go:
##########
@@ -96,12 +112,29 @@ func (conn *Connection) CallBidiStream(ctx context.Context, methodName string, o
return res.Result(), res.Error()
}
+func (cli *Client) NewService(service any, opts ...ReferenceOption) (*Connection, error) {
+ interafceName := common.GetReference(service)
Review Comment:
It's better to add defensive programming here.
```
if service == nil {
return nil, errors.New("service must not be nil")
}
```
To avoid panic caused by sType := reflect.TypeOf(service), and toTroubleshoot errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "marsevilspirit (via GitHub)" <gi...@apache.org>.
marsevilspirit commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2097032240
##########
dubbo.go:
##########
@@ -248,3 +263,26 @@ func SetProviderServiceWithInfo(svc common.RPCService, info *common.ServiceInfo)
Info: info,
}
}
+
+func SetConsumerService(svc common.RPCService) {
+ conLock.Lock()
+ defer conLock.Unlock()
+ consumerServices[common.GetReference(svc)] = &client.ClientDefinition{
+ Svc: svc,
+ Info: nil,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2868569958
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2847034783
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2071645381
##########
protocol/triple/server.go:
##########
@@ -76,9 +76,13 @@ func (s *Server) Start(invoker protocol.Invoker, info *common.ServiceInfo) {
serialization := URL.GetParam(constant.SerializationKey, constant.ProtobufSerialization)
switch serialization {
case constant.ProtobufSerialization:
+ logger.Debugf("Triple server use protobuf serializaition")
case constant.JSONSerialization:
+ logger.Debugf("Triple server use json serializaition")
case constant.Hessian2Serialization:
+ logger.Debugf("Triple server use hessian2 serializaition")
case constant.MsgpackSerialization:
+ logger.Debugf("Triple server use msgpack serializaition")
Review Comment:
这种测试日志放这里有何意义呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "marsevilspirit (via GitHub)" <gi...@apache.org>.
marsevilspirit commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2083421776
##########
client/client.go:
##########
@@ -96,12 +112,29 @@ func (conn *Connection) CallBidiStream(ctx context.Context, methodName string, o
return res.Result(), res.Error()
}
+func (cli *Client) NewService(service any, opts ...ReferenceOption) (*Connection, error) {
+ interafceName := common.GetReference(service)
Review Comment:
done
##########
client/client.go:
##########
@@ -96,12 +112,29 @@ func (conn *Connection) CallBidiStream(ctx context.Context, methodName string, o
return res.Result(), res.Error()
}
+func (cli *Client) NewService(service any, opts ...ReferenceOption) (*Connection, error) {
+ interafceName := common.GetReference(service)
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2847031329
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2893509897
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2848643524
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "marsevilspirit (via GitHub)" <gi...@apache.org>.
marsevilspirit commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2072402787
##########
protocol/triple/server.go:
##########
@@ -76,9 +76,13 @@ func (s *Server) Start(invoker protocol.Invoker, info *common.ServiceInfo) {
serialization := URL.GetParam(constant.SerializationKey, constant.ProtobufSerialization)
switch serialization {
case constant.ProtobufSerialization:
+ logger.Debugf("Triple server use protobuf serializaition")
case constant.JSONSerialization:
+ logger.Debugf("Triple server use json serializaition")
case constant.Hessian2Serialization:
+ logger.Debugf("Triple server use hessian2 serializaition")
case constant.MsgpackSerialization:
+ logger.Debugf("Triple server use msgpack serializaition")
Review Comment:
fixed
##########
protocol/triple/client.go:
##########
@@ -157,12 +158,16 @@ func newClientManager(url *common.URL) (*clientManager, error) {
switch serialization {
case constant.ProtobufSerialization:
isIDL = true
+ logger.Debugf("Triple client manager use protobuf serializaition")
case constant.JSONSerialization:
isIDL = true
+ logger.Debugf("Triple client manager use protojson serializaition")
cliOpts = append(cliOpts, tri.WithProtoJSON())
case constant.Hessian2Serialization:
+ logger.Debugf("Triple client manager use hessian2 serializaition")
cliOpts = append(cliOpts, tri.WithHessian2())
case constant.MsgpackSerialization:
+ logger.Debugf("Triple client manager use msgpack serializaition")
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "marsevilspirit (via GitHub)" <gi...@apache.org>.
marsevilspirit commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2888951141
@1kasa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2094553391
##########
global/reference_config.go:
##########
@@ -47,6 +47,10 @@ type ReferenceConfig struct {
MeshProviderPort int `yaml:"mesh-provider-port" json:"mesh-provider-port,omitempty" propertiy:"mesh-provider-port"`
KeepAliveInterval string `yaml:"keep-alive-interval" json:"keep-alive-interval,omitempty" property:"keep-alive-interval"`
KeepAliveTimeout string `yaml:"keep-alive-timeout" json:"keep-alive-timeout,omitempty" property:"keep-alive-timeout"`
+
+ // just for new triple non-IDL mode
+ // TODO: remove IDLMode when config package is removed
+ IDLMode string
Review Comment:
The new `IDLMode` field lacks YAML/JSON tags, so it won't be deserialized from config files. Add tags such as `yaml:"idl-mode" json:"idl-mode,omitempty"`.
```suggestion
IDLMode string `yaml:"idl-mode" json:"idl-mode,omitempty"`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2096989332
##########
dubbo.go:
##########
@@ -220,11 +227,19 @@ func (ins *Instance) loadConsumer() error {
conLock.RLock()
defer conLock.RUnlock()
for intfName, definition := range consumerServices {
- conn, dialErr := cli.DialWithDefinition(intfName, definition)
+ var conn *client.Connection
Review Comment:
统一放到一个大的 var block 里面
var (
conn *client.Connection
dialErr error
)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2846961717
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2071643829
##########
protocol/triple/client.go:
##########
@@ -157,12 +158,16 @@ func newClientManager(url *common.URL) (*clientManager, error) {
switch serialization {
case constant.ProtobufSerialization:
isIDL = true
+ logger.Debugf("Triple client manager use protobuf serializaition")
case constant.JSONSerialization:
isIDL = true
+ logger.Debugf("Triple client manager use protojson serializaition")
cliOpts = append(cliOpts, tri.WithProtoJSON())
case constant.Hessian2Serialization:
+ logger.Debugf("Triple client manager use hessian2 serializaition")
cliOpts = append(cliOpts, tri.WithHessian2())
case constant.MsgpackSerialization:
+ logger.Debugf("Triple client manager use msgpack serializaition")
Review Comment:
上面这四条 log，我觉着应该是测试日志吧？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2848762685
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2848642183
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2869532393
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2096989332
##########
dubbo.go:
##########
@@ -220,11 +227,19 @@ func (ins *Instance) loadConsumer() error {
conLock.RLock()
defer conLock.RUnlock()
for intfName, definition := range consumerServices {
- conn, dialErr := cli.DialWithDefinition(intfName, definition)
+ var conn *client.Connection
Review Comment:
var (
conn *client.Connection
dialErr error
)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2846961290
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#issuecomment-2848757331
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858) **Quality Gate passed**
Issues
 [11 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2858&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2858&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2858&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2858)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "No-SilverBullet (via GitHub)" <gi...@apache.org>.
No-SilverBullet commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2081824509
##########
common/constant/key.go:
##########
@@ -64,6 +64,16 @@ const (
MaxServerRecvMsgSize = "max-server-recv-msg-size"
KeepAliveInterval = "keep-alive-interval"
KeepAliveTimeout = "keep-alive-timeout"
+
+ // TODO: remove IDLMode after old triple removed
+ IDLMode = "IDL-mode"
+)
+
+// TODO: remove this after old triple removed
+// IDLMode
+const (
+ IDL = "IDL"
+ NONIDL = "non-IDL"
Review Comment:
change to an enumerated type for better type safety, like
`type IDLMode string`
`const (`
` // IDLModeIDL represents the IDL mode of Triple protocol`
` IDLModeIDL IDLMode = "IDL"`
` // IDLModeNonIDL represents the non-IDL mode of Triple protocol`
` IDLModeNonIDL IDLMode = "non-IDL"`
`)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "No-SilverBullet (via GitHub)" <gi...@apache.org>.
No-SilverBullet merged PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2096990233
##########
dubbo.go:
##########
@@ -248,3 +263,26 @@ func SetProviderServiceWithInfo(svc common.RPCService, info *common.ServiceInfo)
Info: info,
}
}
+
+func SetConsumerService(svc common.RPCService) {
+ conLock.Lock()
+ defer conLock.Unlock()
+ consumerServices[common.GetReference(svc)] = &client.ClientDefinition{
+ Svc: svc,
+ Info: nil,
Review Comment:
nil 不用赋值，默认值就是 nil
##########
dubbo.go:
##########
@@ -248,3 +263,26 @@ func SetProviderServiceWithInfo(svc common.RPCService, info *common.ServiceInfo)
Info: info,
}
}
+
+func SetConsumerService(svc common.RPCService) {
+ conLock.Lock()
+ defer conLock.Unlock()
+ consumerServices[common.GetReference(svc)] = &client.ClientDefinition{
+ Svc: svc,
+ Info: nil,
+ Conn: nil,
+ }
+}
+
+func SetProviderService(svc common.RPCService) {
+ conLock.Lock()
+ defer conLock.Unlock()
+ providerServices[common.GetReference(svc)] = &server.ServiceDefinition{
+ Handler: svc,
+ Info: nil,
Review Comment:
nil 不用赋值，默认值就是 nil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "marsevilspirit (via GitHub)" <gi...@apache.org>.
marsevilspirit commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2097030629
##########
dubbo.go:
##########
@@ -220,11 +227,19 @@ func (ins *Instance) loadConsumer() error {
conLock.RLock()
defer conLock.RUnlock()
for intfName, definition := range consumerServices {
- conn, dialErr := cli.DialWithDefinition(intfName, definition)
+ var conn *client.Connection
Review Comment:
fixed
##########
dubbo.go:
##########
@@ -248,3 +263,26 @@ func SetProviderServiceWithInfo(svc common.RPCService, info *common.ServiceInfo)
Info: info,
}
}
+
+func SetConsumerService(svc common.RPCService) {
+ conLock.Lock()
+ defer conLock.Unlock()
+ consumerServices[common.GetReference(svc)] = &client.ClientDefinition{
+ Svc: svc,
+ Info: nil,
+ Conn: nil,
+ }
+}
+
+func SetProviderService(svc common.RPCService) {
+ conLock.Lock()
+ defer conLock.Unlock()
+ providerServices[common.GetReference(svc)] = &server.ServiceDefinition{
+ Handler: svc,
+ Info: nil,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: support new triple non-IDL mode [dubbo-go]
Posted by "marsevilspirit (via GitHub)" <gi...@apache.org>.
marsevilspirit commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2097042806
##########
global/reference_config.go:
##########
@@ -47,6 +47,10 @@ type ReferenceConfig struct {
MeshProviderPort int `yaml:"mesh-provider-port" json:"mesh-provider-port,omitempty" propertiy:"mesh-provider-port"`
KeepAliveInterval string `yaml:"keep-alive-interval" json:"keep-alive-interval,omitempty" property:"keep-alive-interval"`
KeepAliveTimeout string `yaml:"keep-alive-timeout" json:"keep-alive-timeout,omitempty" property:"keep-alive-timeout"`
+
+ // just for new triple non-IDL mode
+ // TODO: remove IDLMode when config package is removed
+ IDLMode string
Review Comment:
you are wrong, bro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org