You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/18 20:47:19 UTC
[GitHub] [superset] rusackas commented on a diff in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…
rusackas commented on code in PR #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r852403696
##########
superset-frontend/src/components/FilterableTable/FilterableTable.tsx:
##########
@@ -445,32 +448,52 @@ export default class FilterableTable extends PureComponent<
? 'header-style-disabled'
: 'header-style';
return (
- <Tooltip
- key={key}
- id="header-tooltip"
- title={label}
- placement="topLeft"
- css={{ display: 'block' }}
+ <div
+ style={{
+ ...style,
+ top:
+ typeof style.top === 'number'
+ ? style.top - GRID_POSITION_ADJUSTMENT
+ : style.top,
+ }}
+ className={`${className} grid-cell grid-header-cell`}
+ role="columnheader"
+ tabIndex={columnIndex}
+ onClick={() => this.sortGrid(label)}
>
- <div
- style={{
- ...style,
- top:
- typeof style.top === 'number'
- ? style.top - GRID_POSITION_ADJUSTMENT
- : style.top,
- }}
- className={`${className} grid-cell grid-header-cell`}
- role="columnheader"
- tabIndex={columnIndex}
- onClick={() => this.sortGrid(label)}
- >
+ <TooltipParagraph key={key} id="header-tooltip">
{label}
- {this.state.sortBy === label && (
- <SortIndicator sortDirection={this.state.sortDirection} />
- )}
- </div>
- </Tooltip>
+ </TooltipParagraph>
+ {this.state.sortBy === label && (
+ <SortIndicator sortDirection={this.state.sortDirection} />
+ )}
+ </div>
+ // <Tooltip
Review Comment:
Delete commentes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org