You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/07/16 09:01:49 UTC

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f…

arpadboda commented on a change in pull request #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f…
URL: https://github.com/apache/nifi-minifi-cpp/pull/610#discussion_r303790532
 
 

 ##########
 File path: extensions/civetweb/tests/resources/generate.sh
 ##########
 @@ -0,0 +1,53 @@
+#!/bin/sh
 
 Review comment:
   This script is useful, although I wonder:
   -If we need it here at all as the certs are also added to the repo?
   -Is it related to Civet anyhow? Keep it as a generic tool to generate certs is nice and I strongly support, but should be placed somewhere else in this case. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services