[GitHub] [arrow-datafusion] kszucs commented on a change in pull request #469: Expose DataFrame::sort in the python bindings

[GitBox <gi...@apache.org>]

kszucs commented on a change in pull request #469:
URL: https://github.com/apache/arrow-datafusion/pull/469#discussion_r643214523



##########
File path: python/src/dataframe.rs
##########
@@ -93,6 +93,18 @@ impl DataFrame {
         })
     }
 
+    /// Sort by specified sorting expressions
+    fn sort(&self, exprs: Vec<expression::Expression>) -> PyResult<Self> {
+        let exprs = exprs.into_iter().map(|e| e.expr);
+        let builder = LogicalPlanBuilder::from(&self.plan);

Review comment:
       @jorgecarleitao would it make sense to wrap the `DataFrameImpl` instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org