You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/04 15:28:40 UTC

[GitHub] [incubator-superset] agatapst opened a new pull request #12252: fix: Chart filter indicator matches native filter indicator

agatapst opened a new pull request #12252:
URL: https://github.com/apache/incubator-superset/pull/12252


   ### SUMMARY
   The problem was that chart indicator did not match native filter indicator and this PR fixes that.
   Be aware that there is still filter component next to the charts. It is separated from the native filters, but has impact on the same charts. It also counts as "Applied filter".
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="1388" alt="indicator_1_before" src="https://user-images.githubusercontent.com/47450693/103547414-aa146b00-4ea4-11eb-932c-1e5cee5f2ae1.png">
   ![image](https://user-images.githubusercontent.com/47450693/103547374-9cf77c00-4ea4-11eb-87d3-1c746e49b629.png)
   
   After: 
   <img width="1388" alt="indicator_1_after" src="https://user-images.githubusercontent.com/47450693/103546888-f3b08600-4ea3-11eb-9a85-b52a89110fce.png">
   <img width="1391" alt="indicator_2_after" src="https://user-images.githubusercontent.com/47450693/103546897-f6ab7680-4ea3-11eb-9980-78eb0451c479.png">
   
   ### TEST PLAN
   Verify manually. Go to `config.py` and set `"DASHBOARD_NATIVE_FILTERS": True`
   Go to a dashboard and create Native Filter. 
   Click an indicator presented on the charts (dark gray pill with a number). See if the information matches your filter.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc @junlincc @villebro 
   @adam-stasiak could you please test?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #12252: fix: Displaying filter indicators

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12252:
URL: https://github.com/apache/incubator-superset/pull/12252#issuecomment-754136951


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=h1) Report
   > Merging [#12252](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=desc) (843df37) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3bbbf8ea33fbec5a58fc07f56d2fd8fdf30135f?el=desc) (a3bbbf8) will **decrease** coverage by `16.29%`.
   > The diff coverage is `35.48%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12252/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12252       +/-   ##
   ===========================================
   - Coverage   67.11%   50.82%   -16.30%     
   ===========================================
     Files         996      461      -535     
     Lines       49176    16792    -32384     
     Branches     4993     4304      -689     
   ===========================================
   - Hits        33006     8534    -24472     
   + Misses      16047     8258     -7789     
   + Partials      123        0      -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.82% <35.48%> (-0.49%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/dashboard/components/FiltersBadge/selectors.ts](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9zZWxlY3RvcnMudHM=) | `68.11% <34.78%> (-20.12%)` | :arrow_down: |
   | [...frontend/src/dashboard/containers/FiltersBadge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlcnNCYWRnZS50c3g=) | `73.68% <37.50%> (-26.32%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | ... and [853 more](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=footer). Last update [a3bbbf8...843df37](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] adam-stasiak commented on pull request #12252: fix: Displaying filter indicators

Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12252:
URL: https://github.com/apache/incubator-superset/pull/12252#issuecomment-754632922


   After second test it is ok! no issue from above message


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12252: fix: Displaying filter indicators

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12252:
URL: https://github.com/apache/incubator-superset/pull/12252#issuecomment-754136951


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=h1) Report
   > Merging [#12252](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=desc) (843df37) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3bbbf8ea33fbec5a58fc07f56d2fd8fdf30135f?el=desc) (a3bbbf8) will **decrease** coverage by `15.84%`.
   > The diff coverage is `35.48%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12252/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12252       +/-   ##
   ===========================================
   - Coverage   67.11%   51.26%   -15.85%     
   ===========================================
     Files         996      461      -535     
     Lines       49176    16792    -32384     
     Branches     4993     4304      -689     
   ===========================================
   - Hits        33006     8609    -24397     
   + Misses      16047     8183     -7864     
   + Partials      123        0      -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `51.26% <35.48%> (-0.04%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/dashboard/components/FiltersBadge/selectors.ts](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9zZWxlY3RvcnMudHM=) | `68.11% <34.78%> (-20.12%)` | :arrow_down: |
   | [...frontend/src/dashboard/containers/FiltersBadge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlcnNCYWRnZS50c3g=) | `73.68% <37.50%> (-26.32%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | ... and [852 more](https://codecov.io/gh/apache/incubator-superset/pull/12252/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=footer). Last update [a3bbbf8...843df37](https://codecov.io/gh/apache/incubator-superset/pull/12252?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] adam-stasiak commented on pull request #12252: fix: Displaying filter indicators

Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12252:
URL: https://github.com/apache/incubator-superset/pull/12252#issuecomment-754563930


   @agatapst I can see situation where child filters are not displayed as set when I use them:
   <img width="802" alt="Zrzut ekranu 2021-01-5 o 11 55 17" src="https://user-images.githubusercontent.com/25153919/103638318-09c65100-4f4d-11eb-9d5e-8379fe077ac7.png">
   <img width="362" alt="Zrzut ekranu 2021-01-5 o 11 55 23" src="https://user-images.githubusercontent.com/25153919/103638323-0cc14180-4f4d-11eb-8636-89255002dac3.png">
   I think it should be displayed under APPLIED FILTERS section 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org