[GitHub] [apisix] wangxiaochuang opened a new pull request #2944: Update balancer.lua, need to start checker

[GitBox <gi...@apache.org>]

wangxiaochuang opened a new pull request #2944:
URL: https://github.com/apache/apisix/pull/2944


   the health checker need to be started
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed pull request #2944: Update balancer.lua, need to start checker

[GitBox <gi...@apache.org>]

spacewander closed pull request #2944:
URL: https://github.com/apache/apisix/pull/2944


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #2944: Update balancer.lua, need to start checker

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #2944:
URL: https://github.com/apache/apisix/pull/2944#discussion_r534873973



##########
File path: apisix/balancer.lua
##########
@@ -118,6 +118,7 @@ local function create_checker(upstream, healthcheck_parent)
         end)
     end
 
+    checker:start()

Review comment:
       The checker is already started in `healcheck.new`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org