You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/12/03 14:43:14 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1223: MINIFICPP-1223 Only reload script file in ExecutePythonScript when requested in property
lordgamez opened a new pull request #1223:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1223
https://issues.apache.org/jira/browse/MINIFICPP-1223
-----------------------------------------------------------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1223: MINIFICPP-1223 Only reload script file in ExecutePythonScript when requested in property
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #1223:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1223#discussion_r762962576
##########
File path: PROCESSORS.md
##########
@@ -421,8 +421,9 @@ In the list below, the names of required properties appear in bold. Any other pr
| Name | Default Value | Allowable Values | Description |
| - | - | - | - |
-|Script File|||Path to script file to execute. Only one of Script File or Script Body may be used|
+|**Reload on Script Change**|false||If true and Script File property is used, then script file will be reloaded if it has changed, otherwise the first loaded version will be used at all times.|
Review comment:
Could you elaborate on why was it never reloaded? I thought it was reloaded whenever the last write time increased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1223: MINIFICPP-1223 Only reload script file in ExecutePythonScript when requested in property
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #1223:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1223#discussion_r763940056
##########
File path: libminifi/test/script-tests/ExecutePythonProcessorTests.cpp
##########
@@ -54,13 +60,16 @@ class ExecutePythonProcessorTestBase {
}
std::string getScriptFullPath(const std::string& script_file_name) {
+ if (script_file_name.find('/') != std::string::npos || script_file_name.find("\\") != std::string::npos) {
Review comment:
Good point, it's technically the same. Replaced it in f0cae0afc62088ebaa87610c297e79ee75fc7dc4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1223: MINIFICPP-1223 Only reload script file in ExecutePythonScript when requested in property
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #1223:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1223#discussion_r762047652
##########
File path: PROCESSORS.md
##########
@@ -421,8 +421,9 @@ In the list below, the names of required properties appear in bold. Any other pr
| Name | Default Value | Allowable Values | Description |
| - | - | - | - |
-|Script File|||Path to script file to execute. Only one of Script File or Script Body may be used|
+|**Reload on Script Change**|false||If true and Script File property is used, then script file will be reloaded if it has changed, otherwise the first loaded version will be used at all times.|
Review comment:
true is a better default IMO. If we already have the capability to respond to changes, then why not use it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1223: MINIFICPP-1223 Only reload script file in ExecutePythonScript when requested in property
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #1223:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1223#discussion_r762975275
##########
File path: PROCESSORS.md
##########
@@ -421,8 +421,9 @@ In the list below, the names of required properties appear in bold. Any other pr
| Name | Default Value | Allowable Values | Description |
| - | - | - | - |
-|Script File|||Path to script file to execute. Only one of Script File or Script Body may be used|
+|**Reload on Script Change**|false||If true and Script File property is used, then script file will be reloaded if it has changed, otherwise the first loaded version will be used at all times.|
Review comment:
The PythonScriptEngine's eval function was not called after reading the file's content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1223: MINIFICPP-1223 Only reload script file in ExecutePythonScript when requested in property
Posted by GitBox <gi...@apache.org>.
adamdebreceni closed pull request #1223:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1223: MINIFICPP-1223 Only reload script file in ExecutePythonScript when requested in property
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #1223:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1223#discussion_r762864051
##########
File path: PROCESSORS.md
##########
@@ -421,8 +421,9 @@ In the list below, the names of required properties appear in bold. Any other pr
| Name | Default Value | Allowable Values | Description |
| - | - | - | - |
-|Script File|||Path to script file to execute. Only one of Script File or Script Body may be used|
+|**Reload on Script Change**|false||If true and Script File property is used, then script file will be reloaded if it has changed, otherwise the first loaded version will be used at all times.|
Review comment:
My only concern was the backward compatibility especially for native python processors as previously even though it looked like we reloaded the script actually it was never reloaded. But on second thought I don't think it would be a problem and we still haven't released version 1.0 so I updated it in 3a8c9b43245739352f3fef8602dac1592f0eafdd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1223: MINIFICPP-1223 Only reload script file in ExecutePythonScript when requested in property
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #1223:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1223#discussion_r763923617
##########
File path: libminifi/test/script-tests/ExecutePythonProcessorTests.cpp
##########
@@ -54,13 +60,16 @@ class ExecutePythonProcessorTestBase {
}
std::string getScriptFullPath(const std::string& script_file_name) {
+ if (script_file_name.find('/') != std::string::npos || script_file_name.find("\\") != std::string::npos) {
Review comment:
would we want this to be equivalent to `utils::file::resolve`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org