Re: [PR] HBASE-28226 Add logic to check for RegionStateNode null pointer in FlushRegionProcedure [hbase]

["Apache9 (via GitHub)" <gi...@apache.org>]

Apache9 commented on code in PR #5548:
URL: https://github.com/apache/hbase/pull/5548#discussion_r1412795917


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/FlushRegionProcedure.java:
##########
@@ -88,6 +88,12 @@ protected Procedure<MasterProcedureEnv>[] execute(MasterProcedureEnv env)
 
     RegionStates regionStates = env.getAssignmentManager().getRegionStates();
     RegionStateNode regionNode = regionStates.getRegionStateNode(region);
+    if (regionNode == null) {
+      LOG.debug(
+        "Region {} is not in region states, it is very likely that it has been cleared by other procedures such as merge or split, so skip {}. See HBASE-28226",

Review Comment:
   This line is too long, please split it so we can avoid the checkstyle warning? The maximum length for HBase is 100.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org