You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "pdhdol (via GitHub)" <gi...@apache.org> on 2026/09/16 10:21:01 UTC

[PR] fix(plugin-chart-echarts): render quarter time grain as YYYY-Qq [superset]

pdhdol opened a new pull request, #44342:
URL: https://github.com/apache/superset/pull/44342

   ### SUMMARY
   On ECharts time-series charts with Adaptive / SMART_DATE formatting and Time Grain = Quarter, quarter values were normalized to the first month of the quarter and then passed through the generic smart-date formatter. That path treats the value as a month (or year), so axis labels and tooltips collapse to something like `Jan 2024` or `2024` instead of an explicit quarter.
   This uses the d3 quarter specifier (`%Y-Q%q`) on the SMART_DATE path so axes and tooltips render `2024-Q1` … `2024-Q4`. An explicit custom time format is still honored verbatim.
   
   ### BEFORE/AFTER SCREENSHOTS
   Before
   <img width="1676" height="1111" alt="Screenshot 2569-09-16 at 17 17 34" src="https://github.com/user-attachments/assets/41647c65-a6be-460a-ba6d-74a634f061fb" />
   
   After 
   <img width="1692" height="1122" alt="Screenshot 2569-09-16 at 17 18 48" src="https://github.com/user-attachments/assets/28c42fcc-e9ff-4960-b0eb-02e8be80174a" />
   
   ### TESTING INSTRUCTIONS
   Create a Line/Area/Bar time-series chart with a temporal x-axis, Time Grain = Quarter, and X-Axis / Tooltip time format left at Adaptive formatting. Confirm ticks and hover labels are YYYY-Qq (e.g. 2024-Q1). Then set an explicit format such as %Y-%m-%d and confirm the custom format still wins.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY Qq [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-5894371525

   Heya @pdhdol, pushed a regenerated `messages.pot` here, the original babel-extract failure was just master's connection-move wording drifting ahead of your branch, nothing in your own diff.
   
   Couple of things left though. CI itself isn't queuing on this fork right now, something's stuck in the Actions approval/concurrency plumbing that a few pushes from my end couldn't clear, so it'll probably need a maintainer to manually re-run from the Checks tab. And separately, this branch has been open long enough that it's drifted into a real conflict with `master` now, so it'll need a rebase before any of that matters anyway.
   
   Rebase whenever you get a chance and I'll get CI re-triggered after.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY Qq [superset]

Posted by "pdhdol (via GitHub)" <gi...@apache.org>.
pdhdol commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-5810242433

   @rusackas Got it - Thank you so much for reviewing :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY Qq [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #44342:
URL: https://github.com/apache/superset/pull/44342#discussion_r4131548522


##########
superset/translations/messages.pot:
##########
@@ -321,10 +359,34 @@ msgstr ""
 msgid "%s Virtual"
 msgstr ""
 
+#, python-format
+msgid "%s additional restricted chart"
+msgid_plural "%s additional restricted charts"
+msgstr[0] ""
+msgstr[1] ""

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Dead plural msgid chart</b></div>
   <div id="fix">
   
   This plural msgid has no source: the only consumer, `ArchivedDatasetPurgeModal.tsx:118`, calls `t('%(count)s additional restricted %(label)s')` (that variant is also added at lines 204-210), never `tn()`. Babel cannot have extracted this form from the current tree, so it is a dead catalog entry translators may waste effort on. Remove it or migrate the modal to `tn()`.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #a07ad6</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



##########
superset/translations/messages.pot:
##########
@@ -321,10 +359,34 @@ msgstr ""
 msgid "%s Virtual"
 msgstr ""
 
+#, python-format
+msgid "%s additional restricted chart"
+msgid_plural "%s additional restricted charts"
+msgstr[0] ""
+msgstr[1] ""
+
+#, python-format
+msgid "%s additional restricted dashboard"
+msgid_plural "%s additional restricted dashboards"
+msgstr[0] ""
+msgstr[1] ""
+
+#, python-format
+msgid "%s affected chart"
+msgid_plural "%s affected charts"
+msgstr[0] ""
+msgstr[1] ""

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Stale template entry</b></div>
   <div id="fix">
   
   No `t()`/`tn()` call in the repo produces `%s affected chart(s)` — repo-wide search over py/ts/tsx/jsx finds only test names and a migration docstring, while the delete-modals emit different strings (e.g. `Checking for affected charts and dashboards…`). The entry can never be matched at lookup time; drop it or restore its source string.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #a07ad6</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



##########
superset/translations/messages.pot:
##########
@@ -321,10 +359,34 @@ msgstr ""
 msgid "%s Virtual"
 msgstr ""
 
+#, python-format
+msgid "%s additional restricted chart"
+msgid_plural "%s additional restricted charts"
+msgstr[0] ""
+msgstr[1] ""
+
+#, python-format
+msgid "%s additional restricted dashboard"

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Dead plural msgid dashboard</b></div>
   <div id="fix">
   
   Same dead-entry defect as the chart twin at lines 362-366: no source produces `%s additional restricted dashboard`; `ArchivedDatasetPurgeModal.tsx:118` uses `t('%(count)s additional restricted %(label)s')`. Remove this entry or adopt `tn()` in the modal so the plural forms become live.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #a07ad6</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



##########
superset/translations/messages.pot:
##########
@@ -785,9 +921,23 @@ msgid ""
 "https://echarts.apache.org/en/option.html. "
 msgstr ""
 
+msgid "A Slack channel is required for Slack recipients"
+msgstr ""
+
 msgid "A TTL is required for ephemeral state."
 msgstr ""
 
+msgid ""
+"A butterfly chart compares two metrics across categories using horizontal"
+" bars that extend left and right from a central axis."
+msgstr ""
+
+msgid ""
+"A candlestick chart shows opening, closing, high, and low values for each"
+" period. It is commonly used for financial and other time-series range "
+"analysis."
+msgstr ""

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Entry for absent feature</b></div>
   <div id="fix">
   
   `candlestick` appears nowhere in the repo outside this template — no plugin, component, or chart type emits this description (the sibling butterfly description does, in `plugin-chart-echarts/src/Butterfly/index.ts`). The entry is unreachable at lookup and describes a feature that does not exist here; remove it until the chart ships.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #a07ad6</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



##########
superset/translations/messages.pot:
##########
@@ -117,8 +126,8 @@ msgid ""
 "Note\n"
 "                      currently time zones are not supported. If time is "
 "stored\n"
-"                      in epoch format, put `epoch_s` or `epoch_ms`. If no"
-" pattern\n"
+"                      in epoch format, put `epoch_s`, `epoch_ms` or "
+"`epoch_us`. If no pattern\n"

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>POT msgid mismatch epoch_us</b></div>
   <div id="fix">
   
   The regenerated msgid now advertises `epoch_us`, but nothing in the tree produces or supports it: `DatasourceEditor.tsx:685` still reads `epoch_s` or `epoch_ms`, and `db_engine_specs/base.py:1256` handles only `epoch_s`/`epoch_ms`. gettext matches by exact msgid, so after .po sync the real tooltip loses its catalog entry and non-English users see the untranslated English text. Revert the msgid or land the `epoch_us` support it presupposes.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #a07ad6</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



##########
superset/translations/messages.pot:
##########
@@ -2063,13 +2294,18 @@ msgstr ""
 msgid "Archived by"
 msgstr ""
 
-msgid "Archived within"
+msgid "Archived items must be recovered before they can be opened."

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Stale POT entry swap</b></div>
   <div id="fix">
   
   The extraction dropped `msgid "Archived within"` while `BaseDeletedRecencyFilter.name` (superset/views/filters.py:330) still calls `lazy_gettext` with it, so that filter label loses translation coverage; its replacement entry "Archived items must be recovered..." has no occurrence in the source tree. Restore the in-use entry and remove the orphan - re-running the POT extraction reconciles both.
   </div>
   
   
   <details>
   <summary>
   <b>Code suggestion</b>
   </summary>
   <blockquote>Check the AI-generated fix before applying</blockquote>
   <div id="code">
   
   
   ````suggestion
   msgid "Archived within"
   msgstr ""
   ````
   
   </div>
   </details>
   
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #a07ad6</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



##########
superset/translations/messages.pot:
##########
@@ -785,9 +921,23 @@ msgid ""
 "https://echarts.apache.org/en/option.html. "
 msgstr ""
 
+msgid "A Slack channel is required for Slack recipients"

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Unmatched msgid</b></div>
   <div id="fix">
   
   No source file contains `A Slack channel is required for Slack recipients` — case-insensitive repo-wide search over py/ts/tsx finds nothing outside this template. Report-recipient validation never emits it, so the entry is unreachable at lookup; remove it or add the emitting source string.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #a07ad6</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY-Qq [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-5695905410

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY-Qq [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-5768545553

   bito's format-divergence flag looks right: core's `TimeFormatsForGranularity[QUARTER]` is already `%Y Q%q`, and that's what `getTooltipTimeFormatter` used for quarter before this PR too (matches BigNumber). Worth reusing that instead of the new `%Y-Q%q` in formatters.ts, rather than adding a third quarter format that only echarts axis/tooltips use? The axis fix itself looks right, just not sure the tooltip needed to change at all if it wasn't broken.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY Qq [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-5794068902

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY Qq [superset]

Posted by "pdhdol (via GitHub)" <gi...@apache.org>.
pdhdol commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-5914319156

   Hi @rusackas :) I just rebased onto current master. Should be clear of the conflict now. Whenever you get a chance to kick CI again, that’d be awesome. 
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY Qq [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-5917147253

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY Qq [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-6142774195

   ## CodeAnt PR Risk: Low Risk
   
   - The PR appears safe to merge; the change is limited to quarter-grain date formatting.
   - Quarter labels now use the granularity-specific formatter, with tests covering all four quarters and explicit-format precedence.
   
   **Assessed commit:** `0ece180620a1`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY Qq [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #44342:
URL: https://github.com/apache/superset/pull/44342#discussion_r4148055604


##########
superset/translations/messages.pot:
##########
@@ -165,7 +165,7 @@ msgstr ""
 msgid "\"%s\" is now the system default theme"
 msgstr ""
 
-#, no-python-format
+#, python-format

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>python-format flag regression</b></div>
   <div id="fix">
   
   scripts/translations/babel_update.sh (lines 95-122) strips python-format and forces no-python-format for exactly msgid "% calculation", documenting that babel auto-flags it on every write and msgfmt then fatals on translations containing a bare '%'. Re-adding python-format makes the committed template diverge from the canonical workflow output. Restore '#, no-python-format'.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #30f82b</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



##########
superset/translations/messages.pot:
##########
@@ -185,15 +185,15 @@ msgstr ""
 msgid "% of grand total"
 msgstr ""
 
-#, no-python-format
+#, python-format

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>python-format flag regression</b></div>
   <div id="fix">
   
   Same regression as the sibling entries: scripts/translations/babel_update.sh:95-122 strips python-format and forces no-python-format for exactly msgid "% of parent", because babel auto-flags it and msgfmt fatals on translations containing a bare '%' (30 PO catalogs counted with such msgstr values). Restore '#, no-python-format' so the template matches canonical workflow output.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #30f82b</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



##########
superset/translations/messages.pot:
##########
@@ -185,15 +185,15 @@ msgstr ""
 msgid "% of grand total"
 msgstr ""
 
-#, no-python-format
+#, python-format
 msgid "% of parent"
 msgstr ""
 
 #, python-format
 msgid "% of row total"
 msgstr ""
 
-#, no-python-format
+#, python-format

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>python-format flag regression</b></div>
   <div id="fix">
   
   Same regression: scripts/translations/babel_update.sh:95-122 strips python-format and forces no-python-format for exactly msgid "% of total", documenting that msgfmt fatals on its bare-'%' translations (e.g. de '% von Gesamtsumme', cs '% z celku'; 30 catalogs counted). The flip makes the committed template diverge from canonical output. Restore '#, no-python-format'.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #30f82b</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY-Qq [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-5698250410

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44342?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 79.94%. Comparing base ([`9079f00`](https://app.codecov.io/gh/apache/superset/commit/9079f002ee1362b8751ad738b9ab203e1f92bd52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`30f1fc0`](https://app.codecov.io/gh/apache/superset/commit/30f1fc00802573c88c2103e4df0ec94dd3455223?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 192 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #44342   +/-   ##
   =======================================
     Coverage   79.94%   79.94%           
   =======================================
     Files        2918     2918           
     Lines      170887   170886    -1     
     Branches    39614    39615    +1     
   =======================================
   + Hits       136618   136619    +1     
   + Misses      31754    31752    -2     
     Partials     2515     2515           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/44342/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/44342/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.48% <100.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44342?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY Qq [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-5886380146

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY-Qq [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-5695937199

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 30f1fc00802573c88c2103e4df0ec94dd3455223 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aaa6d8efa3bef0008ee3040 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44342--superset-docs-preview.netlify.app](https://deploy-preview-44342--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ0MzQyLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.KOHzkz_mVfFldJZKe5VG_W69pPA3yf6OzP7AGyGrEA8)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcrLCYAwDADQXXK2GFCkuIFjpDbVQn_GCoq4u729w3uhSI6lwgzQgRFK697s_N0fF0llUdVHVpuQTyqQ4XC2aLmE_Cy21YmIJqvZ0WDYIaJmHnBE-H4) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-44342--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(plugin-chart-echarts): render quarter time grain as YYYY Qq [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44342:
URL: https://github.com/apache/superset/pull/44342#issuecomment-5905807973

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org