You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/27 09:45:38 UTC

[GitHub] [kafka] nizhikov opened a new pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

nizhikov opened a new pull request #8731:
URL: https://github.com/apache/kafka/pull/8731


   kafka_log4j_appender.py broken on JDK11 by #befd80b38d3ccb1aa0c6d99a899129fd5cf27774
   This fix just setup node version for log4j appender.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8731:
URL: https://github.com/apache/kafka/pull/8731#issuecomment-634644538


   Thanks for the PR. Can you elaborate how the original change broke it? I don't see anything obviously related.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] nizhikov commented on pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

Posted by GitBox <gi...@apache.org>.
nizhikov commented on pull request #8731:
URL: https://github.com/apache/kafka/pull/8731#issuecomment-634599948


   Hello, @ijuma 
   
   I found that `kafka_log4j_appender.py` broken for JDK11.
   This was broken by my patch - befd80b38d3ccb1aa0c6d99a899129fd5cf27774
   
   I've prepared oneliner fix
   
   Can you, please, take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] nizhikov edited a comment on pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

Posted by GitBox <gi...@apache.org>.
nizhikov edited a comment on pull request #8731:
URL: https://github.com/apache/kafka/pull/8731#issuecomment-634652827


   I added call of `fix_opts_for_new_jvm` [here](https://github.com/apache/kafka/commit/befd80b38d3ccb1aa0c6d99a899129fd5cf27774#diff-ad7ee04aff5cb79b1478d038d59d4bbeR48).
   
   But `node` variable for `kafka_log4j_appender.py` don't have an attribute 'version'.
   The fix just adds this attribute from the corresponding Kafka version.
   
   ```
     File "/opt/kafka-dev/tests/kafkatest/services/kafka_log4j_appender.py", line 48, in start_cmd
       cmd = fix_opts_for_new_jvm(node)
     File "/opt/kafka-dev/tests/kafkatest/services/kafka/util.py", line 36, in fix_opts_for_new_jvm
       if node.version == LATEST_0_8_2 or node.version == LATEST_0_9 or node.version == LATEST_0_10_0 or node.version == LATEST_0_10_1 or node.version == LATEST_0_10_2 or node.version == LATEST_0_11_0 or node.version == LATEST_1_0:
   AttributeError: 'ClusterNode' object has no attribute 'version'
   ```
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] nizhikov commented on pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

Posted by GitBox <gi...@apache.org>.
nizhikov commented on pull request #8731:
URL: https://github.com/apache/kafka/pull/8731#issuecomment-634652827


   I added call of `fix_opts_for_new_jvm` [here](https://github.com/apache/kafka/commit/befd80b38d3ccb1aa0c6d99a899129fd5cf27774#diff-ad7ee04aff5cb79b1478d038d59d4bbeR48).
   
   But node variable for `kafka_log4j_appender.py` don't have attribute 'version'.
   The fix just adds this attribute from the corresponding kafka version.
   
   ```
     File "/opt/kafka-dev/tests/kafkatest/services/kafka_log4j_appender.py", line 48, in start_cmd
       cmd = fix_opts_for_new_jvm(node)
     File "/opt/kafka-dev/tests/kafkatest/services/kafka/util.py", line 36, in fix_opts_for_new_jvm
       if node.version == LATEST_0_8_2 or node.version == LATEST_0_9 or node.version == LATEST_0_10_0 or node.version == LATEST_0_10_1 or node.version == LATEST_0_10_2 or node.version == LATEST_0_11_0 or node.version == LATEST_1_0:
   AttributeError: 'ClusterNode' object has no attribute 'version'
   ```
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #8731:
URL: https://github.com/apache/kafka/pull/8731


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org