You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2021/11/03 03:00:58 UTC

Re: Review Request 73668: RANGER-3475: added public REST API endpoint to import tags

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73668/
-----------------------------------------------------------

(Updated Nov. 3, 2021, 3 a.m.)


Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3475
    https://issues.apache.org/jira/browse/RANGER-3475


Repository: ranger


Description
-------

added a public REST API endpoint service/public/v2/api/service/importtags to import tags into Ranger. This is a wrapper over existing internal API TagREST.importServiceTags().


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceTags.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceTags.java 9e8e0cf6c 
  intg/src/main/java/org/apache/ranger/RangerClient.java a1e1c7a7e 
  intg/src/main/python/apache_ranger/client/ranger_client.py 9f3a6e076 
  intg/src/main/python/apache_ranger/model/ranger_service_resource.py PRE-CREATION 
  intg/src/main/python/apache_ranger/model/ranger_service_tags.py PRE-CREATION 
  intg/src/main/python/apache_ranger/model/ranger_tag.py PRE-CREATION 
  intg/src/main/python/apache_ranger/model/ranger_tagdef.py PRE-CREATION 
  ranger-examples/sample-client/src/main/python/sample_client.py 902734901 
  security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 6ab3d52a0 


Diff: https://reviews.apache.org/r/73668/diff/2/


Testing
-------

- verified adding tags to Ranger via the new API


Thanks,

Madhan Neethiraj


Re: Review Request 73668: RANGER-3475: added public REST API endpoint to import tags

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73668/#review224332
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On April 18, 2022, 11:31 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73668/
> -----------------------------------------------------------
> 
> (Updated April 18, 2022, 11:31 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3475
>     https://issues.apache.org/jira/browse/RANGER-3475
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> added a public REST API endpoint service/public/v2/api/service/importtags to import tags into Ranger. This is a wrapper over existing internal API TagREST.importServiceTags().
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceTags.java PRE-CREATION 
>   intg/src/main/java/org/apache/ranger/RangerClient.java add084f1a 
>   intg/src/main/python/apache_ranger/client/ranger_client.py 9f3a6e076 
>   intg/src/main/python/apache_ranger/model/ranger_service_resource.py PRE-CREATION 
>   intg/src/main/python/apache_ranger/model/ranger_service_tags.py PRE-CREATION 
>   intg/src/main/python/apache_ranger/model/ranger_tag.py PRE-CREATION 
>   intg/src/main/python/apache_ranger/model/ranger_tagdef.py PRE-CREATION 
>   ranger-examples/sample-client/src/main/java/org/apache/ranger/examples/sampleclient/SampleClient.java 7d5795065 
>   ranger-examples/sample-client/src/main/python/sample_client.py 902734901 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 2c5c60923 
> 
> 
> Diff: https://reviews.apache.org/r/73668/diff/4/
> 
> 
> Testing
> -------
> 
> - verified adding tags to Ranger via the new API
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Re: Review Request 73668: RANGER-3475: added public REST API endpoint to import tags

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73668/
-----------------------------------------------------------

(Updated April 18, 2022, 11:31 p.m.)


Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

- fixes in Python client
- updated Java client to exercise new methods


Bugs: RANGER-3475
    https://issues.apache.org/jira/browse/RANGER-3475


Repository: ranger


Description
-------

added a public REST API endpoint service/public/v2/api/service/importtags to import tags into Ranger. This is a wrapper over existing internal API TagREST.importServiceTags().


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceTags.java PRE-CREATION 
  intg/src/main/java/org/apache/ranger/RangerClient.java add084f1a 
  intg/src/main/python/apache_ranger/client/ranger_client.py 9f3a6e076 
  intg/src/main/python/apache_ranger/model/ranger_service_resource.py PRE-CREATION 
  intg/src/main/python/apache_ranger/model/ranger_service_tags.py PRE-CREATION 
  intg/src/main/python/apache_ranger/model/ranger_tag.py PRE-CREATION 
  intg/src/main/python/apache_ranger/model/ranger_tagdef.py PRE-CREATION 
  ranger-examples/sample-client/src/main/java/org/apache/ranger/examples/sampleclient/SampleClient.java 7d5795065 
  ranger-examples/sample-client/src/main/python/sample_client.py 902734901 
  security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 2c5c60923 


Diff: https://reviews.apache.org/r/73668/diff/4/

Changes: https://reviews.apache.org/r/73668/diff/3-4/


Testing
-------

- verified adding tags to Ranger via the new API


Thanks,

Madhan Neethiraj


Re: Review Request 73668: RANGER-3475: added public REST API endpoint to import tags

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73668/
-----------------------------------------------------------

(Updated April 12, 2022, 9:51 p.m.)


Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

rebased to current master branch


Bugs: RANGER-3475
    https://issues.apache.org/jira/browse/RANGER-3475


Repository: ranger


Description
-------

added a public REST API endpoint service/public/v2/api/service/importtags to import tags into Ranger. This is a wrapper over existing internal API TagREST.importServiceTags().


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceTags.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceTags.java b4f250038 
  intg/src/main/java/org/apache/ranger/RangerClient.java add084f1a 
  intg/src/main/python/apache_ranger/client/ranger_client.py 9f3a6e076 
  intg/src/main/python/apache_ranger/model/ranger_service_resource.py PRE-CREATION 
  intg/src/main/python/apache_ranger/model/ranger_service_tags.py PRE-CREATION 
  intg/src/main/python/apache_ranger/model/ranger_tag.py PRE-CREATION 
  intg/src/main/python/apache_ranger/model/ranger_tagdef.py PRE-CREATION 
  ranger-examples/sample-client/src/main/python/sample_client.py 902734901 
  security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 2c5c60923 


Diff: https://reviews.apache.org/r/73668/diff/3/

Changes: https://reviews.apache.org/r/73668/diff/2-3/


Testing
-------

- verified adding tags to Ranger via the new API


Thanks,

Madhan Neethiraj