You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/09/16 22:05:31 UTC
[kudu-CR] test: deflake tablet server quiescing-itest
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16463
Change subject: test: deflake tablet_server_quiescing-itest
......................................................................
test: deflake tablet_server_quiescing-itest
It was possible that TestScansRetry would fail with more than the one
active scanner at the end of the test. This is possible because the
client scanner in the test that may have lingering retries from a
previous scan attmpts.
This patch updates to allow for multiple scan attempts, since it doesn't
detract from testing the fact that the keep-alive calls are working.
It also reenstates the quiescing state before calling the keep-alives,
which appears to be the original intent based on comments.
Change-Id: Ib6525b913cbe9acbdbc59d8a52df81c85327d0c7
---
M src/kudu/integration-tests/tablet_server_quiescing-itest.cc
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/16463/1
--
To view, visit http://gerrit.cloudera.org:8080/16463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6525b913cbe9acbdbc59d8a52df81c85327d0c7
Gerrit-Change-Number: 16463
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] test: deflake tablet server quiescing-itest
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16463 )
Change subject: test: deflake tablet_server_quiescing-itest
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6525b913cbe9acbdbc59d8a52df81c85327d0c7
Gerrit-Change-Number: 16463
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Sep 2020 22:33:46 +0000
Gerrit-HasComments: No
[kudu-CR] test: deflake tablet server quiescing-itest
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16463 )
Change subject: test: deflake tablet_server_quiescing-itest
......................................................................
test: deflake tablet_server_quiescing-itest
It was possible that TestScansRetry would fail with more than the one
active scanner at the end of the test. This is possible because the
client scanner in the test that may have lingering retries from a
previous scan attmpts.
This patch updates to allow for multiple scan attempts, since it doesn't
detract from testing the fact that the keep-alive calls are working.
It also reenstates the quiescing state before calling the keep-alives,
which appears to be the original intent based on comments.
Change-Id: Ib6525b913cbe9acbdbc59d8a52df81c85327d0c7
Reviewed-on: http://gerrit.cloudera.org:8080/16463
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/tablet_server_quiescing-itest.cc
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6525b913cbe9acbdbc59d8a52df81c85327d0c7
Gerrit-Change-Number: 16463
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)