You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (Jira)" <ji...@apache.org> on 2020/05/01 02:01:00 UTC
[jira] [Updated] (ARROW-8661) [C++][Gandiva] Reduce number of files
and headers
[ https://issues.apache.org/jira/browse/ARROW-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes McKinney updated ARROW-8661:
--------------------------------
Description:
I feel that the Gandiva subpackage is more Java-like in its code organization than the rest of the Arrow codebase, and it might be easier to navigate and develop with closely related code condensed into some larger headers and compilation units. At present there are over 100 .h/.cc files in just src/gandiva, not considering subdirectories
Additionally, it's not necessary to have a header file for each component of the function registry -- the registration functions can be declared in function_registry.h or function_registry_internal.h
was:
I feel that the Gandiva subpackage is more Java-like in its code organization than the rest of the Arrow codebase, and it might be easier to navigate and develop with closely related code condensed into some larger headers and compilation units.
Additionally, it's not necessary to have a header file for each component of the function registry -- the registration functions can be declared in function_registry.h or function_registry_internal.h
> [C++][Gandiva] Reduce number of files and headers
> -------------------------------------------------
>
> Key: ARROW-8661
> URL: https://issues.apache.org/jira/browse/ARROW-8661
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++, C++ - Gandiva
> Reporter: Wes McKinney
> Priority: Major
> Fix For: 1.0.0
>
>
> I feel that the Gandiva subpackage is more Java-like in its code organization than the rest of the Arrow codebase, and it might be easier to navigate and develop with closely related code condensed into some larger headers and compilation units. At present there are over 100 .h/.cc files in just src/gandiva, not considering subdirectories
> Additionally, it's not necessary to have a header file for each component of the function registry -- the registration functions can be declared in function_registry.h or function_registry_internal.h
--
This message was sent by Atlassian Jira
(v8.3.4#803005)