You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/07/27 00:30:41 UTC
[GitHub] zeppelin pull request #3100: ZEPPELIN-3557. Remove interpreter profiles
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3100
ZEPPELIN-3557. Remove interpreter profiles
### What is this PR for?
Just remove all interpreter profiles, instead of disable them by default. So that we won't forget to build them in travis.
### What type of PR is it?
[Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3557
### How should this be tested?
* CI
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3557
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3100
----
commit 1735f66ca29e1f3ff89f2b936ea0c17950ade21e
Author: Jeff Zhang <zj...@...>
Date: 2018-06-20T09:03:06Z
ZEPPELIN-3557. Remove interpreter profiles
----
---
[GitHub] zeppelin issue #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3100
@zjffdu, please look, smth went wrong: https://issues.apache.org/jira/browse/ZEPPELIN-3682
---
[GitHub] zeppelin issue #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3100
@jongyoul Could you help review it ? Thanks
---
[GitHub] zeppelin issue #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3100
Right, I think no one is using the pure r interpreter. I think we can use it 2 ways.
1. Create a pure r interpreter without spark support.
2. Use it another r implementing of spark and make option to allow user to choose whatever r implementation they want to use. (Because I don't know which r implementation is better, so I don't want to remove anyone of them)
---
[GitHub] zeppelin issue #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3100
Agreed. Let's merge it and proceed them with another PR.
---
[GitHub] zeppelin issue #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3100
We've tried to option 1 before but failed. We'd better give options to users like option 2
---
[GitHub] zeppelin pull request #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3100
---
[GitHub] zeppelin issue #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3100
@zjffdu Yes, it has a very long story. I, personally, don't want to keep both of them, but didn't find any solution to fit both requirements. `-Pr` is pure R interpreter which supported - I didn't test it - spark inside it. AFAIK, no one tests if SparkR works for now with `-Pr`.
---
[GitHub] zeppelin issue #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3100
I am afraid currently we can not do this. Because some unit test in zeppelin-zengine & zeppelin-server depends on spark interpreter (ZeppelinSparkClusterTest).
---
[GitHub] zeppelin issue #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3100
What I thought is to move all interpreters modules to optional. For instance, running `mvn package` will create only zeppelin-* modules, and if users want to build spark, users should do add `-P spark` as an option like `mvn package -Pspark`. What do you think of it? The main reason why I'd like to do it is to make Zeppelin's code more friendly for IDE. WDYT?
---
[GitHub] zeppelin issue #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3100
Actually this is my long time confusion part. `-Pr` would copy its artifact to `interpreter/spark` folder but it never used. I don't know the history of `-Pr`, is it an existing issue ?
---
[GitHub] zeppelin issue #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3100
BTW, did you test if sparkR works with `-Pr`?
---
[GitHub] zeppelin issue #3100: ZEPPELIN-3557. Remove interpreter profiles
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3100
Thanks @jongyoul I created ZEPPELIN-3676 for this. and will merge this ticket first.
---