You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/12 04:38:43 UTC
[PR] [studio][ISSUE #1970] Hide unsupported general settings controls [rocketmq-dashboard]
Aias00 opened a new pull request, #1971:
URL: https://github.com/apache/rocketmq-dashboard/pull/1971
## Summary
- remove visible General Settings controls that have no runtime effect
- keep persisted compatibility values in hidden form fields so existing backend settings are preserved
- leave the working header theme toggle unchanged
- cover visibility and save-payload preservation with a regression test
Closes #1970
## Validation
- npm test -- --run src/pages/settings/__tests__/GeneralSettingsTab.test.tsx
- npx eslint src/pages/settings/index.tsx src/pages/settings/__tests__/GeneralSettingsTab.test.tsx
- npm run build
- git diff --check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [studio][ISSUE #1970] Hide unsupported general settings controls [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1971:
URL: https://github.com/apache/rocketmq-dashboard/pull/1971#issuecomment-5291023075
Consolidated into #1966 as part of the batch consolidation of @Aias00's hardening PRs (merged into rocketmq-studio). The change is preserved in the merged commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [studio][ISSUE #1970] Hide unsupported general settings controls [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1971: [studio][ISSUE #1970] Hide unsupported general settings controls
URL: https://github.com/apache/rocketmq-dashboard/pull/1971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org