You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/19 21:06:03 UTC

[GitHub] [beam] pabloem commented on a change in pull request #15610: lazy creation of source splits

pabloem commented on a change in pull request #15610:
URL: https://github.com/apache/beam/pull/15610#discussion_r732243918



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -785,10 +785,10 @@ def split(self, desired_bundle_size, start_position=None, stop_position=None):
         self.table_reference.projectId = self._get_project()
 
       schema, metadata_list = self._export_files(bq)
-      self.split_result = [
+      self.split_result = (

Review comment:
       this does not create a tuple. It creates a generator (https://stackoverflow.com/questions/16940293/why-is-there-no-tuple-comprehension-in-python). That results in lazy evaluation of the elements of the generator




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org