You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/11 17:50:25 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7286: Added handling of MSG_WAITALL flag in TCP recv.

pkarashchenko commented on code in PR #7286:
URL: https://github.com/apache/incubator-nuttx/pull/7286#discussion_r992624004


##########
net/tcp/tcp_recvfrom.c:
##########
@@ -706,7 +706,8 @@ ssize_t psock_tcp_recvfrom(FAR struct socket *psock, FAR struct msghdr *msg,
    *    want for more because there may be no timeout).
    */
 
-  if (state.ir_recvlen == 0 && state.ir_buflen > 0)
+  if (((flags & MSG_WAITALL) || state.ir_recvlen == 0) &&

Review Comment:
   ```suggestion
     if (((flags & MSG_WAITALL) != 0 || state.ir_recvlen == 0) &&
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org