You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yongzhi Chen (Code Review)" <ge...@cloudera.org> on 2019/10/08 15:04:05 UTC
[Impala-ASF-CR] IMPALA-9022: Fixed test query profile storage load time filesystem
Yongzhi Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14387
Change subject: IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
......................................................................
IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
Skip part of the test which can be affected by the random behavor
of Catalog V2. The major purpose of the test is to verify storage
load time can be in query profile when metadata loading happens,
which is not affected by the change.
Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
---
M tests/query_test/test_observability.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/14387/1
--
To view, visit http://gerrit.cloudera.org:8080/14387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
Gerrit-Change-Number: 14387
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-9022: Fixed test query profile storage load time filesystem
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14387 )
Change subject: IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14387/1/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:
http://gerrit.cloudera.org:8080/#/c/14387/1/tests/query_test/test_observability.py@674
PS1, Line 674: def test_query_profile_storage_load_time_filesystem(self, unique_database,
I a better fix is to give this an @execute_serially annotation. I looked at the test run and it seems like there are other tests that run concurrently with this one that touch the same tables and might interfere with the table loading.
--
To view, visit http://gerrit.cloudera.org:8080/14387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
Gerrit-Change-Number: 14387
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Oct 2019 15:40:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9022: Fixed test query profile storage load time filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14387 )
Change subject: IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
......................................................................
IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
Skip part of the test which can be affected by the random behavor
of Catalog V2. The major purpose of the test is to verify storage
load time can be in query profile when metadata loading happens,
which is not affected by the change.
Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
Reviewed-on: http://gerrit.cloudera.org:8080/14387
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_observability.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
Gerrit-Change-Number: 14387
Gerrit-PatchSet: 3
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-9022: Fixed test query profile storage load time filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14387 )
Change subject: IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5138/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
Gerrit-Change-Number: 14387
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Oct 2019 18:15:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9022: Fixed test query profile storage load time filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14387 )
Change subject: IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
Gerrit-Change-Number: 14387
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Oct 2019 18:15:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9022: Fixed test query profile storage load time filesystem
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14387 )
Change subject: IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14387/1/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:
http://gerrit.cloudera.org:8080/#/c/14387/1/tests/query_test/test_observability.py@674
PS1, Line 674: def test_query_profile_storage_load_time_filesystem(self, unique_database,
> The test is written with unique_database, it should not be bothered by othe
ok that's a good point :)
--
To view, visit http://gerrit.cloudera.org:8080/14387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
Gerrit-Change-Number: 14387
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Oct 2019 21:13:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9022: Fixed test query profile storage load time filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14387 )
Change subject: IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
Gerrit-Change-Number: 14387
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Oct 2019 22:44:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9022: Fixed test query profile storage load time filesystem
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14387 )
Change subject: IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14387/1/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:
http://gerrit.cloudera.org:8080/#/c/14387/1/tests/query_test/test_observability.py@674
PS1, Line 674: def test_query_profile_storage_load_time_filesystem(self, unique_database,
> I a better fix is to give this an @execute_serially annotation. I looked at
The test is written with unique_database, it should not be bothered by other tests.
--
To view, visit http://gerrit.cloudera.org:8080/14387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
Gerrit-Change-Number: 14387
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Oct 2019 20:40:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9022: Fixed test query profile storage load time filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14387 )
Change subject: IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4747/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
Gerrit-Change-Number: 14387
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Oct 2019 15:45:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9022: Fixed test query profile storage load time filesystem
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14387 )
Change subject: IMPALA-9022: Fixed test_query_profile_storage_load_time_filesystem
......................................................................
Patch Set 1:
Sorry I lost track that I hadn't started the precommit. If you want to manually run it as a non-committer, you can still use https://jenkins.impala.io/job/gerrit-verify-dryrun-external/. That'll run the tests but not auto-merge.
--
To view, visit http://gerrit.cloudera.org:8080/14387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee1afec6f2b706bc28b270aad731a138662490a
Gerrit-Change-Number: 14387
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Oct 2019 18:16:35 +0000
Gerrit-HasComments: No