[GitHub] [buildstream] nanonyme commented on a change in pull request #1574: Create process group for buildbox-casd to suppress SIGINT

[GitBox <gi...@apache.org>]

nanonyme commented on a change in pull request #1574:
URL: https://github.com/apache/buildstream/pull/1574#discussion_r790476206



##########
File path: src/buildstream/_cas/casdprocessmanager.py
##########
@@ -87,12 +86,11 @@ def __init__(self, path, log_dir, log_level, cache_quota, remote_cache_spec, pro
         self._logfile = self._rotate_and_get_next_logfile()
 
         with open(self._logfile, "w", encoding="utf-8") as logfile_fp:
-            # Block SIGINT on buildbox-casd, we don't need to stop it
-            # The frontend will take care of it if needed
-            with _signals.blocked([signal.SIGINT], ignore=False):
-                self.process = subprocess.Popen(  # pylint: disable=consider-using-with
-                    casd_args, cwd=path, stdout=logfile_fp, stderr=subprocess.STDOUT
-                )
+            # Frontend will take care of buildbox-cas so we create
+            # a new process group for it to make SIGINT will be blocked.

Review comment:
       Updated as suggested.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org