You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by jiangphcn <gi...@git.apache.org> on 2017/03/20 09:00:05 UTC

[GitHub] couchdb-couch-index pull request #22: Return value change

GitHub user jiangphcn opened a pull request:

    https://github.com/apache/couchdb-couch-index/pull/22

    Return value change

      - return StateAcc instead of {ok, StateAcc} for fun/2
        in couch_db:fold_purged_docs/5

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch-index COUCHDB-3326-clustered-purge

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch-index/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22
    
----
commit 6fbc319461e985fd852797b048c6cb48a4799df7
Author: jiangphcn <ji...@cn.ibm.com>
Date:   2017-03-20T08:58:05Z

    Return value change
      - return StateAcc instead of {ok, StateAcc} for fun/2
        in couch_db:fold_purged_docs/5

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-index pull request #22: COUCHDB 3326 clustered purge

Posted by jiangphcn <gi...@git.apache.org>.
Github user jiangphcn commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-index/pull/22#discussion_r106895656
  
    --- Diff: src/couch_index_updater.erl ---
    @@ -202,15 +202,16 @@ purge_index(Db, Mod, IdxState) ->
                 {ok, IdxState};
             true ->
                 FoldFun = fun({PurgeSeq, _UUId, Id, Revs}, Acc) ->
    -                Mod:purge(Db, PurgeSeq, [{Id, Revs}], Acc)
    +                {ok, StateAcc} = Mod:purge(Db, PurgeSeq, [{Id, Revs}], Acc),
    +                StateAcc
                 end,
                 {ok, NewStateAcc} = couch_db:fold_purged_docs(
    -                    Db,
    --- End diff --
    
    Thanks, Bob. The format issue was fixed here intentionally to use same indent mode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-index pull request #22: COUCHDB 3326 clustered purge

Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-index/pull/22#discussion_r106891497
  
    --- Diff: src/couch_index_updater.erl ---
    @@ -202,15 +202,16 @@ purge_index(Db, Mod, IdxState) ->
                 {ok, IdxState};
             true ->
                 FoldFun = fun({PurgeSeq, _UUId, Id, Revs}, Acc) ->
    -                Mod:purge(Db, PurgeSeq, [{Id, Revs}], Acc)
    +                {ok, StateAcc} = Mod:purge(Db, PurgeSeq, [{Id, Revs}], Acc),
    +                StateAcc
                 end,
                 {ok, NewStateAcc} = couch_db:fold_purged_docs(
    -                    Db,
    --- End diff --
    
    odd whitespace change here, check your editor settings?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---