You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/07 21:08:59 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3761: Run more datafusion-examples in CI tests
alamb opened a new pull request, #3761:
URL: https://github.com/apache/arrow-datafusion/pull/3761
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/issues/3740
# Rationale for this change
We already check they compile as part of other tests, but we don't check they run without an error
# What changes are included in this PR?
run more of the examples in the test CI job
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3761: Run more datafusion-examples in CI tests
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3761:
URL: https://github.com/apache/arrow-datafusion/pull/3761#discussion_r990500281
##########
datafusion-examples/examples/parquet_sql_multiple_files.rs:
##########
@@ -57,9 +57,9 @@ async fn main() -> Result<()> {
// execute the query
let df = ctx
.sql(
- "SELECT int_col, double_col, CAST(date_string_col as VARCHAR) \
- FROM alltypes_plain \
- WHERE id > 1 AND tinyint_col < double_col",
+ "SELECT * \
+ FROM my_table \
Review Comment:
The table was called "my_table" but the query referred to something else 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #3761: Run all `datafusion-examples` in CI tests
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #3761:
URL: https://github.com/apache/arrow-datafusion/pull/3761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3761: Run all `datafusion-examples` in CI tests
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3761:
URL: https://github.com/apache/arrow-datafusion/pull/3761#issuecomment-1276693318
Benchmark runs are scheduled for baseline = 4cb8ac094ee88dc0023b4cde1b39840a0a362ee0 and contender = 7179c54a11ad42d975c1a870ec2a5688fab98f13. 7179c54a11ad42d975c1a870ec2a5688fab98f13 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ac7d331c259944b7bf9726806ff5691b...6093e9aa94924fef9536ad9b0ed2ccf0/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/dac8ec8fc9144f578a1dda2c0e262017...32d9f50835bc495c90ff070f855bc854/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ba1c95baf8574d84806fd2581ea54183...48b33617c1464a179a28e0e7a6e990aa/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e90001ff18ff49e7b75e5e6cab289b03...6e24e6fa24f641eabb79069c9805c524/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org