You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/11/10 18:13:55 UTC

[GitHub] [incubator-ratis] amaliujia commented on a change in pull request #266: RATIS-1144. Default disable datastream when start a MiniRaftCluster

amaliujia commented on a change in pull request #266:
URL: https://github.com/apache/incubator-ratis/pull/266#discussion_r520769882



##########
File path: ratis-test/src/test/java/org/apache/ratis/datastream/TestDataStreamNetty.java
##########
@@ -96,6 +96,7 @@ private void testCloseStream(int leaderIndex, int numServers) throws Exception {
       RaftPeerId peerId = RaftPeerId.valueOf("s" + i);
       RaftProperties properties = new RaftProperties();
       NettyConfigKeys.DataStream.setPort(properties, NetUtils.createLocalServerAddress().getPort());
+      RaftConfigKeys.DataStream.setType(properties, SupportedDataStreamType.NETTY);

Review comment:
       This line is redundant. If you check line 61 this config is already be set.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org