[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #11036: [fix-10993][Data Quality]Modified Src_table specified when creating DATA_QUALITY contains Spaces. As a result, the corresponding table cannot be found #10993

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #11036:
URL: https://github.com/apache/dolphinscheduler/pull/11036#discussion_r925325682


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java:
##########
@@ -347,6 +350,21 @@ private Map<String, Object> checkTaskDefinitionList(List<TaskDefinitionLog> task
         return result;
     }
 
+    private void converSrcTableFormat(TaskDefinitionLog taskDefinitionLog) {
+        DataQualityParameters dataQualityParameters = JSONUtils
+                .parseObject(taskDefinitionLog.getTaskParams(), DataQualityParameters.class);
+        if (null != dataQualityParameters) {

Review Comment:
   It's better to put this logic into DataQuality task plugin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org