[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6296: Spark-3.3: Use table sort order with sort strategy when user has not specified

[GitBox <gi...@apache.org>]

ajantha-bhat commented on code in PR #6296:
URL: https://github.com/apache/iceberg/pull/6296#discussion_r1033736149


##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -549,6 +559,34 @@ public void testZOrderTableWithSpecialChars() {
     Assert.assertEquals("Table cache must be empty", 0, SparkTableCache.get().size());
   }
 
+  @Test
+  public void testDefaultSortOrder() {

Review Comment:
   This particular testcase fails without the fix in this PR. 
   
   I have also tested the same scenario in the 0.13.x now. It can pass. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org