[GitHub] metamodel issue #139: Support for NOT / NOT IN operator

[kaspersorensen <gi...@git.apache.org>]

Github user kaspersorensen commented on the issue:

    https://github.com/apache/metamodel/pull/139
  
    Your PR suggests to solve the problem in two ways, and that seems to me to be one too many. One way is with the `NegationOperator` which is in a way nice and general, but introduces some redundancy since there are also operators available for "different from". And it is made more obvious with the other solution that you introduce at the same time: Introducing the "not in" operator. Honestly I think that from an API evolution point of view, the second approach ("not in" operator) is the best. Introducing a new generic concept like negation into FilterItem is going to have a lot more side-effects on existing query evaluation. I would just add this one new operator and not handle negation generically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---