You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/10/25 05:59:17 UTC
[GitHub] [druid] gianm commented on a diff in pull request #13259: Fix two sources of SQL statement leaks.
gianm commented on code in PR #13259:
URL: https://github.com/apache/druid/pull/13259#discussion_r1004036956
##########
sql/src/main/java/org/apache/druid/sql/DirectStatement.java:
##########
@@ -301,6 +302,7 @@ public void cancel()
public void close()
{
if (state != State.START && state != State.CLOSED) {
+ // super.close calls closeQuietly, which removes us from the sqlLifecycleManager.
Review Comment:
Ah, now that I read this again, I see that `closeQuietly` is called by both `close` and `closeWithError`. So we can do the second thing you suggested: only clean up the statement there. I just pushed up another commit with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org