You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/07 22:27:25 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #51:
boards/arm/lpc43xx/bambino-200e/src/lpc43_appinit.c: Eliminate a warning
found in build testing.
patacongo opened a new pull request #51: boards/arm/lpc43xx/bambino-200e/src/lpc43_appinit.c: Eliminate a warning found in build testing.
URL: https://github.com/apache/incubator-nuttx/pull/51
The removal of (void) from all functions whose return value has been ignored has introduced several new warnings into the build test output. For example in lpc3_appinit(), I now see this:
# define nsh_spifi_initialize() (OK)
and
nsh_spifi_initialize();
which generaterd a new warning: "warning: statement with no effect [-Wunused-value]". This commit fixes that warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] tritao commented on a change in pull request #51:
boards/arm/lpc43xx/bambino-200e/src/lpc43_appinit.c: Eliminate a warning
found in build testing.
Posted by GitBox <gi...@apache.org>.
tritao commented on a change in pull request #51: boards/arm/lpc43xx/bambino-200e/src/lpc43_appinit.c: Eliminate a warning found in build testing.
URL: https://github.com/apache/incubator-nuttx/pull/51#discussion_r364001613
##########
File path: boards/arm/lpc43xx/bambino-200e/src/lpc43_appinit.c
##########
@@ -173,9 +171,15 @@ int board_app_initialize(uintptr_t arg)
#endif
int ret = 0;
+#ifdef CONFIG_LPC43_SPIFI
/* Initialize the SPIFI block device */
- nsh_spifi_initialize();
+ ret = nsh_spifi_initialize();
+ if (ret != OK)
+ {
+ syslog(LOG_ERR, "ERROR: nsh_spifi_initialize() feils: %d\n", ret);
Review comment:
fails is misspelled here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis merged pull request #51:
boards/arm/lpc43xx/bambino-200e/src/lpc43_appinit.c: Eliminate a warning
found in build testing.
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #51: boards/arm/lpc43xx/bambino-200e/src/lpc43_appinit.c: Eliminate a warning found in build testing.
URL: https://github.com/apache/incubator-nuttx/pull/51
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services