You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "proost (via GitHub)" <gi...@apache.org> on 2026/06/27 01:21:47 UTC
[PR] doc: update RELEASE [datasketches-go]
proost opened a new pull request, #157:
URL: https://github.com/apache/datasketches-go/pull/157
1. specifying commands after release is more convenient for release.
2. scripts in the dev branch assumes src.zip for release package file extension. So i suggest changing it. other core libraries also used src.zip too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] doc: update RELEASE [datasketches-go]
Posted by "freakyzoidberg (via GitHub)" <gi...@apache.org>.
freakyzoidberg commented on code in PR #157:
URL: https://github.com/apache/datasketches-go/pull/157#discussion_r3485541894
##########
RELEASE.md:
##########
@@ -116,11 +116,15 @@ The email must include:
## Step 6: Finalize (After Approval)
-Once you receive at least three +1 binding votes from PMC members and no vetos:
+Once you receive at least three +1 binding votes from PMC members and no votes:
Review Comment:
The correct typo fix is "no vetoes", but we can also rephrase to "no -1 votes"
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] doc: update RELEASE [datasketches-go]
Posted by "proost (via GitHub)" <gi...@apache.org>.
proost commented on code in PR #157:
URL: https://github.com/apache/datasketches-go/pull/157#discussion_r3486010789
##########
RELEASE.md:
##########
@@ -116,11 +116,15 @@ The email must include:
## Step 6: Finalize (After Approval)
-Once you receive at least three +1 binding votes from PMC members and no vetos:
+Once you receive at least three +1 binding votes from PMC members and no votes:
Review Comment:
[a62ea18](https://github.com/apache/datasketches-go/pull/157/commits/a62ea183e78910d57e3a557e8084dc1b69cad234)
you are right. missing -1. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] doc: update RELEASE [datasketches-go]
Posted by "proost (via GitHub)" <gi...@apache.org>.
proost merged PR #157:
URL: https://github.com/apache/datasketches-go/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org