You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/24 02:24:35 UTC
[GitHub] [arrow] Corentin-pro opened a new pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode
Corentin-pro opened a new pull request #12503:
URL: https://github.com/apache/arrow/pull/12503
The proposed fixed made the server auth works for both actual go implementation and other. I am not sure if the base64 padding should be used but in all cases having the server being able to read both seems better (being liberal with the inputs, strict with the output).
An other fix would be to change the Go implementation of the client to use the padded base64 (in `client.go` l.299). But I think making the server more robust is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lukekim commented on pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode
Posted by GitBox <gi...@apache.org>.
lukekim commented on pull request #12503:
URL: https://github.com/apache/arrow/pull/12503#issuecomment-1049434667
Whoops, I totally did not mean to do that O_O
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12503:
URL: https://github.com/apache/arrow/pull/12503#issuecomment-1050116628
Benchmark runs are scheduled for baseline = ae1ce197306eecd5b887577784eb204f3488a688 and contender = efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1. efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2488a10af73e44168f2d25b49aba62c3...fb7c512125fd4180a1ea8abe566b7683/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5ffa8882e05c4209aefd8f59059cf1ca...d0f829ccaf6f4ffea68f305ac4ac199d/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/373c888dcaa44874ba239772a4dfddfa...1a68a6b520314617aebb4c2851d64822/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a1695488e3914ff0ad3d24deb11436f2...f72ed00a708542ef959acc638f568709/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12503:
URL: https://github.com/apache/arrow/pull/12503#issuecomment-1050116628
Benchmark runs are scheduled for baseline = ae1ce197306eecd5b887577784eb204f3488a688 and contender = efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1. efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2488a10af73e44168f2d25b49aba62c3...fb7c512125fd4180a1ea8abe566b7683/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5ffa8882e05c4209aefd8f59059cf1ca...d0f829ccaf6f4ffea68f305ac4ac199d/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/373c888dcaa44874ba239772a4dfddfa...1a68a6b520314617aebb4c2851d64822/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a1695488e3914ff0ad3d24deb11436f2...f72ed00a708542ef959acc638f568709/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade closed pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode
Posted by GitBox <gi...@apache.org>.
zeroshade closed pull request #12503:
URL: https://github.com/apache/arrow/pull/12503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12503:
URL: https://github.com/apache/arrow/pull/12503#issuecomment-1050116628
Benchmark runs are scheduled for baseline = ae1ce197306eecd5b887577784eb204f3488a688 and contender = efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1. efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2488a10af73e44168f2d25b49aba62c3...fb7c512125fd4180a1ea8abe566b7683/)
[Finished :arrow_down:0.17% :arrow_up:0.71%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5ffa8882e05c4209aefd8f59059cf1ca...d0f829ccaf6f4ffea68f305ac4ac199d/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/373c888dcaa44874ba239772a4dfddfa...1a68a6b520314617aebb4c2851d64822/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a1695488e3914ff0ad3d24deb11436f2...f72ed00a708542ef959acc638f568709/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lukekim edited a comment on pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode
Posted by GitBox <gi...@apache.org>.
lukekim edited a comment on pull request #12503:
URL: https://github.com/apache/arrow/pull/12503#issuecomment-1049434667
Whoops, I totally did not mean to do that (approve) O_O. I assume the code maintainers will review and approve, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12503:
URL: https://github.com/apache/arrow/pull/12503#issuecomment-1049430859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12503:
URL: https://github.com/apache/arrow/pull/12503#issuecomment-1050116628
Benchmark runs are scheduled for baseline = ae1ce197306eecd5b887577784eb204f3488a688 and contender = efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1. efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2488a10af73e44168f2d25b49aba62c3...fb7c512125fd4180a1ea8abe566b7683/)
[Finished :arrow_down:0.17% :arrow_up:0.71%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5ffa8882e05c4209aefd8f59059cf1ca...d0f829ccaf6f4ffea68f305ac4ac199d/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/373c888dcaa44874ba239772a4dfddfa...1a68a6b520314617aebb4c2851d64822/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a1695488e3914ff0ad3d24deb11436f2...f72ed00a708542ef959acc638f568709/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12503:
URL: https://github.com/apache/arrow/pull/12503#issuecomment-1050116628
Benchmark runs are scheduled for baseline = ae1ce197306eecd5b887577784eb204f3488a688 and contender = efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1. efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2488a10af73e44168f2d25b49aba62c3...fb7c512125fd4180a1ea8abe566b7683/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5ffa8882e05c4209aefd8f59059cf1ca...d0f829ccaf6f4ffea68f305ac4ac199d/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/373c888dcaa44874ba239772a4dfddfa...1a68a6b520314617aebb4c2851d64822/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a1695488e3914ff0ad3d24deb11436f2...f72ed00a708542ef959acc638f568709/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #12503:
URL: https://github.com/apache/arrow/pull/12503#issuecomment-1050044656
I like it, thanks @Corentin-pro assuming all the tests pass and everything, I'll merge this later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org