You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/05/14 17:46:28 UTC
[kudu-CR] [Java] Add the RangeSchema.getColumnIds
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10390
Change subject: [Java] Add the RangeSchema.getColumnIds
......................................................................
[Java] Add the RangeSchema.getColumnIds
Currently RangeSchema has a method that returns column
IDs called getColumns. Because the return type is a list
of integers it’s unclear if the integers are column indexes
or column IDs.
This change matches the HashBucketSchema by
naming the method getColumnIds. It also deprecates
the old method, and adds Javadoc to make the return
value clear.
Change-Id: Ie4fd944d6b38a2b3fd0ab7f8d6c254be380b2972
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/10390/1
--
To view, visit http://gerrit.cloudera.org:8080/10390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4fd944d6b38a2b3fd0ab7f8d6c254be380b2972
Gerrit-Change-Number: 10390
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [Java] Add the RangeSchema.getColumnIds
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10390 )
Change subject: [Java] Add the RangeSchema.getColumnIds
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fd944d6b38a2b3fd0ab7f8d6c254be380b2972
Gerrit-Change-Number: 10390
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 15 May 2018 22:07:38 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Add the RangeSchema.getColumnIds
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10390 )
Change subject: [Java] Add the RangeSchema.getColumnIds
......................................................................
Patch Set 1: Code-Review+2
I think this is fine, but let's ask Dan.
--
To view, visit http://gerrit.cloudera.org:8080/10390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fd944d6b38a2b3fd0ab7f8d6c254be380b2972
Gerrit-Change-Number: 10390
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 15 May 2018 21:54:57 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Add the RangeSchema.getColumnIds
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10390 )
Change subject: [Java] Add the RangeSchema.getColumnIds
......................................................................
[Java] Add the RangeSchema.getColumnIds
Currently RangeSchema has a method that returns column
IDs called getColumns. Because the return type is a list
of integers it’s unclear if the integers are column indexes
or column IDs.
This change matches the HashBucketSchema by
naming the method getColumnIds. It also deprecates
the old method, and adds Javadoc to make the return
value clear.
Change-Id: Ie4fd944d6b38a2b3fd0ab7f8d6c254be380b2972
Reviewed-on: http://gerrit.cloudera.org:8080/10390
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Dan Burkert <da...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java
1 file changed, 15 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4fd944d6b38a2b3fd0ab7f8d6c254be380b2972
Gerrit-Change-Number: 10390
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>