You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by linwen <gi...@git.apache.org> on 2016/01/29 03:26:10 UTC
[GitHub] incubator-hawq pull request: HAWQ-274. Make function CheckTmpDirAv...
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/303
HAWQ-274. Make function CheckTmpDirAvailable more simple
This fix is to simplify function CheckTmpDirAvailabl(). If can't open a file on this directory, we assume it is a failed dir.
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/linwen/incubator-hawq hawq-274-simple
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #303
----
commit 584a814f6aa73dd9f39cabae4c69383510c03432
Author: Wen Lin <wl...@pivotal.io>
Date: 2016-01-29T02:11:27Z
HAWQ-274. Make function CheckTmpDirAvailable more simple
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Make function CheckTmpDirAv...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/303#discussion_r51220287
--- Diff: src/backend/resourcemanager/resourcemanager_RMSEG.c ---
@@ -258,24 +258,8 @@ bool CheckTmpDirAvailable(char *path)
{
elog(LOG, "Can't open file:%s when check temporary directory", fname);
--- End diff --
elog(LOG, "Cannot open file %s while checking availability of temporary directory: %s",
fname,
strerror(errno));
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Make function CheckTmpDirAv...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/303#issuecomment-176542390
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Make function CheckTmpDirAv...
Posted by linwen <gi...@git.apache.org>.
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/303
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Make function CheckTmpDirAv...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/303#issuecomment-176545971
The code change is ok to me, +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---